Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
8b37dd7f
Commit
8b37dd7f
authored
Sep 10, 2014
by
Tim Babych
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Calculate has_changes only Section/Subsection only on Outline page
parent
d21384fe
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
5 additions
and
8 deletions
+5
-8
cms/djangoapps/contentstore/views/item.py
+2
-4
cms/djangoapps/contentstore/views/tests/test_item.py
+3
-3
common/lib/xmodule/xmodule/modulestore/mongo/draft.py
+0
-1
No files found.
cms/djangoapps/contentstore/views/item.py
View file @
8b37dd7f
...
...
@@ -595,9 +595,6 @@ def _get_module_info(xblock, rewrite_static_links=True):
course_id
=
xblock
.
location
.
course_key
)
# Pre-cache has changes for the entire course because we'll need it for the ancestor info
modulestore
()
.
has_changes
(
modulestore
()
.
get_course
(
xblock
.
location
.
course_key
,
depth
=
None
))
# Note that children aren't being returned until we have a use case.
return
create_xblock_info
(
xblock
,
data
=
data
,
metadata
=
own_metadata
(
xblock
),
include_ancestor_info
=
True
)
...
...
@@ -638,7 +635,8 @@ def create_xblock_info(xblock, data=None, metadata=None, include_ancestor_info=F
return
None
is_xblock_unit
=
is_unit
(
xblock
,
parent_xblock
)
has_changes
=
modulestore
()
.
has_changes
(
xblock
)
# this should not be calculated for Sections and Subsections on Unit page
has_changes
=
modulestore
()
.
has_changes
(
xblock
)
if
(
is_xblock_unit
or
course_outline
)
else
None
if
graders
is
None
:
graders
=
CourseGradingModel
.
fetch
(
xblock
.
location
.
course_key
)
.
graders
...
...
cms/djangoapps/contentstore/views/tests/test_item.py
View file @
8b37dd7f
...
...
@@ -100,9 +100,9 @@ class GetItemTest(ItemTest):
return
html
,
resources
@ddt.data
(
(
1
,
21
,
23
,
35
,
37
),
(
2
,
22
,
24
,
38
,
39
),
(
3
,
23
,
25
,
41
,
41
),
(
1
,
14
,
16
,
30
,
30
),
(
2
,
15
,
17
,
39
,
32
),
(
3
,
16
,
18
,
52
,
34
),
)
@ddt.unpack
def
test_get_query_count
(
self
,
branching_factor
,
chapter_queries
,
section_queries
,
unit_queries
,
problem_queries
):
...
...
common/lib/xmodule/xmodule/modulestore/mongo/draft.py
View file @
8b37dd7f
...
...
@@ -590,7 +590,6 @@ class DraftModuleStore(MongoModuleStore):
_internal
([
root_usage
.
to_deprecated_son
()
for
root_usage
in
root_usages
])
self
.
collection
.
remove
({
'_id'
:
{
'$in'
:
to_be_deleted
}},
safe
=
self
.
collection
.
safe
)
@MongoModuleStore.memoize_request_cache
def
has_changes
(
self
,
xblock
):
"""
Check if the subtree rooted at xblock has any drafts and thus may possibly have changes
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment