Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
848961c5
Commit
848961c5
authored
May 02, 2014
by
Matt Drayer
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #38 from edx-solutions/mattdrayer/group-name-fix2
Added null check for profile name
parents
8a5904f6
7cdcf137
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
6 additions
and
1 deletions
+6
-1
lms/djangoapps/api_manager/groups/tests.py
+5
-0
lms/djangoapps/api_manager/groups/views.py
+1
-1
No files found.
lms/djangoapps/api_manager/groups/tests.py
View file @
848961c5
...
...
@@ -169,6 +169,11 @@ class GroupsApiTests(TestCase):
response
=
self
.
do_get
(
self
.
base_groups_uri
)
self
.
assertEqual
(
response
.
status_code
,
200
)
self
.
assertEqual
(
response
.
data
[
0
][
'name'
],
'{:04d}: {}'
.
format
(
group_id
,
self
.
test_group_name
))
profile
.
name
=
None
profile
.
save
()
response
=
self
.
do_get
(
self
.
base_groups_uri
)
self
.
assertEqual
(
response
.
status_code
,
200
)
self
.
assertEqual
(
response
.
data
[
0
][
'name'
],
'{:04d}: {}'
.
format
(
group_id
,
self
.
test_group_name
))
def
test_group_detail_get
(
self
):
data
=
{
'name'
:
self
.
test_group_name
}
...
...
lms/djangoapps/api_manager/groups/views.py
View file @
848961c5
...
...
@@ -86,7 +86,7 @@ class GroupsList(APIView):
for
profile
in
profiles
:
item_data
=
{}
item_data
[
'group_id'
]
=
profile
.
group_id
if
len
(
profile
.
name
):
if
profile
.
name
and
len
(
profile
.
name
):
group_name
=
profile
.
name
else
:
group
=
Group
.
objects
.
get
(
id
=
profile
.
group_id
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment