Merge pull request #12723 from edx/release

Merge hotfix-2016-06-10 release into master

lms/static/coffee/src/instructor_dashboard/data_download.coffee

@@ -110,6 +110,7 @@ class DataDownload
       url = @$list_proctored_exam_results_csv_btn.data 'endpoint'
       # display html from proctored exam results config endpoint
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         error: (std_ajax_err) =>
@@ -129,6 +130,7 @@ class DataDownload
       url = @$survey_results_csv_btn.data 'endpoint'
       # display html from survey results config endpoint
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         error: (std_ajax_err) =>
@@ -153,6 +155,7 @@ class DataDownload
       url += '/csv'
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         error: (std_ajax_err) =>
@@ -171,6 +174,7 @@ class DataDownload
 
       # fetch user list
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         error: (std_ajax_err) =>
@@ -199,6 +203,7 @@ class DataDownload
 
       url = @$list_problem_responses_csv_btn.data 'endpoint'
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         data:
@@ -215,6 +220,7 @@ class DataDownload
 
       url = @$list_may_enroll_csv_btn.data 'endpoint'
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         error: (std_ajax_err) =>
@@ -228,6 +234,7 @@ class DataDownload
       url = @$grade_config_btn.data 'endpoint'
       # display html from grading config endpoint
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         error: (std_ajax_err) =>
@@ -244,6 +251,7 @@ class DataDownload
         @clear_display()
         url = $(e.target).data 'endpoint'
         $.ajax
+          type: 'POST'
           dataType: 'json'
           url: url
           error: std_ajax_err =>

lms/static/coffee/src/instructor_dashboard/extensions.coffee

@@ -45,6 +45,7 @@ class Extensions
         due_datetime: @$due_datetime_input.val()
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$change_due_date.data 'endpoint'
         data: send_data
@@ -60,6 +61,7 @@ class Extensions
         url: @$url_input.val()
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$reset_due_date.data 'endpoint'
         data: send_data
@@ -75,6 +77,7 @@ class Extensions
       send_data =
         url: @$url_input.val()
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         data: send_data
@@ -90,6 +93,7 @@ class Extensions
       send_data =
         student: @$student_input.val()
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: url
         data: send_data

lms/static/coffee/src/instructor_dashboard/membership.coffee

@@ -137,6 +137,7 @@ class AuthListWidget extends MemberListWidget
   # `cb` is called with cb(error, member_list)
   get_member_list: (cb) ->
     $.ajax
+      type: 'POST'
       dataType: 'json'
       url: @list_endpoint
       data: rolename: @rolename
@@ -151,6 +152,7 @@ class AuthListWidget extends MemberListWidget
   # `cb` is called with cb(error, data)
   modify_member_access: (unique_student_identifier, action, cb) ->
     $.ajax
+      type: 'POST'
       dataType: 'json'
       url: @modify_endpoint
       data:
@@ -645,6 +647,7 @@ class AuthList
     # the endpoint comes from data-endpoint of the table
     $.ajax
       dataType: 'json'
+      type: 'POST'
       url: @$display_table.data 'endpoint'
       data: rolename: @rolename
       success: load_auth_list
@@ -664,6 +667,7 @@ class AuthList
   access_change: (email, action, cb) ->
     $.ajax
       dataType: 'json'
+      type: 'POST'
       url: @$add_section.data 'endpoint'
       data:
         email: email

lms/static/coffee/src/instructor_dashboard/send_email.coffee

@@ -104,6 +104,7 @@ class @SendEmail
         @$btn_task_history_email.click =>
             url = @$btn_task_history_email.data 'endpoint'
             $.ajax
+                type: 'POST'
                 dataType: 'json'
                 url: url
                 success: (data) =>
@@ -120,6 +121,7 @@ class @SendEmail
         @$btn_task_history_email_content.click =>
             url = @$btn_task_history_email_content.data 'endpoint'
             $.ajax
+                type: 'POST'
                 dataType: 'json'
                 url : url
                 success: (data) =>

lms/static/coffee/src/instructor_dashboard/student_admin.coffee

@@ -76,6 +76,7 @@ class @StudentAdmin
       full_error_message = _.template(error_message)({student_id: unique_student_identifier})
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$progress_link.data 'endpoint'
         data: unique_student_identifier: unique_student_identifier
@@ -101,6 +102,7 @@ class @StudentAdmin
       full_error_message = _.template(error_message)({problem_id: problem_to_reset, student_id: unique_student_identifier})
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_reset_attempts_single.data 'endpoint'
         data: send_data
@@ -127,6 +129,7 @@ class @StudentAdmin
         full_error_message = _.template(error_message)({student_id: unique_student_identifier, problem_id: problem_to_reset})
 
         $.ajax
+          type: 'POST'
           dataType: 'json'
           url: @$btn_delete_state_single.data 'endpoint'
           data: send_data
@@ -153,6 +156,7 @@ class @StudentAdmin
       full_error_message = _.template(error_message)({student_id: unique_student_identifier, problem_id: problem_to_reset})
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_rescore_problem_single.data 'endpoint'
         data: send_data
@@ -174,6 +178,7 @@ class @StudentAdmin
       full_error_message = _.template(error_message)({student_id: unique_student_identifier, problem_id: problem_to_reset})
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_task_history_single.data 'endpoint'
         data: send_data
@@ -191,6 +196,7 @@ class @StudentAdmin
         delete_module: false
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_reset_entrance_exam_attempts.data 'endpoint'
         data: send_data
@@ -212,6 +218,7 @@ class @StudentAdmin
         unique_student_identifier: unique_student_identifier
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_rescore_entrance_exam.data 'endpoint'
         data: send_data
@@ -256,6 +263,7 @@ class @StudentAdmin
         delete_module: true
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_delete_entrance_exam_state.data 'endpoint'
         data: send_data
@@ -277,6 +285,7 @@ class @StudentAdmin
         unique_student_identifier: unique_student_identifier
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_entrance_exam_task_history.data 'endpoint'
         data: send_data
@@ -304,6 +313,7 @@ class @StudentAdmin
         full_error_message = _.template(error_message)({problem_id: problem_to_reset})
 
         $.ajax
+          type: 'POST'
           dataType: 'json'
           url: @$btn_reset_attempts_all.data 'endpoint'
           data: send_data
@@ -330,6 +340,7 @@ class @StudentAdmin
         full_error_message = _.template(error_message)({problem_id: problem_to_reset})
 
         $.ajax
+          type: 'POST'
           dataType: 'json'
           url: @$btn_rescore_problem_all.data 'endpoint'
           data: send_data
@@ -348,6 +359,7 @@ class @StudentAdmin
         return @$request_response_error_all.text gettext("Please enter a problem location.")
 
       $.ajax
+        type: 'POST'
         dataType: 'json'
         url: @$btn_task_history_all.data 'endpoint'
         data: send_data

lms/static/coffee/src/instructor_dashboard/util.coffee

@@ -336,6 +336,7 @@ class @PendingInstructorTasks
   reload_running_tasks_list: =>
     list_endpoint = @$table_running_tasks.data 'endpoint'
     $.ajax
+      type: 'POST'
       dataType: 'json'
       url: list_endpoint
       success: (data) =>
@@ -392,6 +393,7 @@ class ReportDownloads
   reload_report_downloads: ->
     endpoint = @$report_downloads_table.data 'endpoint'
     $.ajax
+      type: 'POST'
       dataType: 'json'
       url: endpoint
       success: (data) =>

lms/static/js/instructor_dashboard/ecommerce.js

@@ -45,6 +45,7 @@ var edx = edx || {};
         $('input[name="user-enrollment-report"]').click(function(){
             var url = $(this).data('endpoint');
             $.ajax({
+             type: 'POST',
              dataType: "json",
              url: url,
              success: function (data) {
@@ -64,6 +65,7 @@ var edx = edx || {};
         $('input[name="exec-summary-report"]').click(function(){
             var url = $(this).data('endpoint');
             $.ajax({
+             type: 'POST',
              dataType: "json",
              url: url,
              success: function (data) {

lms/static/js/spec/instructor_dashboard/student_admin_spec.js

@@ -36,15 +36,15 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                 // Spy on AJAX requests
                 var requests = AjaxHelpers.requests(this);
 
-                studentadmin.$field_entrance_exam_student_select_grade.val(unique_student_identifier)
+                studentadmin.$field_entrance_exam_student_select_grade.val(unique_student_identifier);
                 studentadmin.$btn_reset_entrance_exam_attempts.click();
                 // Verify that the client contacts the server to start instructor task
                 var params = $.param({
                     unique_student_identifier: unique_student_identifier,
                     delete_module: false
                 });
-                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate a success response from the server
                 AjaxHelpers.respondWithJson(requests, {
@@ -63,8 +63,8 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                     unique_student_identifier: unique_student_identifier,
                     delete_module: false
                 });
-                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate an error response from the server
                 AjaxHelpers.respondWithError(requests, 400,{});
@@ -96,8 +96,8 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                 var params = $.param({
                     unique_student_identifier: unique_student_identifier
                 });
-                var url = dashboard_api_url + '/rescore_entrance_exam?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/rescore_entrance_exam';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate a success response from the server
                 AjaxHelpers.respondWithJson(requests, {
@@ -115,8 +115,8 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                 var params = $.param({
                     unique_student_identifier: unique_student_identifier
                 });
-                var url = dashboard_api_url + '/rescore_entrance_exam?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/rescore_entrance_exam';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate an error response from the server
                 AjaxHelpers.respondWithError(requests, 400,{});
@@ -195,8 +195,8 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                     unique_student_identifier: unique_student_identifier,
                     delete_module: true
                 });
-                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate a success response from the server
                 AjaxHelpers.respondWithJson(requests, {
@@ -215,8 +215,8 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                     unique_student_identifier: unique_student_identifier,
                     delete_module: true
                 });
-                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/reset_student_attempts_for_entrance_exam';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate an error response from the server
                 AjaxHelpers.respondWithError(requests, 400,{});
@@ -248,8 +248,8 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                 var params = $.param({
                     unique_student_identifier: unique_student_identifier
                 });
-                var url = dashboard_api_url + '/list_entrance_exam_instructor_tasks?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/list_entrance_exam_instructor_tasks';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate a success response from the server
                 AjaxHelpers.respondWithJson(requests, {
@@ -279,8 +279,8 @@ define(['jquery', 'coffee/src/instructor_dashboard/student_admin', 'common/js/sp
                 var params = $.param({
                     unique_student_identifier: unique_student_identifier
                 });
-                var url = dashboard_api_url + '/list_entrance_exam_instructor_tasks?' + params;
-                AjaxHelpers.expectJsonRequest(requests, 'GET', url);
+                var url = dashboard_api_url + '/list_entrance_exam_instructor_tasks';
+                AjaxHelpers.expectPostRequest(requests, url, params);
 
                 // Simulate an error response from the server
                 AjaxHelpers.respondWithError(requests, 400,{});

lms/static/js/spec/staff_debug_actions_spec.js

@@ -91,7 +91,7 @@ define([
                     spyOn($, 'ajax');
                     StaffDebug.reset(locationName, location);
 
-                    expect($.ajax.calls.mostRecent().args[0].type).toEqual('GET');
+                    expect($.ajax.calls.mostRecent().args[0].type).toEqual('POST');
                     expect($.ajax.calls.mostRecent().args[0].data).toEqual({
                         'problem_to_reset': location,
                         'unique_student_identifier': 'userman',
@@ -110,7 +110,7 @@ define([
                     spyOn($, 'ajax');
                     StaffDebug.sdelete(locationName, location);
 
-                    expect($.ajax.calls.mostRecent().args[0].type).toEqual('GET');
+                    expect($.ajax.calls.mostRecent().args[0].type).toEqual('POST');
                     expect($.ajax.calls.mostRecent().args[0].data).toEqual({
                         'problem_to_reset': location,
                         'unique_student_identifier': 'userman',
@@ -130,7 +130,7 @@ define([
                     spyOn($, 'ajax');
                     StaffDebug.rescore(locationName, location);
 
-                    expect($.ajax.calls.mostRecent().args[0].type).toEqual('GET');
+                    expect($.ajax.calls.mostRecent().args[0].type).toEqual('POST');
                     expect($.ajax.calls.mostRecent().args[0].data).toEqual({
                         'problem_to_reset': location,
                         'unique_student_identifier': 'userman',

lms/static/js/staff_debug_actions.js

@@ -31,7 +31,7 @@ var StaffDebug = (function (){
         'delete_module': action.delete_module
     };
     $.ajax({
-        type: "GET",
+        type: "POST",
         url: get_url(action.method),
         data: pdata,
         success: function(data){