Commit 827f91a9 by cahrens

Remove unnecessary ignores in a11y tests.

Also update JIRA tickets.
parent 5454f91d
......@@ -775,13 +775,6 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, WebAppTest):
"""
username, _ = self.log_in_as_unique_user()
profile_page = self.visit_profile_page(username)
profile_page.a11y_audit.config.set_rules({
"ignore": [
'link-href', # TODO: AC-231
],
})
profile_page.a11y_audit.check_for_accessibility_errors()
profile_page.make_field_editable('language_proficiencies')
......@@ -802,13 +795,6 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, WebAppTest):
different_username, _ = self.initialize_different_user(privacy=self.PRIVACY_PUBLIC)
self.log_in_as_unique_user()
profile_page = self.visit_profile_page(different_username)
profile_page.a11y_audit.config.set_rules({
"ignore": [
'link-href', # TODO: AC-231
],
})
profile_page.a11y_audit.check_for_accessibility_errors()
def test_badges_accessibility(self):
......@@ -818,13 +804,6 @@ class LearnerProfileA11yTest(LearnerProfileTestMixin, WebAppTest):
username = 'testcert'
AutoAuthPage(self.browser, username=username).visit()
profile_page = self.visit_profile_page(username)
profile_page.a11y_audit.config.set_rules({
"ignore": [
'link-href', # TODO: AC-231
'color-contrast', # TODO: AC-231
],
})
profile_page.display_accomplishments()
profile_page.a11y_audit.check_for_accessibility_errors()
profile_page.badges[0].display_modal()
......
......@@ -318,10 +318,4 @@ class LmsDashboardA11yTest(BaseLmsDashboardTestMultiple):
"""
course_listings = self.dashboard_page.get_courses()
self.assertEqual(len(course_listings), 3)
self.dashboard_page.a11y_audit.config.set_rules({
'ignore': [
'link-href', # AC-530
'aria-required-children', # AC-534
]
})
self.dashboard_page.a11y_audit.check_for_accessibility_errors()
......@@ -89,7 +89,7 @@ class BulkEmailTest(BaseInstructorDashboardTest):
])
self.send_email_page.a11y_audit.config.set_rules({
"ignore": [
'button-name', # TODO: AC-491
'button-name', # TODO: TNL-5830
]
})
self.send_email_page.a11y_audit.check_for_accessibility_errors()
......@@ -991,13 +991,6 @@ class CertificatesTest(BaseInstructorDashboardTest):
self.certificates_section.a11y_audit.config.set_scope([
'.certificates-wrapper'
])
self.certificates_section.a11y_audit.config.set_rules({
"ignore": [
'checkboxgroup', # TODO: AC-491
'duplicate-id', # TODO: AC-491
'radiogroup', # TODO: AC-491
]
})
self.certificates_section.a11y_audit.check_for_accessibility_errors()
......@@ -1207,10 +1200,4 @@ class CertificateInvalidationTest(BaseInstructorDashboardTest):
self.certificates_section.a11y_audit.config.set_scope([
'.certificates-wrapper'
])
self.certificates_section.a11y_audit.config.set_rules({
"ignore": [
'duplicate-id', # TODO: AC-491
'radiogroup', # TODO: AC-491
]
})
self.certificates_section.a11y_audit.check_for_accessibility_errors()
......@@ -652,12 +652,9 @@ class StudioLibraryA11yTest(StudioLibraryTest):
lib_page.visit()
lib_page.wait_until_ready()
# There are several existing color contrast errors on this page,
# we will ignore this error in the test until we fix them.
lib_page.a11y_audit.config.set_rules({
"ignore": [
'icon-aria-hidden', # TODO: AC-229
'link-href', # TODO: AC-564
'link-href', # TODO: AC-590
],
})
......
......@@ -500,12 +500,9 @@ class StudioSettingsA11yTest(StudioCourseTest):
self.settings_page.visit()
self.settings_page.wait_for_page()
# There are several existing color contrast errors on this page,
# we will ignore this error in the test until we fix them.
self.settings_page.a11y_audit.config.set_rules({
"ignore": [
'link-href', # TODO: AC-557
'icon-aria-hidden', # TODO: AC-229
'link-href', # TODO: AC-590
],
})
......@@ -515,7 +512,7 @@ class StudioSettingsA11yTest(StudioCourseTest):
# on this page. CodeMirror generates markup that does
# not pass our accessibility testing rules.
self.settings_page.a11y_audit.config.set_scope(
exclude=['.CodeMirror textarea']
exclude=['.CodeMirror textarea'] # TODO: TNL-5831
)
self.settings_page.a11y_audit.check_for_accessibility_errors()
......
......@@ -61,7 +61,6 @@ class TextbooksTest(StudioCourseTest):
self.textbook_view_page.a11y_audit.config.set_rules({
'ignore': [
'skip-link', # AC-501
'section' # AC-503
],
})
......@@ -85,9 +84,6 @@ class TextbooksTest(StudioCourseTest):
self.textbook_view_page.a11y_audit.config.set_rules({
'ignore': [
'color-contrast', # will always fail because pdf.js converts pdf to divs with transparent text
'html-lang', # AC-504
'meta-viewport', # AC-505
'skip-link', # AC-506
],
})
self.textbook_view_page.a11y_audit.check_for_accessibility_errors()
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment