Remove "flagged discussions" from forum topic menu

This feature is supplanted by the flagged option in the filter menu,
which can work within topics as well as across all topics.

common/static/coffee/spec/discussion/view/discussion_thread_list_view_spec.coffee

@@ -97,9 +97,6 @@ describe "DiscussionThreadListView", ->
                     <li class="forum-nav-browse-menu-item forum-nav-browse-menu-all">
                         <a href="#" class="forum-nav-browse-title">All Discussions</a>
                     </li>
-                    <li class="forum-nav-browse-menu-item forum-nav-browse-menu-flagged">
-                        <a href="#" class="forum-nav-browse-title"><i class="icon icon-flag"></i>Flagged Discussions</a>
-                    </li>
                     <li class="forum-nav-browse-menu-item forum-nav-browse-menu-following">
                         <a href="#" class="forum-nav-browse-title"><i class="icon icon-star"></i>Posts I'm Following</a>
                     </li>
@@ -528,7 +525,7 @@ describe "DiscussionThreadListView", ->
             expect(visibleItems).toEqual(expectedItems)
 
           it "should be case-insensitive", ->
-            checkFilter("flagged", ["Flagged Discussions"])
+            checkFilter("other", ["Other Category"])
 
           it "should match partial words", ->
             checkFilter("ateg", ["Other Category"])

common/static/coffee/src/discussion/discussion.coffee

@@ -45,9 +45,6 @@ if Backbone?
           data['commentable_ids'] = options.commentable_ids
         when 'all'
           url = DiscussionUtil.urlFor 'threads'
-        when 'flagged'
-          data['flagged'] = true
-          url = DiscussionUtil.urlFor 'search'
         when 'followed'
           url = DiscussionUtil.urlFor 'followed_threads', options.user_id
       if options['group_id']

common/static/coffee/src/discussion/views/discussion_thread_list_view.coffee

@@ -364,10 +364,6 @@ if Backbone?
         @discussionIds = ""
         @$('.forum-nav-filter-cohort').show()
         @retrieveAllThreads()
-      else if item.hasClass("forum-nav-browse-menu-flagged")
-        @discussionIds = ""
-        @$('.forum-nav-filter-cohort').hide()
-        @retrieveFlaggedThreads() 
       else if item.hasClass("forum-nav-browse-menu-following")
         @retrieveFollowed()
         @$('.forum-nav-filter-cohort').hide()
@@ -416,12 +412,6 @@ if Backbone?
       @collection.reset()
       @loadMorePages(event)
 
-    retrieveFlaggedThreads: (event)->
-      @collection.current_page = 0
-      @collection.reset()
-      @mode = 'flagged'
-      @loadMorePages(event)
-
     sortThreads: (event) ->
       @displayedCollection.setSortComparator(@$(".forum-nav-sort-control").val())
 

lms/templates/discussion/_filter_dropdown.html

@@ -42,11 +42,6 @@
         <li class="forum-nav-browse-menu-item forum-nav-browse-menu-all">
             <a href="#" class="forum-nav-browse-title">${_("All Discussions")}</a>
         </li>
-        %if flag_moderator:
-        <li class="forum-nav-browse-menu-item forum-nav-browse-menu-flagged">
-            <a href="#" class="forum-nav-browse-title"><i class="icon icon-flag"></i>${_("Flagged Discussions")}</a>
-        </li>
-        %endif
         <li class="forum-nav-browse-menu-item forum-nav-browse-menu-following">
             <a href="#" class="forum-nav-browse-title"><i class="icon icon-star"></i>${_("Posts I'm Following")}</a>
         </li>