Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
73fa3190
Commit
73fa3190
authored
Feb 22, 2016
by
Eric Fischer
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Revert "Inform openassessment to clear submission"
This reverts commit
920cc3d2
.
parent
bf5d2034
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
21 deletions
+8
-21
lms/djangoapps/instructor/enrollment.py
+6
-19
requirements/edx/github.txt
+2
-2
No files found.
lms/djangoapps/instructor/enrollment.py
View file @
73fa3190
...
...
@@ -219,8 +219,6 @@ def reset_student_attempts(course_id, student, module_state_key, delete_module=F
submissions.SubmissionError: unexpected error occurred while resetting the score in the submissions API.
"""
user_id
=
anonymous_id_for_user
(
student
,
course_id
)
submission_cleared
=
False
try
:
# A block may have children. Clear state on children first.
block
=
modulestore
()
.
get_item
(
module_state_key
)
...
...
@@ -231,27 +229,16 @@ def reset_student_attempts(course_id, student, module_state_key, delete_module=F
except
StudentModule
.
DoesNotExist
:
# If a particular child doesn't have any state, no big deal, as long as the parent does.
pass
if
delete_module
:
# Some blocks (openassessment) use StudentModule data as a key for internal submission data.
# Inform these blocks of the reset and allow them to handle their data.
clear_student_state
=
getattr
(
block
,
"clear_student_state"
,
None
)
if
callable
(
clear_student_state
):
clear_student_state
(
user_id
=
user_id
,
course_id
=
unicode
(
course_id
),
item_id
=
unicode
(
module_state_key
)
)
submission_cleared
=
True
except
ItemNotFoundError
:
log
.
warning
(
"Could not find
%
s in modulestore when attempting to reset attempts."
,
module_state_key
)
# Reset the student's score in the submissions API
, if xblock.clear_student_state has not done so already.
#
TODO: Remove this once we've finalized and communicated how xblocks should handle clear_student_state
#
and made sure that other xblocks relying on the submission api understand this is going away.
#
We need to do this before retrieving the `StudentModule` model, because a score may exist with no student module
.
if
delete_module
and
not
submission_cleared
:
# Reset the student's score in the submissions API
#
Currently this is used only by open assessment (ORA 2)
#
We need to do this *before* retrieving the `StudentModule` model,
#
because it's possible for a score to exist even if no student module exists
.
if
delete_module
:
sub_api
.
reset_score
(
user_id
,
anonymous_id_for_user
(
student
,
course_id
)
,
course_id
.
to_deprecated_string
(),
module_state_key
.
to_deprecated_string
(),
)
...
...
requirements/edx/github.txt
View file @
73fa3190
...
...
@@ -77,8 +77,8 @@ git+https://github.com/edx/XBlock.git@xblock-0.4.4#egg=XBlock==0.4.4
-e git+https://github.com/edx/event-tracking.git@0.2.1#egg=event-tracking==0.2.1
-e git+https://github.com/edx/django-splash.git@v0.2#egg=django-splash==0.2
-e git+https://github.com/edx/acid-block.git@e46f9cda8a03e121a00c7e347084d142d22ebfb7#egg=acid-xblock
-e git+https://github.com/edx/edx-ora2.git@0.2.
8#egg=ora2==0.2.8
-e git+https://github.com/edx/edx-submissions.git@0.1.
4#egg=edx-submissions==0.1.4
-e git+https://github.com/edx/edx-ora2.git@0.2.
7#egg=ora2==0.2.7
-e git+https://github.com/edx/edx-submissions.git@0.1.
3#egg=edx-submissions==0.1.3
git+https://github.com/edx/ease.git@release-2015-07-14#egg=ease==0.1.3
git+https://github.com/edx/i18n-tools.git@v0.2#egg=i18n-tools==v0.2
git+https://github.com/edx/edx-val.git@0.0.9#egg=edxval==0.0.9
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment