Skip to content

E
edx-platform
Commit 723772ab by Valera Rozuvan
Options

Rewrote Jasmine tests for slider range to reuse function. More compact and concise.

parent 15909954
Showing with 43 additions and 59 deletions
common/lib/xmodule/xmodule/js/spec/video/general_spec.js
...@@ -185,75 +185,59 @@ ...@@ -185,75 +185,59 @@
}); });
describe('checking start and end times', function () { describe('checking start and end times', function () {
var miniTestSuite = [
{
itDescription: 'both times are proper',
data: {start: 12, end: 24},
expectData: {start: 12, end: 24}
},
{
itDescription: 'start time is invalid',
data: {start: '', end: 24},
expectData: {start: 0, end: 24}
},
{
itDescription: 'end time is invalid',
data: {start: 12, end: ''},
expectData: {start: 12, end: null}
},
{
itDescription: 'start time is less than 0',
data: {start: -12, end: 24},
expectData: {start: 0, end: 24}
},
{
itDescription: 'start time is greater than end time',
data: {start: 42, end: 24},
expectData: {start: 42, end: null}
},
];
beforeEach(function () { beforeEach(function () {
loadFixtures('video.html'); loadFixtures('video.html');
}); });
it('both times are proper', function () { $.each(miniTestSuite, function (index, test) {
$('#example').find('.video') itFabrique(test.itDescription, test.data, test.expectData);
.data({
'start': 12,
'end': 24
});
state = new Video('#example');
expect(state.config.start).toBe(12);
expect(state.config.end).toBe(24);
});
it('start time is invalid', function () {
$('#example').find('.video')
.data({
'start': '',
'end': 24
});
state = new Video('#example');
expect(state.config.start).toBe(0);
expect(state.config.end).toBe(24);
});
it('end time is invalid', function () {
$('#example').find('.video')
.data({
'start': 12,
'end': ''
});
state = new Video('#example');
expect(state.config.start).toBe(12);
expect(state.config.end).toBe(null);
}); });
it('start time is less than 0', function () { return;
$('#example').find('.video')
.data({
'start': -12,
'end': 24
});
state = new Video('#example');
expect(state.config.start).toBe(0);
expect(state.config.end).toBe(24);
});
it('start time is greater than end time', function () { function itFabrique(itDescription, data, expectData) {
$('#example').find('.video') it(itDescription, function () {
.data({ $('#example').find('.video')
'start': 42, .data({
'end': 24 'start': data.start,
}); 'end': data.end
});
state = new Video('#example'); state = new Video('#example');
expect(state.config.start).toBe(42); expect(state.config.start).toBe(expectData.start);
expect(state.config.end).toBe(null); expect(state.config.end).toBe(expectData.end);
}); });
}
}); });
describe('multiple YT on page', function () { describe('multiple YT on page', function () {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment