Merge pull request #6122 from edx/clytwynec/dont-fail-diff-quality-for-todo

Clytwynec/dont fail diff quality for todo

pavelib/quality.py

@@ -195,14 +195,12 @@ def run_quality(options):
         sh(
             "{pythonpath_prefix} diff-quality --violations=pylint "
             "{pylint_reports} {percentage_string} {compare_branch_string} "
-            "--html-report {dquality_dir}/diff_quality_pylint.html "
-            "--options='{pylint_options}'".format(
+            "--html-report {dquality_dir}/diff_quality_pylint.html ".format(
                 pythonpath_prefix=pythonpath_prefix,
                 pylint_reports=pylint_reports,
                 percentage_string=percentage_string,
                 compare_branch_string=compare_branch_string,
                 dquality_dir=dquality_dir,
-                pylint_options="--disable=fixme",
             )
         )
     except BuildFailure, error_message:

pylintrc

@@ -47,6 +47,9 @@ disable=
 # W0232: Class has no __init__ method
     W0232,
 
+# Disable 'fixme' so that quality builds don't fail due to them
+    W0511,
+
 # Might use these when the code is in better shape
 # C0302: Too many lines in module
 # R0201: Method could be a function