Merge pull request #15387 from cpennington/ret/optimizely-sock

Put the verification-sock html on the page all the time so that we can easily experiment on it with optimizely

openedx/features/course_experience/templates/course_experience/course-sock-fragment.html

@@ -9,8 +9,12 @@ from openedx.features.course_experience import DISPLAY_COURSE_SOCK_FLAG
 %>
 
 <%block name="content">
-    % if show_course_sock and DISPLAY_COURSE_SOCK_FLAG.is_enabled(course_id):
-    <div class="verification-sock">
+    % if show_course_sock:
+    <div class="verification-sock"
+        % if not DISPLAY_COURSE_SOCK_FLAG.is_enabled(course_id):
+        style="display: none"
+        %endif
+    >
         <button type="button" class="btn btn-brand focusable action-toggle-verification-sock">
             Learn About Verified Certificate
         </button>
@@ -46,7 +50,7 @@ from openedx.features.course_experience import DISPLAY_COURSE_SOCK_FLAG
                     <div class="story-quote">
                         I wanted to include a verified certificate on my resume and my profile to
                         illustrate that I am working towards this goal I have and that I have
-                        achieved something while I was unemployed.</br>
+                        achieved something while I was unemployed.<br/>
                         <span class="author">- Cheryl Troell, edX Learner</span>
                     </div>
                 </div>
@@ -59,7 +63,7 @@ from openedx.features.course_experience import DISPLAY_COURSE_SOCK_FLAG
             </div>
         </div>
     </div>
-    % endif
+    %endif
 </%block>
 
 <%static:webpack entry="CourseSock">

openedx/features/course_experience/tests/views/test_course_sock.py

@@ -4,8 +4,10 @@ Tests for course verification sock
 
 import datetime
 import ddt
+from django.template.loader import render_to_string
 
 from course_modes.models import CourseMode
+from courseware.views.views import get_course_prices
 from openedx.core.djangoapps.waffle_utils.testutils import override_waffle_flag
 from openedx.features.course_experience import DISPLAY_COURSE_SOCK_FLAG
 from student.tests.factories import UserFactory, CourseEnrollmentFactory
@@ -14,7 +16,7 @@ from xmodule.modulestore.tests.factories import CourseFactory
 from .test_course_home import course_home_url
 
 TEST_PASSWORD = 'test'
-TEST_VERIFICATION_SOCK_LOCATOR = '<div class="verification-sock">'
+TEST_VERIFICATION_SOCK_LOCATOR = '<div class="verification-sock"'
 TEST_COURSE_PRICE = 50
 
 
@@ -58,8 +60,7 @@ class TestCourseSockView(SharedModuleStoreTestCase):
         not have a visible verification sock.
         """
         response = self.client.get(course_home_url(self.standard_course))
-        self.assertEqual(self.is_verified_sock_visible(response), False,
-                         'Student should not be able to see sock in a unverifiable course.')
+        self.assert_verified_sock_is_not_visible(self.standard_course, response)
 
     @override_waffle_flag(DISPLAY_COURSE_SOCK_FLAG, active=True)
     def test_verified_course(self):
@@ -68,8 +69,7 @@ class TestCourseSockView(SharedModuleStoreTestCase):
         visible verification sock.
         """
         response = self.client.get(course_home_url(self.verified_course))
-        self.assertEqual(self.is_verified_sock_visible(response), True,
-                         'Student should be able to see sock in a verifiable course.')
+        self.assert_verified_sock_is_visible(self.verified_course, response)
 
     @override_waffle_flag(DISPLAY_COURSE_SOCK_FLAG, active=True)
     def test_verified_course_updated_expired(self):
@@ -78,8 +78,7 @@ class TestCourseSockView(SharedModuleStoreTestCase):
         date does not display the verification sock.
         """
         response = self.client.get(course_home_url(self.verified_course_update_expired))
-        self.assertEqual(self.is_verified_sock_visible(response), False,
-                         'Student should be able to see sock in a verifiable course if the update expiration date has passed.')
+        self.assert_verified_sock_is_not_visible(self.verified_course_update_expired, response)
 
     @override_waffle_flag(DISPLAY_COURSE_SOCK_FLAG, active=True)
     def test_verified_course_user_already_upgraded(self):
@@ -88,12 +87,21 @@ class TestCourseSockView(SharedModuleStoreTestCase):
         verified status cannot see the verification sock.
         """
         response = self.client.get(course_home_url(self.verified_course_already_enrolled))
-        self.assertEqual(self.is_verified_sock_visible(response), False,
-                         'Student should be able to see sock if they have already upgraded to verified mode.')
-
-    @classmethod
-    def is_verified_sock_visible(cls, response):
-        return TEST_VERIFICATION_SOCK_LOCATOR in response.content
+        self.assert_verified_sock_is_not_visible(self.verified_course_already_enrolled, response)
+
+    def assert_verified_sock_is_visible(self, course, response):
+        return self.assertIn(
+            TEST_VERIFICATION_SOCK_LOCATOR,
+            response.content,
+            msg='Student should be able to see sock if they have already upgraded to verified mode.',
+        )
+
+    def assert_verified_sock_is_not_visible(self, course, response):
+        return self.assertNotIn(
+            TEST_VERIFICATION_SOCK_LOCATOR,
+            response.content,
+            msg='Student should not be able to see sock in a unverifiable course.',
+        )
 
     @classmethod
     def _add_course_mode(cls, course, upgrade_deadline_expired=False):