Merge pull request #13858 from edx/aj/TNL-5582_flaky_updates_test

Update to reduce flakiness of this test set removed flaky annotation

cms/templates/course_info.html

@@ -45,7 +45,7 @@ from openedx.core.djangolib.js_utils import (
         <h3 class="sr">${_('Page Actions')}</h3>
         <ul>
           <li class="nav-item">
-            <a href="#" class=" button new-button new-update-button"><span class="icon fa fa-plus" aria-hidden="true"></span> ${_('New Update')}</a>
+            <a href="#" class=" button new-button new-update-button" disabled><span class="icon fa fa-plus" aria-hidden="true"></span> ${_('New Update')}</a>
           </li>
         </ul>
       </nav>

common/test/acceptance/pages/studio/course_info.py

@@ -37,6 +37,14 @@ class CourseUpdatesPage(CoursePage):
         """
         Clicks the new-update button.
         """
+        def is_update_button_enabled():
+            """
+            Checks if the New Update button is enabled
+            """
+            return self.q(css='.new-update-button').attrs('disabled')[0] is None
+
+        self.wait_for(promise_check_func=is_update_button_enabled,
+                      description='Waiting for the New update button to be enabled.')
         click_css(self, '.new-update-button', require_notification=False)
         self.wait_for_element_visibility('.CodeMirror', 'Waiting for .CodeMirror')
 

common/test/acceptance/tests/studio/test_studio_course_info.py

 """
 Acceptance Tests for Course Information
 """
-from flaky import flaky
-
 from common.test.acceptance.pages.studio.course_info import CourseUpdatesPage
 from common.test.acceptance.tests.studio.base_studio_test import StudioCourseTest
 
@@ -79,7 +77,6 @@ class UsersCanAddUpdatesTest(StudioCourseTest):
         self.assertFalse(self.course_updates_page.is_first_update_message('Hello'))
         self.assertTrue(self.course_updates_page.is_first_update_message('Goodbye'))
 
-    @flaky  # TNL-5582
     def test_delete_course_update(self):
         """
         Scenario: Users can delete updates
@@ -109,7 +106,6 @@ class UsersCanAddUpdatesTest(StudioCourseTest):
         self.course_updates_page.click_new_update_save_button()
         self.assertTrue(self.course_updates_page.is_first_update_date('June 1, 2013'))
 
-    @flaky  # TNL-5775
     def test_outside_tag_preserved(self):
         """
         Scenario: Text outside of tags is preserved
@@ -124,7 +120,6 @@ class UsersCanAddUpdatesTest(StudioCourseTest):
         self.course_updates_page.visit()
         self.assertTrue(self.course_updates_page.is_first_update_message('before <strong>middle</strong> after'))
 
-    @flaky  # TNL-5773
     def test_asset_change_in_updates(self):
         """
         Scenario: Static links are rewritten when previewing a course update