Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
58f93cc7
Commit
58f93cc7
authored
Oct 26, 2017
by
Harry Rein
Committed by
Andy Armstrong
Oct 29, 2017
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Styling fixes for the dashboard and course header.
parent
d0f348d3
Expand all
Hide whitespace changes
Inline
Side-by-side
Showing
8 changed files
with
41 additions
and
23 deletions
+41
-23
lms/djangoapps/courseware/testutils.py
+1
-1
lms/static/sass/_header.scss
+29
-15
lms/static/sass/bootstrap/_layouts.scss
+7
-3
lms/static/sass/multicourse/_dashboard.scss
+0
-0
lms/static/sass/shared-v2/_components.scss
+1
-1
lms/templates/header/user_dropdown.html
+1
-1
lms/templates/main.html
+1
-1
lms/templates/preview_menu.html
+1
-1
No files found.
lms/djangoapps/courseware/testutils.py
View file @
58f93cc7
...
@@ -33,7 +33,7 @@ class RenderXBlockTestMixin(object):
...
@@ -33,7 +33,7 @@ class RenderXBlockTestMixin(object):
'<ol class="tabs course-tabs"'
,
'<ol class="tabs course-tabs"'
,
'<footer id="footer-openedx"'
,
'<footer id="footer-openedx"'
,
'<div class="window-wrap"'
,
'<div class="window-wrap"'
,
'<div class="preview-menu
container
"'
,
'<div class="preview-menu"'
,
'<div class="container"'
,
'<div class="container"'
,
]
]
...
...
lms/static/sass/_header.scss
View file @
58f93cc7
...
@@ -30,28 +30,36 @@
...
@@ -30,28 +30,36 @@
height
:
$header-logo-height
;
height
:
$header-logo-height
;
}
}
@include
media-breakpoint-down
(
sm
)
{
@include
media-breakpoint-down
(
md
)
{
margin-left
:
calc
(
50%
-
30px
);
@include
margin-left
(
50%
);
height
:
$header-logo-height
;
height
:
$header-logo-height
;
width
:
auto
;
width
:
auto
;
.logo
{
@include
margin-left
(
-50%
);
}
}
}
}
}
.course-header
{
.course-header
{
@include
float
(
left
);
@include
float
(
left
);
@include
margin
(
$baseline
*
1
.25
,
0
,
0
,
$baseline
);
@include
margin
(
$baseline
*
0
.8
,
0
,
0
,
$baseline
);
font-size
:
$font-size-
lg
;
font-size
:
$font-size-
sm
;
color
:
theme-color
(
"dark"
);
color
:
theme-color
(
"dark"
);
line-height
:
1em
;
line-height
:
1em
;
display
:
none
;
display
:
none
;
.provider
{
.course-name
{
font-weight
:
$font-weight-bold
;
display
:
block
;
font-size
:
$font-size-base
;
margin-top
:
7px
;
font-weight
:
600
;
}
}
// Hide the course header for smaller screen sizes
// Hide the course header for smaller screen sizes
@include
media-breakpoint-up
(
md
)
{
@include
media-breakpoint-up
(
lg
)
{
display
:
block
;
display
:
block
;
}
}
}
}
...
@@ -64,7 +72,7 @@
...
@@ -64,7 +72,7 @@
by the desktop styling
by the desktop styling
*/
*/
// Desktop styling
// Desktop styling
@include
media-breakpoint-up
(
md
)
{
@include
media-breakpoint-up
(
lg
)
{
.nav-links
{
.nav-links
{
.nav-item
{
.nav-item
{
margin
:
0
$baseline
;
margin
:
0
$baseline
;
...
@@ -90,11 +98,11 @@
...
@@ -90,11 +98,11 @@
a
{
a
{
color
:
theme-color
(
"secondary"
);
color
:
theme-color
(
"secondary"
);
padding
:
$baseline
*
0
.35
$baseline
*
1
.25
$baseline
;
padding
:
$baseline
*
0
.35
$baseline
*
1
.25
19px
;
font-weight
:
$font-weight-normal
;
font-weight
:
$font-weight-normal
;
display
:
inline-block
;
display
:
inline-block
;
margin-bottom
:
-1
*
$baseline
/
2
;
margin-bottom
:
-1
*
$baseline
/
2
;
border-bottom
:
2
px
solid
transparent
;
border-bottom
:
3
px
solid
transparent
;
cursor
:
pointer
;
cursor
:
pointer
;
&
.active
,
&
.active
,
...
@@ -121,9 +129,14 @@
...
@@ -121,9 +129,14 @@
padding
:
$baseline
/
2
0
0
;
padding
:
$baseline
/
2
0
0
;
margin
:
0
$baseline
/
2
;
margin
:
0
$baseline
/
2
;
&
.nav-item-dropdown
{
padding
:
0
;
margin
:
0
;
}
a
{
a
{
color
:
theme-color
(
"dark"
);
color
:
theme-color
(
"dark"
);
font-weight
:
$font-weight-
bold
;
font-weight
:
$font-weight-
normal
;
}
}
}
}
...
@@ -173,6 +186,7 @@
...
@@ -173,6 +186,7 @@
// Dropdown behavior
// Dropdown behavior
.toggle-user-dropdown
{
.toggle-user-dropdown
{
padding
:
$baseline
/
2
;
text-decoration
:
none
;
text-decoration
:
none
;
cursor
:
pointer
;
cursor
:
pointer
;
}
}
...
@@ -224,7 +238,7 @@
...
@@ -224,7 +238,7 @@
}
}
// Responsive styling for mobile
// Responsive styling for mobile
@include
media-breakpoint-down
(
sm
)
{
@include
media-breakpoint-down
(
md
)
{
// Display the menu icon and allow for transition to an X on click
// Display the menu icon and allow for transition to an X on click
.hamburger-menu
{
.hamburger-menu
{
@include
left
(
22px
);
@include
left
(
22px
);
...
@@ -308,11 +322,11 @@
...
@@ -308,11 +322,11 @@
.mobile-menu
{
.mobile-menu
{
border-bottom
:
1px
solid
theme-color
(
'primary'
);
border-bottom
:
1px
solid
theme-color
(
'primary'
);
@include
media-breakpoint-up
(
md
)
{
@include
media-breakpoint-up
(
lg
)
{
display
:
none
!
important
;
display
:
none
!
important
;
}
}
@include
media-breakpoint-down
(
sm
)
{
@include
media-breakpoint-down
(
md
)
{
display
:
none
;
display
:
none
;
// Override standard styling for the mobile menu links
// Override standard styling for the mobile menu links
...
@@ -353,7 +367,7 @@
...
@@ -353,7 +367,7 @@
// Hide elements in menu bar when they exist in mobile
// Hide elements in menu bar when they exist in mobile
.hidden-mobile
{
.hidden-mobile
{
@include
media-breakpoint-down
(
sm
)
{
@include
media-breakpoint-down
(
md
)
{
&
:not
(
.mobile-nav-link
)
{
&
:not
(
.mobile-nav-link
)
{
display
:
none
;
display
:
none
;
}
}
...
...
lms/static/sass/bootstrap/_layouts.scss
View file @
58f93cc7
...
@@ -5,7 +5,7 @@
...
@@ -5,7 +5,7 @@
padding-bottom
:
$baseline
*
2
;
padding-bottom
:
$baseline
*
2
;
.course-tabs
{
.course-tabs
{
padding
:
0
;
padding
:
0
$baseline
*
2
;
font-size
:
$font-size-sm
;
font-size
:
$font-size-sm
;
.nav-item
{
.nav-item
{
...
@@ -42,7 +42,7 @@
...
@@ -42,7 +42,7 @@
display
:
flex
;
display
:
flex
;
flex-wrap
:
wrap
;
flex-wrap
:
wrap
;
border-bottom
:
1px
solid
$border-color
;
border-bottom
:
1px
solid
$border-color
;
padding
:
20px
;
padding
:
$baseline
$baseline
*
2
;
.page-header-search
{
.page-header-search
{
@include
margin-right
(
$baseline
);
@include
margin-right
(
$baseline
);
...
@@ -62,6 +62,10 @@
...
@@ -62,6 +62,10 @@
.page-header-main
{
.page-header-main
{
flex-grow
:
1
;
// This column should consume all the available space
flex-grow
:
1
;
// This column should consume all the available space
.page-title
{
margin-top
:
$baseline
*
0
.4
;
}
}
}
.page-header-secondary
{
.page-header-secondary
{
...
@@ -84,7 +88,7 @@
...
@@ -84,7 +88,7 @@
}
}
.page-content
{
.page-content
{
padding
:
$baseline
;
padding
:
$baseline
*
2
;
@include
media-breakpoint-up
(
md
)
{
@include
media-breakpoint-up
(
md
)
{
display
:
flex
;
display
:
flex
;
...
...
lms/static/sass/multicourse/_dashboard.scss
View file @
58f93cc7
This diff is collapsed.
Click to expand it.
lms/static/sass/shared-v2/_components.scss
View file @
58f93cc7
...
@@ -148,7 +148,7 @@
...
@@ -148,7 +148,7 @@
@include
box-sizing
(
border-box
);
@include
box-sizing
(
border-box
);
margin
:
0
auto
;
margin
:
0
auto
;
padding
:
(
$baseline
*
0
.75
);
padding
:
(
$baseline
*
0
.75
)
(
$baseline
*
2
)
;
background-color
:
$lms-preview-menu-color
;
background-color
:
$lms-preview-menu-color
;
@media
print
{
@media
print
{
...
...
lms/templates/header/user_dropdown.html
View file @
58f93cc7
...
@@ -27,7 +27,7 @@ from openedx.core.djangoapps.user_api.accounts.image_helpers import get_profile_
...
@@ -27,7 +27,7 @@ from openedx.core.djangoapps.user_api.accounts.image_helpers import get_profile_
<span
class=
"username"
>
${username}
</span>
<span
class=
"username"
>
${username}
</span>
</a>
</a>
</div>
</div>
<div
class=
"nav-item hidden-mobile"
tabindex=
"-1"
>
<div
class=
"nav-item hidden-mobile
nav-item-dropdown
"
tabindex=
"-1"
>
<div
class=
"user-dropdown"
aria-expanded=
"false"
aria-haspopup=
"true"
aria-controls=
"user-menu"
>
<div
class=
"user-dropdown"
aria-expanded=
"false"
aria-haspopup=
"true"
aria-controls=
"user-menu"
>
<span
class=
"sr"
>
user menu
</span>
<span
class=
"sr"
>
user menu
</span>
<span
class=
"fa fa-caret-down toggle-user-dropdown"
aria-hidden=
"true"
tabindex=
"0"
></span>
<span
class=
"fa fa-caret-down toggle-user-dropdown"
aria-hidden=
"true"
tabindex=
"0"
></span>
...
...
lms/templates/main.html
View file @
58f93cc7
...
@@ -159,7 +159,7 @@ from pipeline_mako import render_require_js_path_overrides
...
@@ -159,7 +159,7 @@ from pipeline_mako import render_require_js_path_overrides
<div
class=
"marketing-hero"
><
%
block
name=
"marketing_hero"
></
%
block></div>
<div
class=
"marketing-hero"
><
%
block
name=
"marketing_hero"
></
%
block></div>
<div
class=
"content-wrapper
${"
container-fluid
"
if
uses_bootstrap
else
""
}
main-container
"
id=
"content"
>
<div
class=
"content-wrapper main-container"
id=
"content"
>
${self.body()}
${self.body()}
<
%
block
name=
"bodyextra"
/>
<
%
block
name=
"bodyextra"
/>
</div>
</div>
...
...
lms/templates/preview_menu.html
View file @
58f93cc7
...
@@ -27,7 +27,7 @@ show_preview_menu = course and staff_access and supports_preview_menu
...
@@ -27,7 +27,7 @@ show_preview_menu = course and staff_access and supports_preview_menu
student_selected =
selected(not
staff_selected
and
not
specific_student_selected
and
not
masquerade_group_id
)
student_selected =
selected(not
staff_selected
and
not
specific_student_selected
and
not
masquerade_group_id
)
%
>
%
>
<nav
class=
"wrapper-preview-menu"
aria-label=
"${_('Course View')}"
>
<nav
class=
"wrapper-preview-menu"
aria-label=
"${_('Course View')}"
>
<div
class=
"preview-menu
container
"
>
<div
class=
"preview-menu"
>
<ol
class=
"preview-actions"
>
<ol
class=
"preview-actions"
>
<li
class=
"action-preview"
>
<li
class=
"action-preview"
>
<form
action=
"#"
class=
"action-preview-form"
method=
"post"
>
<form
action=
"#"
class=
"action-preview-form"
method=
"post"
>
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment