Commit 56bf7d86 by Andy Armstrong

Merge pull request #3437 from edx/andya/rc-fix-tinymce

Make TinyMCE more tolerant about HTML elements
parents 0e72c8c0 4cfa2805
...@@ -47,6 +47,26 @@ Feature: CMS.HTML Editor ...@@ -47,6 +47,26 @@ Feature: CMS.HTML Editor
--></style> --></style>
""" """
Scenario: TinyMCE and CodeMirror preserve span tags
Given I have created a Blank HTML Page
When I edit the page
And type "<span>Test</span>" in the code editor and press OK
And I save the page
Then the page text contains:
"""
<span>Test</span>
"""
Scenario: TinyMCE and CodeMirror preserve math tags
Given I have created a Blank HTML Page
When I edit the page
And type "<math><msup><mi>x</mi><mn>2</mn></msup></math>" in the code editor and press OK
And I save the page
Then the page text contains:
"""
<math><msup><mi>x</mi><mn>2</mn></msup></math>
"""
Scenario: TinyMCE toolbar buttons are as expected Scenario: TinyMCE toolbar buttons are as expected
Given I have created a Blank HTML Page Given I have created a Blank HTML Page
When I edit the page When I edit the page
...@@ -57,7 +77,7 @@ Feature: CMS.HTML Editor ...@@ -57,7 +77,7 @@ Feature: CMS.HTML Editor
When I edit the page When I edit the page
And type "<img src="/static/image.jpg">" in the code editor and press OK And type "<img src="/static/image.jpg">" in the code editor and press OK
Then the src link is rewritten to "c4x/MITx/999/asset/image.jpg" Then the src link is rewritten to "c4x/MITx/999/asset/image.jpg"
And the code editor displays "<p><img src="/static/image.jpg" alt="" /></p>" And the code editor displays "<p><img src="/static/image.jpg" /></p>"
Scenario: Code format toolbar button wraps text with code tags Scenario: Code format toolbar button wraps text with code tags
Given I have created a Blank HTML Page Given I have created a Blank HTML Page
......
...@@ -48,8 +48,15 @@ class @HTMLEditingDescriptor ...@@ -48,8 +48,15 @@ class @HTMLEditingDescriptor
height: '400px', height: '400px',
menubar: false, menubar: false,
statusbar: false, statusbar: false,
# Necessary to avoid stripping of style tags. # Necessary to avoid stripping of style tags.
valid_children : "+body[style]", valid_children : "+body[style]",
# Allow any elements to be used, e.g. link, script, math
valid_elements: "*[*]",
extended_valid_elements: "*[*]",
invalid_elements: "",
setup: @setupTinyMCE, setup: @setupTinyMCE,
# Cannot get access to tinyMCE Editor instance (for focusing) until after it is rendered. # Cannot get access to tinyMCE Editor instance (for focusing) until after it is rendered.
# The tinyMCE callback passes in the editor as a parameter. # The tinyMCE callback passes in the editor as a parameter.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment