Prevent threads from being added to a discussion twice.

Probably slow, but it works for now.

Prevent threads from being added to a discussion twice.
Probably slow, but it works for now.
53bdebf6 · Ibrahim Awwal · ab5f7b40 · 53bdebf6
Commit 53bdebf6 authored Sep 14, 2012 by Ibrahim Awwal
Hide whitespace changes
Inline Side-by-side

Showing with 6 additions and 5 deletions

lms/static/coffee/src/discussion/discussion.coffee
+6 -5

No files found.
--- a/lms/static/coffee/src/discussion/discussion.coffee
+++ b/lms/static/coffee/src/discussion/discussion.coffee
@@ -18,11 +18,12 @@ if Backbone?
      @current_page < @pages
    addThread: (thread, options) ->
-      # TODO: Check for existing thread with same ID?
+      # TODO: Check for existing thread with same ID in a faster way
-      options ||= {}
+      if not @find(thread.id)
-      model = new Thread thread
+        options ||= {}
-      @add model
+        model = new Thread thread
-      model
+        @add model
+        model
    retrieveAnotherPage: (search_text="", commentable_ids="", sort_key="")->
      # TODO: I really feel that this belongs in DiscussionThreadListView