Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
52d8cb00
Commit
52d8cb00
authored
Feb 12, 2016
by
Sanford Student
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
MA-1882 adding tests and reworking regex to exclude blocks routes
parent
b92c12cb
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
20 additions
and
2 deletions
+20
-2
common/djangoapps/util/request.py
+2
-2
common/djangoapps/util/tests/test_request.py
+18
-0
No files found.
common/djangoapps/util/request.py
View file @
52d8cb00
...
...
@@ -7,8 +7,8 @@ from microsite_configuration import microsite
from
opaque_keys
import
InvalidKeyError
from
opaque_keys.edx.locations
import
SlashSeparatedCourseKey
COURSE_REGEX
=
re
.
compile
(
r'^
.*?/(api/courses/v1/)?courses/
{}'
.
format
(
settings
.
COURSE_ID_PATTERN
))
# accommodates course api urls, excluding /blocks routes.
COURSE_REGEX
=
re
.
compile
(
r'^
(.*?/courses/)+(?!v[0-9]+/blocks)
{}'
.
format
(
settings
.
COURSE_ID_PATTERN
))
def
safe_get_host
(
request
):
...
...
common/djangoapps/util/tests/test_request.py
View file @
52d8cb00
...
...
@@ -50,8 +50,26 @@ class ResponseTestCase(unittest.TestCase):
self
.
assertIsNone
(
course_id_from_url
(
'/login'
))
self
.
assertIsNone
(
course_id_from_url
(
'/course/edX/maths/2020'
))
self
.
assertIsNone
(
course_id_from_url
(
'/courses/edX/maths/'
))
self
.
assertIsNone
(
course_id_from_url
(
'/api/courses/v1/blocks/edX/maths/2020'
))
self
.
assertIsNone
(
course_id_from_url
(
'/api/courses/v1/blocks/course-v1:edX+maths+2020'
))
course_id
=
course_id_from_url
(
'/courses/edX/maths/2020'
)
self
.
assertEqual
(
course_id
.
org
,
'edX'
)
self
.
assertEqual
(
course_id
.
course
,
'maths'
)
self
.
assertEqual
(
course_id
.
run
,
'2020'
)
course_id
=
course_id_from_url
(
'/courses/course-v1:edX+maths+2020'
)
self
.
assertEqual
(
course_id
.
org
,
'edX'
)
self
.
assertEqual
(
course_id
.
course
,
'maths'
)
self
.
assertEqual
(
course_id
.
run
,
'2020'
)
course_id
=
course_id_from_url
(
'/api/courses/v1/courses/course-v1:edX+maths+2020'
)
self
.
assertEqual
(
course_id
.
org
,
'edX'
)
self
.
assertEqual
(
course_id
.
course
,
'maths'
)
self
.
assertEqual
(
course_id
.
run
,
'2020'
)
course_id
=
course_id_from_url
(
'/api/courses/v1/courses/edX/maths/2020'
)
self
.
assertEqual
(
course_id
.
org
,
'edX'
)
self
.
assertEqual
(
course_id
.
course
,
'maths'
)
self
.
assertEqual
(
course_id
.
run
,
'2020'
)
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment