Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
5137b9f8
Commit
5137b9f8
authored
Apr 22, 2016
by
Chris Rodriguez
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Adding legacy event_type for language menu events
parent
f7ec039b
Hide whitespace changes
Inline
Side-by-side
Showing
4 changed files
with
9 additions
and
7 deletions
+9
-7
common/djangoapps/track/transformers.py
+2
-0
common/lib/xmodule/xmodule/js/spec/video/video_events_plugin_spec.js
+4
-4
common/lib/xmodule/xmodule/js/src/video/09_events_plugin.js
+2
-2
common/lib/xmodule/xmodule/js/src/video/09_video_caption.js
+1
-1
No files found.
common/djangoapps/track/transformers.py
View file @
5137b9f8
...
...
@@ -374,6 +374,8 @@ class VideoEventTransformer(EventTransformer):
u'edx.video.seeked'
:
u'seek_video'
,
u'edx.video.transcript.shown'
:
u'show_transcript'
,
u'edx.video.transcript.hidden'
:
u'hide_transcript'
,
u'edx.video.language_menu.shown'
:
u'video_show_cc_menu'
,
u'edx.video.language_menu.hidden'
:
u'video_hide_cc_menu'
,
}
is_legacy_event
=
True
...
...
common/lib/xmodule/xmodule/js/spec/video/video_events_plugin_spec.js
View file @
5137b9f8
...
...
@@ -117,17 +117,17 @@
});
});
it
(
'can emit "
video_show_cc_menu
" event'
,
function
()
{
it
(
'can emit "
edx.video.language_menu.shown
" event'
,
function
()
{
state
.
el
.
trigger
(
'language_menu:show'
);
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'
video_show_cc_menu
'
,
{
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'
edx.video.language_menu.shown
'
,
{
id
:
'id'
,
code
:
'html5'
});
});
it
(
'can emit "
video_hide_cc_menu
" event'
,
function
()
{
it
(
'can emit "
edx.video.language_menu.hidden
" event'
,
function
()
{
state
.
el
.
trigger
(
'language_menu:hide'
);
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'
video_hide_cc_menu
'
,
{
expect
(
Logger
.
log
).
toHaveBeenCalledWith
(
'
edx.video.language_menu.hidden
'
,
{
id
:
'id'
,
code
:
'html5'
,
language
:
'en'
...
...
common/lib/xmodule/xmodule/js/src/video/09_events_plugin.js
View file @
5137b9f8
...
...
@@ -101,11 +101,11 @@ define('video/09_events_plugin.js', [], function() {
},
onShowLanguageMenu
:
function
()
{
this
.
log
(
'
video_show_cc_menu
'
);
this
.
log
(
'
edx.video.language_menu.shown
'
);
},
onHideLanguageMenu
:
function
()
{
this
.
log
(
'
video_hide_cc_menu
'
,
{
language
:
this
.
getCurrentLanguage
()
});
this
.
log
(
'
edx.video.language_menu.hidden
'
,
{
language
:
this
.
getCurrentLanguage
()
});
},
onShowCaptions
:
function
()
{
...
...
common/lib/xmodule/xmodule/js/src/video/09_video_caption.js
View file @
5137b9f8
...
...
@@ -398,7 +398,7 @@
// present instead of on the container hover, since it wraps
// the "CC" and "Transcript" buttons as well.
if
(
$
(
event
.
currentTarget
).
find
(
'.lang'
).
length
)
{
this
.
state
.
el
.
trigger
(
'language_menu:
show
'
);
this
.
state
.
el
.
trigger
(
'language_menu:
hide
'
);
}
},
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment