Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
4f711580
Commit
4f711580
authored
May 08, 2015
by
Christine Lytwynec
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #7963 from edx/clytwynec/TE-868
skip test that are causing incorrect pep8 reports in jenkins builds
parents
7b535846
e13d1858
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
4 additions
and
0 deletions
+4
-0
pavelib/paver_tests/test_paver_quality.py
+4
-0
No files found.
pavelib/paver_tests/test_paver_quality.py
View file @
4f711580
...
@@ -71,6 +71,7 @@ class TestPaverRunQuality(unittest.TestCase):
...
@@ -71,6 +71,7 @@ class TestPaverRunQuality(unittest.TestCase):
self
.
addCleanup
(
patcher
.
stop
)
self
.
addCleanup
(
patcher
.
stop
)
self
.
addCleanup
(
self
.
_mock_paver_needs
.
stop
)
self
.
addCleanup
(
self
.
_mock_paver_needs
.
stop
)
@unittest.skip
(
"TODO: TE-868"
)
def
test_failure_on_diffquality_pep8
(
self
):
def
test_failure_on_diffquality_pep8
(
self
):
"""
"""
If pep8 finds errors, pylint should still be run
If pep8 finds errors, pylint should still be run
...
@@ -89,6 +90,7 @@ class TestPaverRunQuality(unittest.TestCase):
...
@@ -89,6 +90,7 @@ class TestPaverRunQuality(unittest.TestCase):
self
.
assertEqual
(
_mock_pep8_violations
.
call_count
,
1
)
self
.
assertEqual
(
_mock_pep8_violations
.
call_count
,
1
)
self
.
assertEqual
(
self
.
_mock_paver_sh
.
call_count
,
1
)
self
.
assertEqual
(
self
.
_mock_paver_sh
.
call_count
,
1
)
@unittest.skip
(
"TODO: TE-868"
)
def
test_failure_on_diffquality_pylint
(
self
):
def
test_failure_on_diffquality_pylint
(
self
):
"""
"""
If diff-quality fails on pylint, the paver task should also fail
If diff-quality fails on pylint, the paver task should also fail
...
@@ -107,6 +109,7 @@ class TestPaverRunQuality(unittest.TestCase):
...
@@ -107,6 +109,7 @@ class TestPaverRunQuality(unittest.TestCase):
# And assert that sh was called once (for the call to "pylint")
# And assert that sh was called once (for the call to "pylint")
self
.
assertEqual
(
self
.
_mock_paver_sh
.
call_count
,
1
)
self
.
assertEqual
(
self
.
_mock_paver_sh
.
call_count
,
1
)
@unittest.skip
(
"TODO: Fix order dependency on test_no_diff_quality_failures"
)
def
test_other_exception
(
self
):
def
test_other_exception
(
self
):
"""
"""
If diff-quality fails for an unknown reason on the first run (pep8), then
If diff-quality fails for an unknown reason on the first run (pep8), then
...
@@ -118,6 +121,7 @@ class TestPaverRunQuality(unittest.TestCase):
...
@@ -118,6 +121,7 @@ class TestPaverRunQuality(unittest.TestCase):
# Test that pylint is NOT called by counting calls
# Test that pylint is NOT called by counting calls
self
.
assertEqual
(
self
.
_mock_paver_sh
.
call_count
,
1
)
self
.
assertEqual
(
self
.
_mock_paver_sh
.
call_count
,
1
)
@unittest.skip
(
"TODO: TE-868"
)
def
test_no_diff_quality_failures
(
self
):
def
test_no_diff_quality_failures
(
self
):
# Assert nothing is raised
# Assert nothing is raised
_mock_pep8_violations
=
MagicMock
(
return_value
=
(
0
,
[]))
_mock_pep8_violations
=
MagicMock
(
return_value
=
(
0
,
[]))
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment