Merge pull request #2131 from edx/db/fix-theme-name-issues

Fix theme issues in Sass preprocessing

common/djangoapps/edxmako/management/commands/preprocess_assets.py

@@ -53,7 +53,10 @@ class Command(NoArgsCommand):
         """
         # TODO: do we need to include anything else?
         # TODO: do this with the django-settings-context-processor
-        return { "THEME_NAME" : getattr(settings, "THEME_NAME", None) }
+        return {
+            "FEATURES": settings.FEATURES,
+            "THEME_NAME" : getattr(settings, "THEME_NAME", None),
+        }
 
 
     def __preprocess(self, infile, outfile):

lms/static/sass/application-extend1.scss.mako

@@ -23,7 +23,7 @@
 ## called themes/<theme-name>/, with its base Sass file in
 ## themes/<theme-name>/static/sass/_<theme-name>.scss. That one entry
 ## point can be used to @import in as many other things as needed.
-% if env.get('THEME_NAME') is not None:
+% if env["FEATURES"].get("USE_CUSTOM_THEME", False):
   // import theme's Sass overrides
   @import '${env.get('THEME_NAME')}';
 % endif

lms/static/sass/application-extend2.scss.mako

@@ -23,7 +23,7 @@
 ## called themes/<theme-name>/, with its base Sass file in
 ## themes/<theme-name>/static/sass/_<theme-name>.scss. That one entry
 ## point can be used to @import in as many other things as needed.
-% if env.get('THEME_NAME') is not None:
+% if env["FEATURES"].get("USE_CUSTOM_THEME", False):
   // import theme's Sass overrides
   @import '${env.get('THEME_NAME')}';
 % endif

lms/static/sass/application.scss.mako

@@ -22,7 +22,7 @@
 ## called themes/<theme-name>/, with its base Sass file in
 ## themes/<theme-name>/static/sass/_<theme-name>.scss. That one entry
 ## point can be used to @import in as many other things as needed.
-% if env.get('THEME_NAME') is not None:
+% if env["FEATURES"].get("USE_CUSTOM_THEME", False):
   // import theme's Sass overrides
   @import '${env.get('THEME_NAME')}';
 % endif

lms/static/sass/course.scss.mako

@@ -13,7 +13,7 @@
 ## called themes/<theme-name>/, with its base Sass file in
 ## themes/<theme-name>/static/sass/_<theme-name>.scss. That one entry
 ## point can be used to @import in as many other things as needed.
-% if env.get('THEME_NAME') is not None:
+% if env["FEATURES"].get("USE_CUSTOM_THEME", False):
   // import theme's Sass overrides
   @import '${env.get('THEME_NAME')}';
 % endif

rakelib/assets.rake

 # Theming constants
-THEME_NAME = ENV_TOKENS['THEME_NAME']
-USE_CUSTOM_THEME = !(THEME_NAME.nil? || THEME_NAME.empty?)
+USE_CUSTOM_THEME = ENV_TOKENS['USE_CUSTOM_THEME']
 if USE_CUSTOM_THEME
+    THEME_NAME = ENV_TOKENS['THEME_NAME']
     THEME_ROOT = File.join(ENV_ROOT, "themes", THEME_NAME)
     THEME_SASS = File.join(THEME_ROOT, "static", "sass")
 end