Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
43d41d66
Commit
43d41d66
authored
Apr 15, 2015
by
Calen Pennington
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Move `delete` logic down into per-scope caches
parent
d1fae17c
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
40 additions
and
11 deletions
+40
-11
lms/djangoapps/courseware/model_data.py
+40
-11
No files found.
lms/djangoapps/courseware/model_data.py
View file @
43d41d66
...
...
@@ -203,6 +203,25 @@ class DjangoOrmFieldCache(object):
def
set
(
self
,
kvs_key
,
value
):
self
.
_cache
[
self
.
_cache_key_for_kvs_key
(
kvs_key
)]
=
value
@contract
(
kvs_key
=
DjangoKeyValueStore
.
Key
)
def
delete
(
self
,
kvs_key
):
"""
Delete the value specified by `kvs_key`.
Arguments:
kvs_key (`DjangoKeyValueStore.Key`): The field value to delete
Raises: KeyError if key isn't found in the cache
"""
cache_key
=
self
.
_cache_key_for_kvs_key
(
kvs_key
)
field_object
=
self
.
_cache
.
get
(
cache_key
)
if
field_object
is
None
:
raise
KeyError
(
kvs_key
.
field_name
)
field_object
.
delete
()
del
self
.
_cache
[
cache_key
]
def
__len__
(
self
):
return
len
(
self
.
_cache
)
...
...
@@ -298,6 +317,26 @@ class UserStateCache(DjangoOrmFieldCache):
"""
return
key
.
block_scope_id
@contract
(
kvs_key
=
DjangoKeyValueStore
.
Key
)
def
delete
(
self
,
kvs_key
):
"""
Delete the value specified by `kvs_key`.
Arguments:
kvs_key (`DjangoKeyValueStore.Key`): The field value to delete
Raises: KeyError if key isn't found in the cache
"""
field_object
=
self
.
_cache
.
get
(
self
.
_cache_key_for_kvs_key
(
kvs_key
))
if
field_object
is
None
:
raise
KeyError
(
kvs_key
.
field_name
)
state
=
json
.
loads
(
field_object
.
state
)
del
state
[
kvs_key
.
field_name
]
field_object
.
state
=
json
.
dumps
(
state
)
field_object
.
save
()
class
UserStateSummaryCache
(
DjangoOrmFieldCache
):
"""
...
...
@@ -664,17 +703,7 @@ class FieldDataCache(object):
if
key
.
scope
not
in
self
.
cache
:
raise
KeyError
(
key
.
field_name
)
field_object
=
self
.
cache
[
key
.
scope
]
.
get
(
key
)
if
field_object
is
None
:
raise
KeyError
(
key
.
field_name
)
if
key
.
scope
==
Scope
.
user_state
:
state
=
json
.
loads
(
field_object
.
state
)
del
state
[
key
.
field_name
]
field_object
.
state
=
json
.
dumps
(
state
)
field_object
.
save
()
else
:
field_object
.
delete
()
self
.
cache
[
key
.
scope
]
.
delete
(
key
)
@contract
(
key
=
DjangoKeyValueStore
.
Key
,
returns
=
bool
)
def
has
(
self
,
key
):
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment