Merge pull request #11850 from edx/ai/tnl3964-forum-vote-button

Fix styling of vote button in forums responses.

common/static/coffee/spec/discussion/view/discussion_view_spec_helper.coffee

@@ -23,6 +23,14 @@ class @DiscussionViewSpecHelper
         }
         $.extend(thread, props)
 
+    @checkVoteClasses = (view) ->
+        view.render()
+        display_button = view.$el.find(".display-vote")
+        expect(display_button.hasClass("is-hidden")).toBe(true)
+        action_button = view.$el.find(".action-vote")
+        # Check that inline css is not applied to the ".action-vote"
+        expect(action_button).not.toHaveAttr('style','display: inline; ');
+
     @expectVoteRendered = (view, model, user) ->
         button = view.$el.find(".action-vote")
         expect(button.hasClass("is-checked")).toBe(user.voted(model))

common/static/coffee/spec/discussion/view/thread_response_show_view_spec.coffee

@@ -30,6 +30,9 @@ describe "ThreadResponseShowView", ->
         it "renders the vote state correctly", ->
             DiscussionViewSpecHelper.checkRenderVote(@view, @comment)
 
+        it "check the vote classes after renders", ->
+            DiscussionViewSpecHelper.checkVoteClasses(@view)
+
         it "votes correctly via click", ->
             DiscussionViewSpecHelper.checkUpvote(@view, @comment, @user, $.Event("click"))
 

common/static/coffee/src/discussion/views/discussion_content_view.coffee

@@ -138,7 +138,6 @@ if Backbone?
       closed: (closed) ->
         @updateButtonState(".action-close", closed)
         @$(".post-label-closed").toggleClass("is-hidden", not closed)
-        @$(".action-vote").toggle(not closed)
         @$(".display-vote").toggle(closed)
     })
 

common/static/common/templates/discussion/forum-action-vote.underscore

 <li class="actions-item">
-    <span aria-hidden="true" class="display-vote" >
+    <span aria-hidden="true" class="display-vote is-hidden" >
       <span class="vote-count"></span>
     </span>
     <a href="#" class="action-button action-vote" role="checkbox" aria-checked="false">