Merge pull request #13411 from edx/mushtaq/a11y-discussions-duplicate-id

Remove duplicate-id rule for a11y discussions

common/static/common/templates/discussion/thread-response.underscore

@@ -11,8 +11,8 @@
         <% if (create_sub_comment && !readOnly) { %>
             <form class="comment-form" data-id="<%- wmdId %>">
                 <ul class="discussion-errors"></ul>
-                <label class="sr" for="add-new-comment"><%- gettext("Add a comment") %></label>
-                <div class="comment-body" id="add-new-comment" data-id="<%- wmdId %>"
+                <label class="sr" for="add-new-comment-<%- wmdId %>"><%- gettext("Add a comment") %></label>
+                <div class="comment-body" id="add-new-comment-<%- wmdId %>" data-id="<%- wmdId %>"
                 data-placeholder="<%- gettext('Add a comment') %>"></div>
                 <div class="comment-post-control">
                     <button class="btn-brand discussion-submit-comment control-button"><%- gettext("Submit") %></button>

common/test/acceptance/tests/discussion/test_discussion.py

@@ -829,7 +829,6 @@ class DiscussionResponseEditTest(BaseDiscussionTestCase):
                 'section',  # TODO: AC-491
                 'color-contrast',  # TNL-4644
                 'icon-aria-hidden',  # TNL-4645
-                'duplicate-id',  # TNL-4647
             ]
         })
         page.visit()