Skip to content

E
edx-platform
Commit 3b053980 by Andy Armstrong
Options

Address code review feedback

parent 749f9650
Showing with 172 additions and 168 deletions
lms/static/sass/discussion/views/_home.scss
...@@ -115,9 +115,9 @@ ...@@ -115,9 +115,9 @@
.row-item-full { .row-item-full {
.notification-checkbox { .notification-checkbox {
@include margin-right($baseline/2);
display: inline-block; display: inline-block;
@include padding($baseline/4, 0, $baseline/2, 0); @include padding($baseline/4, 0, $baseline/2, 0);
@include margin-right($baseline/2);
border-radius: 5px; border-radius: 5px;
border: 1px solid gray; border: 1px solid gray;
......
lms/static/sass/shared-v2/_components.scss
...@@ -56,33 +56,33 @@ ...@@ -56,33 +56,33 @@
display: inline-block; display: inline-block;
} }
.search-input { .search-box {
display: inline-block; display: inline-block;
position: relative; position: relative;
vertical-align: middle; vertical-align: middle;
} }
.search-field { .search-field {
@include padding($baseline/4, $baseline*1.5, $baseline/4, $baseline/2);
transition: all $tmg-f2 ease-in-out; transition: all $tmg-f2 ease-in-out;
border: 1px solid $gray-l4; border: 1px solid $lms-border-color;
border-radius: 3px; border-radius: 3px;
padding: $baseline/4 $baseline*1.5;
font-family: inherit; font-family: inherit;
} }
.action-search { .action-search {
@include padding($baseline/5, $baseline/2, $baseline/5, $baseline/2);
text-shadow: none; text-shadow: none;
vertical-align: middle; vertical-align: middle;
padding: $baseline/5 $baseline/2;
} }
.action-clear { .action-clear {
@include right(0); @include right(0);
@include margin(0, ($baseline/4), 0, 0); @include margin(0, ($baseline/4), 0, 0);
@include padding($baseline/4, $baseline/4, $baseline/4, $baseline/4);
position: absolute; position: absolute;
top: 0; top: 0;
color: $lms-gray; color: $lms-gray;
padding: $baseline/4;
// STATE: hover and focus // STATE: hover and focus
&:hover, &:hover,
......
lms/static/sass/shared-v2/_footer.scss
...@@ -2,198 +2,199 @@ ...@@ -2,198 +2,199 @@
// ==================== // ====================
.wrapper-footer { .wrapper-footer {
@extend %ui-print-excluded;
box-shadow: 0 -1px 5px 0 $shadow-l1;
border-top: 1px solid tint(palette(grayscale, light), 50%);
padding: 25px ($baseline/2) ($baseline*1.5) ($baseline/2);
background: $footer-bg;
clear: both;
footer#footer-openedx {
@include clearfix(); @include clearfix();
box-sizing: border-box; @extend %ui-print-excluded;
margin: 0 auto; box-shadow: 0 -1px 5px 0 $shadow-l1;
border-top: 1px solid tint(palette(grayscale, light), 50%);
padding: 25px ($baseline/2) ($baseline*1.5);
background: $footer-bg;
p, ol, ul { footer#footer-openedx {
font-family: $sans-serif; @include clearfix();
box-sizing: border-box;
margin: 0 auto;
// override needed for poorly scoped font-family styling on p a:link {} p, ol, ul {
a { font-family: $sans-serif;
font-family: $sans-serif;
}
}
a { // override needed for poorly scoped font-family styling on p a:link {}
@extend %link-text; a {
border-bottom: none; font-family: $sans-serif;
}
}
&:hover, a {
&:focus, @extend %link-text;
&:active { border-bottom: none;
border-bottom: 1px dotted $link-color;
}
}
// colophon &:hover,
.colophon { &:focus,
@include span(12); &:active {
border-bottom: 1px dotted $link-color;
}
}
@include susy-media($bp-screen-sm) { // colophon
@include span(8); .colophon {
} @include span(12);
.nav-colophon { @include susy-media($bp-screen-sm) {
@include clearfix(); @include span(8);
margin: $footer_margin; }
ol { .nav-colophon {
list-style: none; @include clearfix();
} margin: $footer_margin;
li { ol {
@include float(left); list-style: none;
margin-right: ($baseline*0.75); }
a { li {
color: tint($black, 20%); @include float(left);
@include margin-right($baseline*0.75);
&:hover, a {
&:focus, color: tint($black, 20%);
&:active {
color: $link-color;
}
}
&:last-child { &:hover,
@include margin-right(0); &:focus,
} &:active {
} color: $link-color;
} }
}
.colophon-about { &:last-child {
@include clearfix(); @include margin-right(0);
}
}
}
img { .colophon-about {
@include float(left); @include clearfix();
width: 68px;
height: 34px; img {
margin-right: 0; @include float(left);
@include margin-right(0);
width: 68px;
height: 34px;
}
p {
@include float(left);
@include span(9);
@include margin-left($baseline);
@include padding-left($baseline);
font-size: font-size(small);
background: transparent url(/static/images/bg-footer-divider.jpg) 0 0 no-repeat;
}
}
} }
p { // references
@include float(left); .references {
@include span(9); @include span(4);
margin-left: $baseline; margin: -10px 0 0 0;
padding-left: $baseline; display: inline-block;
font-size: font-size(small);
background: transparent url(/static/images/bg-footer-divider.jpg) 0 0 no-repeat;
} }
}
}
// references .wrapper-logo {
.references { margin: ($baseline*0.75) 0;
@include span(4);
margin: -10px 0 0 0;
display: inline-block;
}
.wrapper-logo { a {
margin: ($baseline*0.75) 0; display: inline-block;
a { &:hover,
display: inline-block; &:focus {
border-bottom: 0;
&:hover { }
border-bottom: 0; }
} }
}
}
.copyright { .copyright {
@include text-align(left); @include text-align(left);
margin: -2px 0 8px 0; margin: -2px 0 8px;
font-size: font-size(xx-small); font-size: font-size(xx-small);
color: palette(grayscale, dark); color: palette(grayscale, dark);
} }
.nav-legal { .nav-legal {
@include clearfix(); @include clearfix();
@include text-align(left); @include text-align(left);
li { li {
display: inline-block; display: inline-block;
font-size: font-size(xx-small); font-size: font-size(xx-small);
} }
.nav-legal-02 a { .nav-legal-02 a {
&:before { &:before {
@include margin-right(($baseline/4)); @include margin-right(($baseline/4));
content: "-"; content: "-";
}
}
} }
}
}
.nav-social { .nav-social {
@include text-align(right); @include text-align(right);
margin: 0; margin: 0;
li { li {
display: inline-block; display: inline-block;
&:last-child { &:last-child {
margin-right: 0; @include margin-right(0);
} }
a { a {
display: block; display: block;
&:hover, &:hover,
&:focus, &:focus,
&:active { &:active {
border: none; border: none;
} }
} }
img { img {
display: block; display: block;
}
}
} }
}
}
// platform Open edX logo and link // platform Open edX logo and link
.footer-about-openedx { .footer-about-openedx {
@include span(12); @include span(12);
@include text-align(right); @include text-align(right);
vertical-align: bottom; vertical-align: bottom;
@include susy-media($bp-screen-sm) {
@include span(4);
@include margin-right(0);
}
@include susy-media($bp-screen-sm) {
@include span(4);
@include margin-right(0);
}
a {
a { @include float(right);
@include float(right); display: inline-block;
display: inline-block;
&:hover { &:hover {
border-bottom: none; border-bottom: none;
}
}
} }
}
} }
}
} }
// marketing site design syncing // marketing site design syncing
.view-register, .view-register,
.view-login, .view-login,
.view-passwordreset { .view-passwordreset {
.wrapper-footer footer { .wrapper-footer footer {
width: 960px; width: 960px;
.colophon-about img { .colophon-about img {
margin-top: ($baseline*1.5); margin-top: ($baseline*1.5);
}
} }
}
} }
lms/static/sass/shared-v2/_layouts.scss
...@@ -2,11 +2,13 @@ ...@@ -2,11 +2,13 @@
.content-wrapper { .content-wrapper {
max-width: 1180px; max-width: 1180px;
padding-top: ($baseline/2); padding: {
padding-bottom: ($baseline*2); top: $baseline/2;
bottom: $baseline*2;
}
.container { .container {
border: 1px solid #c8c8c8; border: 1px solid $lms-border-color;
background-color: $lms-container-background-color; background-color: $lms-container-background-color;
padding: $baseline; padding: $baseline;
} }
...@@ -44,20 +46,20 @@ ...@@ -44,20 +46,20 @@
} }
.form-actions > * { .form-actions > * {
margin-left: ($baseline/2); @include margin-left($baseline/2);
vertical-align: middle; vertical-align: middle;
min-width: 200px; min-width: 200px;
height: 34px; height: 34px;
} }
.form-actions > button { .form-actions > button {
@include padding($baseline/5, $baseline/5, $baseline/5, $baseline/5); padding: $baseline/5;
min-width: 200px; min-width: 200px;
height: 34px; height: 34px;
} }
.form-actions > *:first-child { .form-actions > *:first-child {
margin-left: 0; @include margin-left(0);
} }
} }
} }
......
lms/templates/ux/reference/course-skeleton.html
...@@ -13,19 +13,19 @@ ...@@ -13,19 +13,19 @@
<div class="course-material"> <div class="course-material">
<ol class="tabs course-tabs"> <ol class="tabs course-tabs">
<li class="tab"> <li class="tab">
<a href="index.html" class=""> <a href="index.html">
Home Home
</a> </a>
</li> </li>
<li class="tab"> <li class="tab">
<a href="#" class=""> <a href="#">
Course Course
</a> </a>
</li> </li>
<li class="tab"> <li class="tab">
<a href="/courses/course-v1:AndyA+AA101+1/discussion/forum" class="active"> <a href="course-skeleton.html" class="active">
Skeleton Skeleton
<span class="sr-only">, current location</span> <span class="sr-only">, current location</span>
</a> </a>
...@@ -43,19 +43,20 @@ ...@@ -43,19 +43,20 @@
<div class="page-header-secondary"> <div class="page-header-secondary">
<div class="form-actions"> <div class="form-actions">
<button class="btn-neutral btn-small">Click Me!</button> <button class="btn-neutral btn-small">Click Me!</button>
## TODO: note that this search component markup is provisional
## - update to use Chris's placeholder recommendation: http://codepen.io/clrux/pen/YqMpRO
## - update the Pattern Library's markup to match
<div class="page-header-search"> <div class="page-header-search">
<form class="search-form"> <form class="search-form" role="search">
<div class="search-input"> <div class="search-box">
<label for="search-skeleton" class="search-label sr-only">Search</label> <input class="search-field" type="text" value=""
<input id="search-skeleton" class="search-field" type="text" value="" placeholder="Search"> aria-label="Search all the things" placeholder="Search all the things">
<button type="button" class="btn action action-clear" aria-label="Clear search"> <button type="button" class="btn action action-clear" aria-label="Clear search">
<span class="fa fa-times-circle" aria-hidden="true"></span> <span class="fa fa-times-circle" aria-hidden="true"></span>
<span class="sr-only">Search</span>
</button> </button>
</div> </div>
<button type="submit" class="btn-brand action action-search"> <button type="submit" class="btn-brand action action-search" aria-label="Search items">
<span class="fa fa-search" aria-hidden="true"></span> <span class="fa fa-search" aria-hidden="true"></span>
<span class="sr-only">Search</span>
</button> </button>
</form> </form>
</div> </div>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment