Merge pull request #1598 from edx/flowerhack/feature/command-retry-cert-submissions

Command for retrying failed photo verifications

lms/djangoapps/verify_student/management/commands/retry_failed_photo_verifications.py

+"""
+Django admin commands related to verify_student
+"""
+
+from verify_student.models import SoftwareSecurePhotoVerification
+from django.core.management.base import BaseCommand
+
+
+class Command(BaseCommand):
+    """
+    This method finds those PhotoVerifications with a status of
+    MUST_RETRY and attempts to verify them.
+    """
+    help = 'Retries SoftwareSecurePhotoVerifications that are in a state of \'must_retry\''
+
+    def handle(self, *args, **options):
+        attempts_to_retry = SoftwareSecurePhotoVerification.objects.filter(status='must_retry')
+        print("Attempting to retry {0} failed PhotoVerification submissions".format(len(attempts_to_retry)))
+        for index, attempt in enumerate(attempts_to_retry):
+            print("Retrying submission #{0} (ID: {1}, User: {2})".format(index, attempt.id, attempt.user))
+            attempt.submit()
+            print("Retry result: {0}".format(attempt.status))
+        print("Done resubmitting failed photo verifications")

lms/djangoapps/verify_student/management/commands/tests/test_verify_student.py

+"""
+Tests for django admin commands in the verify_student module
+
+Lots of imports from verify_student's model tests, since they cover similar ground
+"""
+from nose.tools import (
+    assert_equals, assert_true
+)
+from mock import patch
+from django.test import TestCase
+from django.conf import settings
+import requests
+
+from student.tests.factories import UserFactory
+from verify_student.models import SoftwareSecurePhotoVerification
+from django.core.management import call_command
+from verify_student.tests.test_models import MockKey, MockBucket, MockS3Connection, mock_software_secure_post, mock_software_secure_post_error, FAKE_SETTINGS
+
+
+# Lots of patching to stub in our own settings, S3 substitutes, and HTTP posting
+@patch.dict(settings.VERIFY_STUDENT, FAKE_SETTINGS)
+@patch('verify_student.models.S3Connection', new=MockS3Connection)
+@patch('verify_student.models.Key', new=MockKey)
+@patch('verify_student.models.requests.post', new=mock_software_secure_post)
+class TestVerifyStudentCommand(TestCase):
+    """
+    Tests for django admin commands in the verify_student module
+    """
+
+    def create_and_submit(self, username):
+        """
+        Helper method that lets us create new SoftwareSecurePhotoVerifications
+        """
+        user = UserFactory.create()
+        attempt = SoftwareSecurePhotoVerification(user=user)
+        user.profile.name = username
+        attempt.upload_face_image("Fake Data")
+        attempt.upload_photo_id_image("More Fake Data")
+        attempt.mark_ready()
+        attempt.submit()
+        return attempt
+
+    def test_retry_failed_photo_verifications(self):
+        """
+        Tests that the task used to find "must_retry" SoftwareSecurePhotoVerifications
+        and re-submit them executes successfully
+        """
+        # set up some fake data to use...
+        self.create_and_submit("SuccessfulSally")
+        with patch('verify_student.models.requests.post', new=mock_software_secure_post_error):
+            self.create_and_submit("RetryRoger")
+        with patch('verify_student.models.requests.post', new=mock_software_secure_post_error):
+            self.create_and_submit("RetryRick")
+        # check to make sure we had two successes and two failures; otherwise we've got problems elsewhere
+        assert_equals(len(SoftwareSecurePhotoVerification.objects.filter(status="submitted")), 1)
+        assert_equals(len(SoftwareSecurePhotoVerification.objects.filter(status='must_retry')), 2)
+        call_command('retry_failed_photo_verifications')
+        attempts_to_retry = SoftwareSecurePhotoVerification.objects.filter(status='must_retry')
+        assert_equals(bool(attempts_to_retry), False)