Skip to content

E
edx-platform
Commit 371c5a24 by alisan617 Committed by GitHub
Options

Merge pull request #13843 from edx/alisan/testing-discussion 

Refactor discussion tab UI code into parts to be reusable for inline discussions TNL-5669
parents 1c5d1f1c e80d9b57
Showing with 216 additions and 172 deletions
common/static/common/js/spec/discussion/view/discussion_thread_edit_view_spec.js
...@@ -16,7 +16,7 @@ ...@@ -16,7 +16,7 @@
'title': 'test thread title' 'title': 'test thread title'
}); });
this.thread = new Thread(this.threadData); this.thread = new Thread(this.threadData);
this.course_settings = DiscussionSpecHelper.makeCourseSettings(); this.course_settings = DiscussionSpecHelper.createTestCourseSettings();
this.createEditView = function(options) { this.createEditView = function(options) {
options = _.extend({ options = _.extend({
......
common/static/common/js/spec/discussion/view/discussion_thread_show_view_spec.js
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
var $$course_id = '$$course_id'; var $$course_id = '$$course_id';
describe('DiscussionThreadShowView', function() { describe('DiscussionThreadShowView', function() {
beforeEach(function() { beforeEach(function() {
DiscussionSpecHelper.setUpGlobals(); DiscussionSpecHelper.setUpGlobals({});
DiscussionSpecHelper.setUnderscoreFixtures(); DiscussionSpecHelper.setUnderscoreFixtures();
this.user = DiscussionUtil.getUser(); this.user = DiscussionUtil.getUser();
this.threadData = { this.threadData = {
......
common/static/common/js/spec/discussion/view/discussion_thread_view_spec.js
...@@ -129,7 +129,7 @@ ...@@ -129,7 +129,7 @@
model: thread, model: thread,
el: $('#fixture-element'), el: $('#fixture-element'),
mode: mode, mode: mode,
course_settings: DiscussionSpecHelper.makeCourseSettings() course_settings: DiscussionSpecHelper.createTestCourseSettings()
}); });
renderWithTestResponses(view, 1); renderWithTestResponses(view, 1);
if (mode === 'inline') { if (mode === 'inline') {
...@@ -185,7 +185,7 @@ ...@@ -185,7 +185,7 @@
model: this.thread, model: this.thread,
el: $('#fixture-element'), el: $('#fixture-element'),
mode: 'tab', mode: 'tab',
course_settings: DiscussionSpecHelper.makeCourseSettings() course_settings: DiscussionSpecHelper.createTestCourseSettings()
}); });
}); });
describe('responses', function() { describe('responses', function() {
...@@ -282,7 +282,7 @@ ...@@ -282,7 +282,7 @@
model: this.thread, model: this.thread,
el: $('#fixture-element'), el: $('#fixture-element'),
mode: 'inline', mode: 'inline',
course_settings: DiscussionSpecHelper.makeCourseSettings() course_settings: DiscussionSpecHelper.createTestCourseSettings()
}); });
}); });
describe('render', function() { describe('render', function() {
...@@ -397,7 +397,7 @@ ...@@ -397,7 +397,7 @@
model: this.thread, model: this.thread,
el: $('#fixture-element'), el: $('#fixture-element'),
mode: 'tab', mode: 'tab',
course_settings: DiscussionSpecHelper.makeCourseSettings() course_settings: DiscussionSpecHelper.createTestCourseSettings()
}); });
}); });
generateContent = function(idStart, idEnd) { generateContent = function(idStart, idEnd) {
...@@ -465,7 +465,7 @@ ...@@ -465,7 +465,7 @@
model: this.thread, model: this.thread,
el: $('#fixture-element'), el: $('#fixture-element'),
mode: 'tab', mode: 'tab',
course_settings: DiscussionSpecHelper.makeCourseSettings() course_settings: DiscussionSpecHelper.createTestCourseSettings()
}); });
}); });
it("doesn't show report option if can_report ability is disabled", function() { it("doesn't show report option if can_report ability is disabled", function() {
......
common/static/common/js/spec/discussion/view/response_comment_view_spec.js
...@@ -5,7 +5,7 @@ ...@@ -5,7 +5,7 @@
describe('ResponseCommentView', function() { describe('ResponseCommentView', function() {
beforeEach(function() { beforeEach(function() {
DiscussionSpecHelper.setUpGlobals(); DiscussionSpecHelper.setUpGlobals({});
this.comment = new Comment({ this.comment = new Comment({
id: '01234567', id: '01234567',
user_id: user.id, user_id: user.id,
......
common/static/common/js/spec_helpers/discussion_spec_helper.js
/* global DiscussionCourseSettings, DiscussionUtil, DiscussionUser */ /* global Content, Discussion, DiscussionCourseSettings, DiscussionUtil, DiscussionUser */
(function() { (function() {
'use strict'; 'use strict';
this.DiscussionSpecHelper = (function() { this.DiscussionSpecHelper = (function() {
function DiscussionSpecHelper() { function DiscussionSpecHelper() {
} }
DiscussionSpecHelper.setUpGlobals = function() { DiscussionSpecHelper.setUpGlobals = function(opts) {
DiscussionUtil.loadRoles(DiscussionSpecHelper.getTestRoleInfo()); var options = opts || {};
window.$$course_id = 'edX/999/test'; DiscussionUtil.loadRoles(options.roles || DiscussionSpecHelper.getTestRoleInfo());
window.user = new DiscussionUser(DiscussionSpecHelper.getTestUserInfo()); window.$$course_id = options.courseName || 'edX/999/test';
return DiscussionUtil.setUser(window.user); window.user = new DiscussionUser(options.userInfo || DiscussionSpecHelper.getTestUserInfo());
DiscussionUtil.setUser(window.user);
}; };
DiscussionSpecHelper.getTestUserInfo = function() { DiscussionSpecHelper.getTestUserInfo = function() {
...@@ -50,7 +51,7 @@ ...@@ -50,7 +51,7 @@
return jasmine.createSpyObj('event', ['preventDefault', 'target']); return jasmine.createSpyObj('event', ['preventDefault', 'target']);
}; };
DiscussionSpecHelper.makeCourseSettings = function() { DiscussionSpecHelper.createTestCourseSettings = function() {
return new DiscussionCourseSettings({ return new DiscussionCourseSettings({
category_map: { category_map: {
children: ['Test Topic', 'Other Topic'], children: ['Test Topic', 'Other Topic'],
...@@ -69,12 +70,24 @@ ...@@ -69,12 +70,24 @@
}); });
}; };
DiscussionSpecHelper.createTestDiscussion = function(options) {
var sortPreference = options.sort_preference,
threads = options.threads || [],
threadPages = options.thread_pages || 1,
contentInfo = options.content_info;
DiscussionSpecHelper.setUpGlobals(options);
if (contentInfo) {
Content.loadContentInfos(contentInfo);
}
return new Discussion(threads, {pages: threadPages, sort: sortPreference});
};
DiscussionSpecHelper.setUnderscoreFixtures = function() { DiscussionSpecHelper.setUnderscoreFixtures = function() {
var templateFixture, templateName, templateNames, templateNamesNoTrailingTemplate, i, j, len; var templateFixture, templateName, templateNames, templateNamesNoTrailingTemplate, i, j, len;
templateNames = [ templateNames = [
'thread', 'thread-show', 'thread-edit', 'thread-response', 'thread-response-show', 'thread', 'thread-show', 'thread-edit', 'thread-response', 'thread-response-show',
'thread-response-edit', 'response-comment-show', 'response-comment-edit', 'thread-list-item', 'thread-response-edit', 'response-comment-show', 'response-comment-edit', 'thread-list-item',
'discussion-home', 'search-alert', 'new-post', 'thread-type', 'new-post-menu-entry', 'new-post-alert', 'search-alert', 'new-post', 'thread-type', 'new-post-menu-entry', 'new-post-alert',
'new-post-menu-category', 'topic', 'post-user-display', 'inline-discussion', 'pagination', 'new-post-menu-category', 'topic', 'post-user-display', 'inline-discussion', 'pagination',
'profile-thread', 'customwmd-prompt', 'nav-loading' 'profile-thread', 'customwmd-prompt', 'nav-loading'
]; ];
......
common/test/acceptance/tests/discussion/test_discussion.py
...@@ -511,6 +511,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase): ...@@ -511,6 +511,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase):
page.a11y_audit.config.set_rules({ page.a11y_audit.config.set_rules({
'ignore': [ 'ignore': [
'section', # TODO: AC-491 'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally 'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally
] ]
}) })
...@@ -520,6 +521,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase): ...@@ -520,6 +521,7 @@ class DiscussionOpenClosedThreadTest(BaseDiscussionTestCase):
page.a11y_audit.config.set_rules({ page.a11y_audit.config.set_rules({
'ignore': [ 'ignore': [
'section', # TODO: AC-491 'section', # TODO: AC-491
'aria-required-children', # TODO: AC-534
'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally 'color-contrast', # Commented out for now because they reproducibly fail on Jenkins but not locally
] ]
}) })
......
lms/djangoapps/discussion/static/discussion/js/discussion_board_factory.js
...@@ -5,38 +5,50 @@ ...@@ -5,38 +5,50 @@
[ [
'jquery', 'jquery',
'backbone', 'backbone',
'common/js/discussion/content',
'common/js/discussion/discussion',
'common/js/discussion/utils',
'common/js/discussion/models/discussion_course_settings',
'common/js/discussion/models/discussion_user',
'common/js/discussion/views/new_post_view',
'discussion/js/discussion_router', 'discussion/js/discussion_router',
'discussion/js/views/discussion_fake_breadcrumbs', 'discussion/js/views/discussion_board_view'
'discussion/js/views/discussion_search_view',
'common/js/discussion/views/new_post_view'
], ],
function($, Backbone, DiscussionRouter, DiscussionFakeBreadcrumbs, DiscussionSearchView, NewPostView) { function($, Backbone, Content, Discussion, DiscussionUtil, DiscussionCourseSettings, DiscussionUser,
NewPostView, DiscussionRouter, DiscussionBoardView) {
return function(options) { return function(options) {
var userInfo = options.user_info, var userInfo = options.user_info,
sortPreference = options.sort_preference, sortPreference = options.sort_preference,
threads = options.threads, threads = options.threads,
threadPages = options.thread_pages, threadPages = options.thread_pages,
contentInfo = options.content_info, contentInfo = options.content_info,
user = new window.DiscussionUser(userInfo), user = new DiscussionUser(userInfo),
discussion, discussion,
courseSettings, courseSettings,
newPostView, newPostView,
discussionBoardView,
router, router,
breadcrumbs,
BreadcrumbsModel,
searchBox,
routerEvents; routerEvents;
// TODO: Perhaps eliminate usage of global variables when possible // TODO: eliminate usage of global variables when possible
window.DiscussionUtil.loadRoles(options.roles); DiscussionUtil.loadRoles(options.roles);
window.$$course_id = options.courseId; window.$$course_id = options.courseId;
window.courseName = options.course_name; window.courseName = options.course_name;
window.DiscussionUtil.setUser(user); DiscussionUtil.setUser(user);
window.user = user; window.user = user;
window.Content.loadContentInfos(contentInfo); Content.loadContentInfos(contentInfo);
discussion = new window.Discussion(threads, {pages: threadPages, sort: sortPreference}); // Create a discussion model
courseSettings = new window.DiscussionCourseSettings(options.course_settings); discussion = new Discussion(threads, {pages: threadPages, sort: sortPreference});
courseSettings = new DiscussionCourseSettings(options.course_settings);
// Create the discussion board view
discussionBoardView = new DiscussionBoardView({
el: $('.discussion-board'),
discussion: discussion,
courseSettings: courseSettings
});
discussionBoardView.render();
// Create the new post view // Create the new post view
newPostView = new NewPostView({ newPostView = new NewPostView({
...@@ -47,59 +59,27 @@ ...@@ -47,59 +59,27 @@
}); });
newPostView.render(); newPostView.render();
// Set up the router to manage the page's history // Set up a router to manage the page's history
router = new DiscussionRouter({ router = new DiscussionRouter({
courseId: options.courseId, courseId: options.courseId,
discussion: discussion, discussion: discussion,
courseSettings: courseSettings, courseSettings: courseSettings,
discussionBoardView: discussionBoardView,
newPostView: newPostView newPostView: newPostView
}); });
router.start(); router.start();
// Initialize and render search box
searchBox = new DiscussionSearchView({
el: $('.forum-search'),
threadListView: router.nav
}).render();
// Initialize and render breadcrumbs
BreadcrumbsModel = Backbone.Model.extend({
defaults: {
contents: []
}
});
breadcrumbs = new DiscussionFakeBreadcrumbs({
el: $('.has-breadcrumbs'),
model: new BreadcrumbsModel(),
events: {
'click .all-topics': function(event) {
event.preventDefault();
searchBox.clearSearch();
this.model.set('contents', []);
router.navigate('', {trigger: true});
router.nav.toggleBrowseMenu(event);
}
}
}).render();
routerEvents = { routerEvents = {
// Add new breadcrumbs and clear search box when the user selects topics // Add new breadcrumbs and clear search box when the user selects topics
'topic:selected': function(topic) { 'topic:selected': function(topic) {
breadcrumbs.model.set('contents', topic); router.discussionBoardView.breadcrumbs.model.set('contents', topic);
}, },
// Clear search box when a thread is selected // Clear search box when a thread is selected
'thread:selected': function() { 'thread:selected': function() {
searchBox.clearSearch(); router.discussionBoardView.searchView.clearSearch();
},
// Add 'Search Results' to breadcrumbs when user searches
'search:initiated': function() {
breadcrumbs.model.set('contents', ['Search Results']);
} }
}; };
Object.keys(routerEvents).forEach(function(key) { Object.keys(routerEvents).forEach(function(key) {
router.nav.on(key, routerEvents[key]); router.discussionBoardView.on(key, routerEvents[key]);
}); });
}; };
}); });
......
lms/djangoapps/discussion/static/discussion/js/discussion_profile_page_factory.js
(function(define) { (function(define) {
'use strict'; 'use strict';
define(['jquery', 'discussion/js/views/discussion_user_profile_view'], define(
function($, DiscussionUserProfileView) { [
'jquery',
'common/js/discussion/utils',
'common/js/discussion/models/discussion_user',
'discussion/js/views/discussion_user_profile_view'
],
function($, DiscussionUtil, DiscussionUser, DiscussionUserProfileView) {
return function(options) { return function(options) {
var $element = options.$el, var $element = options.$el,
threads = options.threads, threads = options.threads,
...@@ -10,13 +16,16 @@ ...@@ -10,13 +16,16 @@
page = options.page, page = options.page,
numPages = options.numPages; numPages = options.numPages;
// Roles are not included in user profile page, but they are not used for anything // Roles are not included in user profile page, but they are not used for anything
window.DiscussionUtil.loadRoles({ DiscussionUtil.loadRoles({
Moderator: [], Moderator: [],
Administrator: [], Administrator: [],
'Community TA': [] 'Community TA': []
}); });
// TODO: remove global variable usage
window.$$course_id = options.courseId; window.$$course_id = options.courseId;
window.user = new window.DiscussionUser(userInfo); window.user = new DiscussionUser(userInfo);
new DiscussionUserProfileView({ // eslint-disable-line no-new new DiscussionUserProfileView({ // eslint-disable-line no-new
el: $element, el: $element,
collection: threads, collection: threads,
......
lms/djangoapps/discussion/static/discussion/js/discussion_router.js
...@@ -6,10 +6,10 @@ ...@@ -6,10 +6,10 @@
'underscore', 'underscore',
'backbone', 'backbone',
'common/js/discussion/utils', 'common/js/discussion/utils',
'common/js/discussion/views/discussion_thread_list_view', 'common/js/discussion/models/discussion_course_settings',
'common/js/discussion/views/discussion_thread_view' 'common/js/discussion/views/discussion_thread_view'
], ],
function(_, Backbone, DiscussionUtil, DiscussionThreadListView, DiscussionThreadView) { function(_, Backbone, DiscussionUtil, DiscussionCourseSettings, DiscussionThreadView) {
var DiscussionRouter = Backbone.Router.extend({ var DiscussionRouter = Backbone.Router.extend({
routes: { routes: {
'': 'allThreads', '': 'allThreads',
...@@ -21,14 +21,9 @@ ...@@ -21,14 +21,9 @@
_.bindAll(this, 'allThreads', 'showThread'); _.bindAll(this, 'allThreads', 'showThread');
this.courseId = options.courseId; this.courseId = options.courseId;
this.discussion = options.discussion; this.discussion = options.discussion;
this.course_settings = options.courseSettings; this.course_settings = new DiscussionCourseSettings(options.course_settings);
this.discussionBoardView = options.discussionBoardView;
this.newPostView = options.newPostView; this.newPostView = options.newPostView;
this.nav = new DiscussionThreadListView({
collection: this.discussion,
el: $('.forum-nav'),
courseSettings: this.course_settings
});
this.nav.render();
}, },
start: function() { start: function() {
...@@ -41,10 +36,18 @@ ...@@ -41,10 +36,18 @@
}); });
// Automatically navigate when the user selects threads // Automatically navigate when the user selects threads
this.nav.on('thread:selected', _.bind(this.navigateToThread, this)); this.discussionBoardView.discussionThreadListView.on(
this.nav.on('thread:removed', _.bind(this.navigateToAllThreads, this)); 'thread:selected', _.bind(this.navigateToThread, this)
this.nav.on('threads:rendered', _.bind(this.setActiveThread, this)); );
this.nav.on('thread:created', _.bind(this.navigateToThread, this)); this.discussionBoardView.discussionThreadListView.on(
'thread:removed', _.bind(this.navigateToAllThreads, this)
);
this.discussionBoardView.discussionThreadListView.on(
'threads:rendered', _.bind(this.setActiveThread, this)
);
this.discussionBoardView.discussionThreadListView.on(
'thread:created', _.bind(this.navigateToThread, this)
);
Backbone.history.start({ Backbone.history.start({
pushState: true, pushState: true,
...@@ -57,15 +60,15 @@ ...@@ -57,15 +60,15 @@
}, },
allThreads: function() { allThreads: function() {
this.nav.updateSidebar(); this.discussionBoardView.updateSidebar();
return this.nav.goHome(); return this.discussionBoardView.goHome();
}, },
setActiveThread: function() { setActiveThread: function() {
if (this.thread) { if (this.thread) {
return this.nav.setActiveThread(this.thread.get('id')); return this.discussionBoardView.discussionThreadListView.setActiveThread(this.thread.get('id'));
} else { } else {
return this.nav.goHome; return this.discussionBoardView.goHome;
} }
}, },
...@@ -86,8 +89,8 @@ ...@@ -86,8 +89,8 @@
if (!($('.forum-content').is(':visible'))) { if (!($('.forum-content').is(':visible'))) {
$('.forum-content').fadeIn(); $('.forum-content').fadeIn();
} }
if (this.newPostView.$el.is(':visible')) { if ($('.new-post-article').is(':visible')) {
this.newPostView.$el.fadeOut(); $('.new-post-article').fadeOut();
} }
this.main = new DiscussionThreadView({ this.main = new DiscussionThreadView({
el: $('.forum-content'), el: $('.forum-content'),
...@@ -97,14 +100,13 @@ ...@@ -97,14 +100,13 @@
}); });
this.main.render(); this.main.render();
this.main.on('thread:responses:rendered', function() { this.main.on('thread:responses:rendered', function() {
return self.nav.updateSidebar(); return self.discussionBoardView.updateSidebar();
}); });
return this.thread.on('thread:thread_type_updated', this.showMain); return this.thread.on('thread:thread_type_updated', this.showMain);
}, },
navigateToThread: function(threadId) { navigateToThread: function(threadId) {
var thread; var thread = this.discussion.get(threadId);
thread = this.discussion.get(threadId);
return this.navigate('' + (thread.get('commentable_id')) + '/threads/' + threadId, { return this.navigate('' + (thread.get('commentable_id')) + '/threads/' + threadId, {
trigger: true trigger: true
}); });
...@@ -135,6 +137,7 @@ ...@@ -135,6 +137,7 @@
} }
}); });
} }
}); });
return DiscussionRouter; return DiscussionRouter;
......
lms/djangoapps/discussion/static/discussion/js/spec/discussion_board_factory_spec.js
...@@ -4,16 +4,34 @@ define( ...@@ -4,16 +4,34 @@ define(
'backbone', 'backbone',
'common/js/spec_helpers/page_helpers', 'common/js/spec_helpers/page_helpers',
'common/js/spec_helpers/discussion_spec_helper', 'common/js/spec_helpers/discussion_spec_helper',
'discussion/js/discussion_board_factory' 'discussion/js/discussion_board_factory',
'discussion/js/views/discussion_board_view'
], ],
function($, Backbone, PageHelpers, DiscussionSpecHelper, DiscussionBoardFactory) { function($, Backbone, PageHelpers, DiscussionSpecHelper, DiscussionBoardFactory, DiscussionBoardView) {
'use strict'; 'use strict';
// TODO: re-enable when this doesn't interact badly with other history tests // TODO: re-enable when this doesn't interact badly with other history tests
xdescribe('Discussion Board Factory', function() { describe('DiscussionBoardFactory', function() {
var createDiscussionBoardView = function() {
var discussionBoardView,
discussion = DiscussionSpecHelper.createTestDiscussion({}),
courseSettings = DiscussionSpecHelper.createTestCourseSettings();
setFixtures('<div class="discussion-board"><div class="forum-search"></div></div>');
DiscussionSpecHelper.setUnderscoreFixtures();
discussionBoardView = new DiscussionBoardView({
el: $('.discussion-board'),
discussion: discussion,
courseSettings: courseSettings
});
return discussionBoardView;
};
var initializeDiscussionBoardFactory = function() { var initializeDiscussionBoardFactory = function() {
DiscussionBoardFactory({ DiscussionBoardFactory({
el: $('.discussion-board'), el: $('#discussion-container'),
courseId: 'test_course_id', courseId: 'test_course_id',
course_name: 'Test Course', course_name: 'Test Course',
user_info: DiscussionSpecHelper.getTestUserInfo(), user_info: DiscussionSpecHelper.getTestUserInfo(),
...@@ -33,14 +51,11 @@ define( ...@@ -33,14 +51,11 @@ define(
}; };
beforeEach(function() { beforeEach(function() {
PageHelpers.preventBackboneChangingUrl();
// Install the fixtures // Install the fixtures
setFixtures( setFixtures(
'<div class="discussion-board">' + '<div id="discussion-container" class="discussion-board"></div></div>'
' <div class="forum-nav"></div>' +
'</div>'
); );
PageHelpers.preventBackboneChangingUrl();
DiscussionSpecHelper.setUnderscoreFixtures(); DiscussionSpecHelper.setUnderscoreFixtures();
}); });
...@@ -48,9 +63,11 @@ define( ...@@ -48,9 +63,11 @@ define(
Backbone.history.stop(); Backbone.history.stop();
}); });
it('can render itself', function() { xit('can render itself', function() { // this failed Search: navigates to search, and TeamsTab
var discussionView = createDiscussionBoardView();
discussionView.render();
initializeDiscussionBoardFactory(); initializeDiscussionBoardFactory();
expect($('.discussion-board').text()).toContain('All Discussions'); expect(discussionView.$el.text()).toContain('Search all posts');
}); });
}); });
} }
......
lms/djangoapps/discussion/static/discussion/js/spec/discussion_board_view_spec.js 0 → 100644
/* globals Discussion, DiscussionCourseSettings */
(function(define) {
'use strict';
define(
[
'underscore',
'jquery',
'edx-ui-toolkit/js/utils/constants',
'common/js/discussion/discussion',
'common/js/spec_helpers/discussion_spec_helper',
'discussion/js/views/discussion_board_view'
],
function(_, $, constants, Discussion, DiscussionSpecHelper, DiscussionBoardView) {
describe('DiscussionBoardView', function() {
var createDiscussionBoardView;
createDiscussionBoardView = function() {
var discussionBoardView,
discussion = DiscussionSpecHelper.createTestDiscussion({}),
courseSettings = DiscussionSpecHelper.createTestCourseSettings();
setFixtures('<div class="discussion-board"><div class="forum-search"></div></div>');
DiscussionSpecHelper.setUnderscoreFixtures();
discussionBoardView = new DiscussionBoardView({
el: $('.discussion-board'),
discussion: discussion,
courseSettings: courseSettings
});
return discussionBoardView;
};
describe('Search events', function() {
it('perform search when enter pressed inside search textfield', function() {
var discussionBoardView = createDiscussionBoardView(),
threadListView;
discussionBoardView.render();
threadListView = discussionBoardView.discussionThreadListView;
spyOn(threadListView, 'performSearch');
discussionBoardView.$('.search-input').trigger($.Event('keydown', {
which: constants.keyCodes.enter
}));
expect(threadListView.performSearch).toHaveBeenCalled();
});
it('perform search when search icon is clicked', function() {
var discussionBoardView = createDiscussionBoardView(),
threadListView;
discussionBoardView.render();
threadListView = discussionBoardView.discussionThreadListView;
spyOn(threadListView, 'performSearch');
discussionBoardView.$el.find('.search-btn').click();
expect(threadListView.performSearch).toHaveBeenCalled();
});
});
});
});
}).call(this, define || RequireJS.define);
lms/djangoapps/discussion/static/discussion/js/spec/views/discussion_search_view_spec.js deleted 100644 → 0
define([
'jquery',
'edx-ui-toolkit/js/utils/constants',
'discussion/js/views/discussion_search_view'
],
function($, constants, DiscussionSearchView) {
'use strict';
describe('DiscussionSearchView', function() {
var view;
beforeEach(function() {
setFixtures('<div class="search-container"></div>');
view = new DiscussionSearchView({
el: $('.search-container'),
threadListView: {
performSearch: jasmine.createSpy()
}
}).render();
});
describe('Search events', function() {
it('perform search when enter pressed inside search textfield', function() {
view.$el.find('.search-input').trigger($.Event('keydown', {
which: constants.keyCodes.enter
}));
expect(view.threadListView.performSearch).toHaveBeenCalled();
});
it('perform search when search icon is clicked', function() {
view.$el.find('.search-btn').click();
expect(view.threadListView.performSearch).toHaveBeenCalled();
});
});
});
}
);
lms/djangoapps/discussion/static/discussion/js/views/discussion_search_view.js
...@@ -15,33 +15,16 @@ ...@@ -15,33 +15,16 @@
* in order to clean up that file and make it possible to break its logic into files like this one. * in order to clean up that file and make it possible to break its logic into files like this one.
*/ */
var searchView = Backbone.View.extend({ var searchView = Backbone.View.extend({
events: {
'keydown .search-input': 'performSearch',
'click .search-btn': 'performSearch',
'topic:selected': 'clearSearch'
},
initialize: function(options) { initialize: function(options) {
_.extend(this, _.pick(options, 'threadListView')); _.extend(this, _.pick(options, ['discussionBoardView']));
this.template = HtmlUtils.template(searchTemplate); this.template = HtmlUtils.template(searchTemplate);
this.threadListView = options.threadListView;
this.listenTo(this.model, 'change', this.render); this.listenTo(this.model, 'change', this.render);
this.render(); this.render();
}, },
render: function() { render: function() {
HtmlUtils.setHtml(this.$el, this.template()); HtmlUtils.setHtml(this.$el, this.template());
return this; return this;
},
performSearch: function(event) {
if (event.which === constants.keyCodes.enter || event.type === 'click') {
event.preventDefault();
this.threadListView.performSearch($('.search-input', this.$el));
}
},
clearSearch: function() {
this.$('.search-input').val('');
this.threadListView.clearSearchAlerts();
} }
}); });
......
lms/djangoapps/discussion/templates/discussion/discussion_board.html
...@@ -77,6 +77,8 @@ DiscussionBoardFactory({ ...@@ -77,6 +77,8 @@ DiscussionBoardFactory({
<div class="page-content"> <div class="page-content">
<div class="discussion-body layout layout-1t2t"> <div class="discussion-body layout layout-1t2t">
<aside class="forum-nav layout-col layout-col-a" role="complementary" aria-label="${_("Discussion thread list")}"> <aside class="forum-nav layout-col layout-col-a" role="complementary" aria-label="${_("Discussion thread list")}">
<%include file="_filter_dropdown.html" />
<div class="discussion-thread-list-container"></div>
</aside> </aside>
<main id="main" aria-label="Content" tabindex="-1" class="discussion-column layout-col layout-col-b"> <main id="main" aria-label="Content" tabindex="-1" class="discussion-column layout-col layout-col-b">
......
lms/static/lms/js/spec/main.js
...@@ -288,11 +288,11 @@ ...@@ -288,11 +288,11 @@
deps: ['jquery', 'underscore', 'slick.core', 'slick.grid'], deps: ['jquery', 'underscore', 'slick.core', 'slick.grid'],
init: function() { init: function() {
// Set global variables that the util code is expecting to be defined // Set global variables that the util code is expecting to be defined
require([ require([ // eslint-disable-line global-require
'edx-ui-toolkit/js/utils/html-utils', 'edx-ui-toolkit/js/utils/html-utils',
'edx-ui-toolkit/js/utils/string-utils' 'edx-ui-toolkit/js/utils/string-utils'
], function(HtmlUtils, StringUtils) { ], function(HtmlUtils, StringUtils) {
window.edx = edx || {}; window.edx = window.edx || {};
window.edx.HtmlUtils = HtmlUtils; window.edx.HtmlUtils = HtmlUtils;
window.edx.StringUtils = StringUtils; window.edx.StringUtils = StringUtils;
}); });
...@@ -383,7 +383,7 @@ ...@@ -383,7 +383,7 @@
deps: ['jquery', 'underscore', 'underscore.string', 'backbone', 'gettext'], deps: ['jquery', 'underscore', 'underscore.string', 'backbone', 'gettext'],
init: function() { init: function() {
// Set global variables that the payment code is expecting to be defined // Set global variables that the payment code is expecting to be defined
require([ require([ // eslint-disable-line global-require
'underscore', 'underscore',
'underscore.string', 'underscore.string',
'edx-ui-toolkit/js/utils/html-utils', 'edx-ui-toolkit/js/utils/html-utils',
...@@ -391,7 +391,7 @@ ...@@ -391,7 +391,7 @@
], function(_, str, HtmlUtils, StringUtils) { ], function(_, str, HtmlUtils, StringUtils) {
window._ = _; window._ = _;
window._.str = str; window._.str = str;
window.edx = edx || {}; window.edx = window.edx || {};
window.edx.HtmlUtils = HtmlUtils; window.edx.HtmlUtils = HtmlUtils;
window.edx.StringUtils = StringUtils; window.edx.StringUtils = StringUtils;
}); });
...@@ -527,10 +527,21 @@ ...@@ -527,10 +527,21 @@
exports: 'DiscussionUtil', exports: 'DiscussionUtil',
init: function() { init: function() {
// Set global variables that the discussion code is expecting to be defined // Set global variables that the discussion code is expecting to be defined
require(['backbone', 'URI'], function(Backbone, URI) { require( // eslint-disable-line global-require
window.Backbone = Backbone; [
window.URI = URI; 'backbone',
}); 'URI',
'edx-ui-toolkit/js/utils/html-utils',
'edx-ui-toolkit/js/utils/string-utils'
],
function(Backbone, URI, HtmlUtils, StringUtils) {
window.Backbone = Backbone;
window.URI = URI;
window.edx = window.edx || {};
window.edx.HtmlUtils = HtmlUtils;
window.edx.StringUtils = StringUtils;
}
);
} }
}, },
'common/js/discussion/content': { 'common/js/discussion/content': {
...@@ -542,11 +553,11 @@ ...@@ -542,11 +553,11 @@
'common/js/discussion/discussion': { 'common/js/discussion/discussion': {
deps: [ deps: [
'common/js/discussion/utils', 'common/js/discussion/utils',
'xmodule_js/common_static/common/js/discussion/content' 'common/js/discussion/content'
], ],
exports: 'Discussion' exports: 'Discussion'
}, },
'common/js/discussion/discussion_course_settings': { 'common/js/discussion/models/discussion_course_settings': {
deps: [ deps: [
'common/js/discussion/utils' 'common/js/discussion/utils'
], ],
...@@ -664,7 +675,7 @@ ...@@ -664,7 +675,7 @@
var testFiles = [ var testFiles = [
'discussion/js/spec/discussion_board_factory_spec.js', 'discussion/js/spec/discussion_board_factory_spec.js',
'discussion/js/spec/discussion_profile_page_factory_spec.js', 'discussion/js/spec/discussion_profile_page_factory_spec.js',
'discussion/js/spec/views/discussion_search_view_spec.js', 'discussion/js/spec/discussion_board_view_spec.js',
'discussion/js/spec/views/discussion_user_profile_view_spec.js', 'discussion/js/spec/views/discussion_user_profile_view_spec.js',
'lms/js/spec/preview/preview_factory_spec.js', 'lms/js/spec/preview/preview_factory_spec.js',
'js/spec/api_admin/catalog_preview_spec.js', 'js/spec/api_admin/catalog_preview_spec.js',
......
lms/templates/discussion/_js_body_dependencies.html
...@@ -16,11 +16,14 @@ from openedx.core.djangolib.js_utils import js_escaped_string ...@@ -16,11 +16,14 @@ from openedx.core.djangolib.js_utils import js_escaped_string
<% <%
discussion_classes = [ discussion_classes = [
['Discussion', 'common/js/discussion/discussion'], ['Discussion', 'common/js/discussion/discussion'],
['Content', 'common/js/discussion/content'],
['DiscussionModuleView', 'common/js/discussion/discussion_module_view'], ['DiscussionModuleView', 'common/js/discussion/discussion_module_view'],
['DiscussionThreadView', 'common/js/discussion/views/discussion_thread_view'], ['DiscussionThreadView', 'common/js/discussion/views/discussion_thread_view'],
['DiscussionThreadListView', 'common/js/discussion/views/discussion_thread_list_view'], ['DiscussionThreadListView', 'common/js/discussion/views/discussion_thread_list_view'],
['DiscussionThreadProfileView', 'common/js/discussion/views/discussion_thread_profile_view'], ['DiscussionThreadProfileView', 'common/js/discussion/views/discussion_thread_profile_view'],
['DiscussionUtil', 'common/js/discussion/utils'], ['DiscussionUtil', 'common/js/discussion/utils'],
['DiscussionCourseSettings', 'common/js/discussion/models/discussion_course_settings'],
['DiscussionUser', 'common/js/discussion/models/discussion_user'],
['NewPostView', 'common/js/discussion/views/new_post_view'], ['NewPostView', 'common/js/discussion/views/new_post_view'],
] ]
%> %>
......
lms/templates/discussion/_thread_list_template.html
<%page expression_filter="h"/> <%page expression_filter="h"/>
<%! from django.utils.translation import ugettext as _ %> <%! from django.utils.translation import ugettext as _ %>
<script type="text/template" id="thread-list-template"> <script type="text/template" id="thread-list-template">
<%include file="_filter_dropdown.html" /> <div class="forum-nav-thread-list-wrapper" id="sort-filter-wrapper" tabindex="-1" style="display:none">
<div class="forum-nav-thread-list-wrapper" id="sort-filter-wrapper" tabindex="-1">
<div class="forum-nav-refine-bar"> <div class="forum-nav-refine-bar">
<label class="forum-nav-filter-main"> <label class="forum-nav-filter-main">
## Translators: This labels a filter menu in forum navigation ## Translators: This labels a filter menu in forum navigation
......
lms/templates/discussion/_underscore_templates.html
...@@ -14,7 +14,7 @@ ...@@ -14,7 +14,7 @@
<% <%
template_names = [ template_names = [
'thread', 'thread-show', 'thread-edit', 'thread-response', 'thread-response-show', 'thread-response-edit', 'thread', 'thread-show', 'thread-edit', 'thread-response', 'thread-response-show', 'thread-response-edit',
'response-comment-show', 'response-comment-edit', 'thread-list-item', 'discussion-home', 'search-alert', 'response-comment-show', 'response-comment-edit', 'thread-list-item', 'search-alert',
'new-post', 'new-post-menu-entry', 'new-post-menu-category', 'new-post-alert', 'topic', 'post-user-display', 'new-post', 'new-post-menu-entry', 'new-post-menu-category', 'new-post-alert', 'topic', 'post-user-display',
'inline-discussion', 'pagination', 'profile-thread', 'customwmd-prompt', 'nav-loading', 'thread-type' 'inline-discussion', 'pagination', 'profile-thread', 'customwmd-prompt', 'nav-loading', 'thread-type'
] ]
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment