Merge pull request #8567 from edx/alasdair/ECOM-1673-dashboard-challenge-expanded

ECOM-1673 removed class and icon to always show full upsell content.

common/test/acceptance/pages/lms/dashboard.py

@@ -109,8 +109,7 @@ class DashboardPage(PageObject):
             # There should only be one course listing corresponding to the provided course name.
             el = course_listing[0]
 
-            # Expand the upsell copy and click the upgrade button
-            el.find_element_by_css_selector('.message-upsell .ui-toggle-expansion').click()
+            # Click the upgrade button
             el.find_element_by_css_selector('#upgrade-to-verified').click()
 
             upgrade_page.wait_for_page()

lms/static/js/dashboard/legacy.js

@@ -37,7 +37,6 @@
             notifications.focus();
         }
 
-        $('.message.is-expandable .wrapper-tip').bind('click', toggleExpandMessage);
         $('.action-more').bind('click', toggleCourseActionsDropdown);
 
         // Track clicks of the upgrade button. The `trackLink` method is a helper that makes
@@ -80,19 +79,6 @@
             return properties;
         }
 
-        function toggleExpandMessage(event) {
-            var course = $(event.target).closest('.message-upsell').find('.action-upgrade').data('course-id');
-
-            event.preventDefault();
-
-            $(this).closest('.message.is-expandable').toggleClass('is-expanded');
-
-            window.analytics.track('edx.bi.dashboard.upgrade_copy.expanded', {
-                category: 'upgrade',
-                label: course
-            });
-        }
-
         function toggleCourseActionsDropdown(event) {
             var dashboard_index = $(this).data('dashboard-index');
 

lms/templates/dashboard/_dashboard_course_listing.html

@@ -312,11 +312,10 @@ from student.helpers import (
         % endif
 
         % if course_mode_info['show_upsell'] and not is_course_blocked:
-          <div class="message message-upsell has-actions is-expandable is-shown">
+          <div class="message message-upsell has-actions is-shown">
             <div class="wrapper-tip">
               <h4 class="message-title">
-                <i class="icon fa fa-caret-right ui-toggle-expansion"></i>
-                  <span class="value">${_("Challenge Yourself!")}</span>
+                <span class="value">${_("Challenge Yourself!")}</span>
               </h4>
               <p class="message-copy">${_("Take this course as an ID-verified student.")}</p>
             </div>