Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
346fb7b4
Commit
346fb7b4
authored
Aug 15, 2013
by
Peter Fogg
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #698 from edx/peter-fogg/grading-cutoffs-fix
Fix grade range names not being editable.
parents
a260115b
a93d7229
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
23 additions
and
1 deletions
+23
-1
cms/djangoapps/contentstore/features/grading.feature
+9
-0
cms/djangoapps/contentstore/features/grading.py
+13
-0
cms/static/js/views/settings/settings_grading_view.js
+1
-1
No files found.
cms/djangoapps/contentstore/features/grading.feature
View file @
346fb7b4
...
...
@@ -84,3 +84,12 @@ Feature: Course Grading
And
I am viewing the grading settings
When
I change assignment type
"Homework"
to
""
Then
the save button is disabled
Scenario
:
User can edit grading range names
Given
I have opened a new course in Studio
And
I have populated the course
And
I am viewing the grading settings
When
I change the highest grade range to
"Good"
And
I press the
"Save"
notification button
And
I reload the page
Then
I see the highest grade range is
"Good"
cms/djangoapps/contentstore/features/grading.py
View file @
346fb7b4
...
...
@@ -117,6 +117,19 @@ def i_see_the_assignment_type(_step, name):
assert
name
in
types
@step
(
u'I change the highest grade range to "(.*)"$'
)
def
change_grade_range
(
_step
,
range_name
):
range_css
=
'span.letter-grade'
grade
=
world
.
css_find
(
range_css
)
.
first
grade
.
value
=
range_name
@step
(
u'I see the highest grade range is "(.*)"$'
)
def
i_see_highest_grade_range
(
_step
,
range_name
):
range_css
=
'span.letter-grade'
grade
=
world
.
css_find
(
range_css
)
.
first
assert
grade
.
value
==
range_name
def
get_type_index
(
name
):
name_id
=
'#course-grading-assignment-name'
all_types
=
world
.
css_find
(
name_id
)
...
...
cms/static/js/views/settings/settings_grading_view.js
View file @
346fb7b4
...
...
@@ -8,7 +8,7 @@ CMS.Views.Settings.Grading = CMS.Views.ValidatingView.extend({
// Leaving change in as fallback for older browsers
"change input"
:
"updateModel"
,
"change textarea"
:
"updateModel"
,
"
change span[contenteditable=tru
e]"
:
"updateDesignation"
,
"
input span[contenteditabl
e]"
:
"updateDesignation"
,
"click .settings-extra header"
:
"showSettingsExtras"
,
"click .new-grade-button"
:
"addNewGrade"
,
"click .remove-button"
:
"removeGrade"
,
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment