Merge pull request #10228 from edx/zoldak/fix-acceptance-select-helpers

Fix the helpers for Select objects by wrapping them in promises

common/test/acceptance/tests/helpers.py

@@ -21,6 +21,7 @@ from pymongo import MongoClient, ASCENDING
 from openedx.core.lib.tests.assertions.events import assert_event_matches, is_matching_event, EventMatchTolerates
 from xmodule.partitions.partitions import UserPartition
 from xmodule.partitions.tests.test_partitions import MockUserPartitionScheme
+from selenium.common.exceptions import StaleElementReferenceException
 from selenium.webdriver.support.select import Select
 from selenium.webdriver.support.ui import WebDriverWait
 from selenium.webdriver.support import expected_conditions as EC
@@ -201,17 +202,40 @@ def enable_css_animations(page):
 def select_option_by_text(select_browser_query, option_text):
     """
     Chooses an option within a select by text (helper method for Select's select_by_visible_text method).
+
+    Wrap this in a Promise to prevent a StaleElementReferenceException
+    from being raised while the DOM is still being rewritten
     """
-    select = Select(select_browser_query.first.results[0])
-    select.select_by_visible_text(option_text)
+    def select_option(query, value):
+        """ Get the first select element that matches the query and select the desired value. """
+        try:
+            select = Select(query.first.results[0])
+            select.select_by_visible_text(value)
+            return True
+        except StaleElementReferenceException:
+            return False
+
+    msg = 'Selected option {}'.format(option_text)
+    EmptyPromise(lambda: select_option(select_browser_query, option_text), msg).fulfill()
 
 
 def get_selected_option_text(select_browser_query):
     """
     Returns the text value for the first selected option within a select.
+
+    Wrap this in a Promise to prevent a StaleElementReferenceException
+    from being raised while the DOM is still being rewritten
     """
-    select = Select(select_browser_query.first.results[0])
-    return select.first_selected_option.text
+    def get_option(query):
+        """ Get the first select element that matches the query and return its value. """
+        try:
+            select = Select(query.first.results[0])
+            return (True, select.first_selected_option.text)
+        except StaleElementReferenceException:
+            return (False, None)
+
+    text = Promise(lambda: get_option(select_browser_query), 'Retrieved selected option text').fulfill()
+    return text
 
 
 def get_options(select_browser_query):