Skip to content

E
edx-platform
Commit 2757ac4f by Julia Hansbrough Committed by Sarina Canelake
Options

Opaque-keys: response to code review

parent 3a9f0b3f
Showing with 2 additions and 3 deletions
cms/djangoapps/contentstore/tests/test_permissions.py
...@@ -99,10 +99,8 @@ class TestCourseAccess(ModuleStoreTestCase): ...@@ -99,10 +99,8 @@ class TestCourseAccess(ModuleStoreTestCase):
user_by_role[role] = [] user_by_role[role] = []
# Org-based roles are created via org name, rather than course_key # Org-based roles are created via org name, rather than course_key
if (role is OrgStaffRole) or (role is OrgInstructorRole): if (role is OrgStaffRole) or (role is OrgInstructorRole):
# pylint: disable=protected-access
group = role(self.course_key.org) group = role(self.course_key.org)
else: else:
# pylint: disable=protected-access
group = role(self.course_key) group = role(self.course_key)
# NOTE: this loop breaks the roles.py abstraction by purposely assigning # NOTE: this loop breaks the roles.py abstraction by purposely assigning
# users to one of each possible groupname in order to test that has_course_access # users to one of each possible groupname in order to test that has_course_access
...@@ -125,7 +123,8 @@ class TestCourseAccess(ModuleStoreTestCase): ...@@ -125,7 +123,8 @@ class TestCourseAccess(ModuleStoreTestCase):
auth.add_users( auth.add_users(
self.user, self.user,
role(copy_course_key.org), role(copy_course_key.org),
*role(self.course_key.org).users_with_role()) *role(self.course_key.org).users_with_role()
)
else: else:
auth.add_users( auth.add_users(
self.user, self.user,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment