Merge pull request #520 from MITx/feature/rocky/discussion

add user profile and fixed edit

lms/djangoapps/django_comment_client/base/views.py

@@ -21,7 +21,6 @@ from django.contrib.auth.models import User
 from mitxmako.shortcuts import render_to_response, render_to_string
 from courseware.courses import get_course_with_access
 
-
 from django_comment_client.utils import JsonResponse, JsonError, extract
 
 from django_comment_client.permissions import check_permissions_by_view
@@ -282,7 +281,7 @@ def update_moderator_status(request, course_id, user_id):
             'course_id': course_id,
             'user': request.user,
             'django_user': user,
-            'discussion_user': discussion_user.to_dict(),
+            'profiled_user': discussion_user.to_dict(),
         }
         return JsonResponse({
             'html': render_to_string('discussion/ajax_user_profile.html', context)
@@ -298,10 +297,13 @@ def search_similar_threads(request, course_id, commentable_id):
             'text': text,
             'commentable_id': commentable_id,
         }
-        result = cc.search_similar_threads(course_id, recursive=False, query_params=query_params)
-        return JsonResponse(result)
+        threads = cc.search_similar_threads(course_id, recursive=False, query_params=query_params)
     else:
-        return JsonResponse([])
+        theads = []
+    context = { 'threads': map(utils.extend_content, threads) }
+    return JsonResponse({
+        'html': render_to_string('discussion/_similar_posts.html', context)
+    })
 
 @require_GET
 def tags_autocomplete(request, course_id):
@@ -334,8 +336,8 @@ def upload(request, course_id):#ajax upload file to a question or answer
         # check file type
         f = request.FILES['file-upload']
         file_extension = os.path.splitext(f.name)[1].lower()
-        if not file_extension in settings.DISCUSSION_ALLOWED_UPLOAD_FILE_TYPES:
-            file_types = "', '".join(settings.DISCUSSION_ALLOWED_UPLOAD_FILE_TYPES)
+        if not file_extension in cc_settings.ALLOWED_UPLOAD_FILE_TYPES:
+            file_types = "', '".join(cc_settings.ALLOWED_UPLOAD_FILE_TYPES)
             msg = _("allowed file types are '%(file_types)s'") % \
                     {'file_types': file_types}
             raise exceptions.PermissionDenied(msg)
@@ -354,15 +356,16 @@ def upload(request, course_id):#ajax upload file to a question or answer
         # check file size
         # byte
         size = file_storage.size(new_file_name)
-        if size > settings.ASKBOT_MAX_UPLOAD_FILE_SIZE:
+        if size > cc_settings.MAX_UPLOAD_FILE_SIZE:
             file_storage.delete(new_file_name)
             msg = _("maximum upload file size is %(file_size)sK") % \
-                    {'file_size': settings.ASKBOT_MAX_UPLOAD_FILE_SIZE}
+                    {'file_size': cc_settings.MAX_UPLOAD_FILE_SIZE}
             raise exceptions.PermissionDenied(msg)
 
     except exceptions.PermissionDenied, e:
         error = unicode(e)
     except Exception, e:
+        print e
         logging.critical(unicode(e))
         error = _('Error uploading file. Please contact the site administrator. Thank you.')
 

lms/djangoapps/django_comment_client/forum/views.py

@@ -83,7 +83,7 @@ def render_discussion(request, course_id, threads, *args, **kwargs):
         'base_url': base_url,
         'query_params': strip_blank(strip_none(extract(query_params, ['page', 'sort_key', 'sort_order', 'tags', 'text']))),
         'annotated_content_info': json.dumps(annotated_content_info),
-        'discussion_data': json.dumps({ discussion_id: threads }),
+        'discussion_data': json.dumps({ (discussion_id or user_id): threads })
     }
     context = dict(context.items() + query_params.items())
     return render_to_string(template, context)
@@ -250,7 +250,10 @@ def user_profile(request, course_id, user_id):
     content = render_user_discussion(request, course_id, threads, user_id=user_id, query_params=query_params)
 
     if request.is_ajax():
-        return utils.HtmlResponse(content)
+        return utils.JsonResponse({
+            'html': content,
+            'discussionData': threads,
+        })
     else:
         context = {
             'course': course, 

lms/djangoapps/django_comment_client/helpers.py

@@ -12,7 +12,7 @@ import urllib
 import os
 
 def pluralize(singular_term, count):
-    if int(count) >= 2:
+    if int(count) >= 2 or int(count) == 0:
         return singular_term + 's'
     return singular_term
 
@@ -33,24 +33,10 @@ def include_mustache_templates():
     file_contents = map(read_file, filter(valid_file_name, os.listdir(mustache_dir)))
     return '\n'.join(map(wrap_in_tag, map(strip_file_name, file_contents)))
 
-def permalink(content):
-    if content['type'] == 'thread':
-        return reverse('django_comment_client.forum.views.single_thread',
-                       args=[content['course_id'], content['commentable_id'], content['id']])
-    else:
-        return reverse('django_comment_client.forum.views.single_thread',
-                       args=[content['course_id'], content['commentable_id'], content['thread_id']]) + '#' + content['id']
-
 def render_content(content, additional_context={}):
-    content_info = {
-        'displayed_title': content.get('highlighted_title') or content.get('title', ''),
-        'displayed_body': content.get('highlighted_body') or content.get('body', ''),
-        'raw_tags': ','.join(content.get('tags', [])),
-        'permalink': permalink(content),
-    }
     
     context = {
-        'content': merge_dict(content, content_info),
+        'content': extend_content(content),
         content['type']: True,
     }
     context = merge_dict(context, additional_context)

lms/djangoapps/django_comment_client/mustache_helpers.py

@@ -7,7 +7,8 @@ import inspect
 
 def pluralize(content, text):
     num, word = text.split(' ')
-    if int(num or '0') >= 2:
+    num = int(num or '0')
+    if num >= 2 or num == 0:
         return word + 's'
     else:
         return word

lms/djangoapps/django_comment_client/settings.py

+from django.conf import settings
+
+MAX_COMMENT_DEPTH = None
+MAX_UPLOAD_FILE_SIZE = 1024 * 1024 #result in bytes
+ALLOWED_UPLOAD_FILE_TYPES = ('.jpg', '.jpeg', '.gif', '.bmp', '.png', '.tiff')
+
+if hasattr(settings, 'DISCUSSION_SETTINGS'):
+    MAX_COMMENT_DEPTH = settings.DISCUSSION_SETTINGS.get('MAX_COMMENT_DEPTH')
+    MAX_UPLOAD_FILE_SIZE = settings.DISCUSSION_SETTINGS.get('MAX_UPLOAD_FILE_SIZE') or MAX_UPLOAD_FILE_SIZE
+    ALLOWED_UPLOAD_FILE_TYPES = settings.DISCUSSION_SETTINGS.get('ALLOWED_UPLOAD_FILE_TYPES') or ALLOWED_UPLOAD_FILE_TYPES

lms/djangoapps/django_comment_client/utils.py

@@ -197,3 +197,20 @@ def url_for_tags(course_id, tags):
 def render_mustache(template_name, dictionary, *args, **kwargs):
     template = middleware.lookup['main'].get_template(template_name).source
     return pystache.render(template, dictionary)
+
+def permalink(content):
+    if content['type'] == 'thread':
+        return reverse('django_comment_client.forum.views.single_thread',
+                       args=[content['course_id'], content['commentable_id'], content['id']])
+    else:
+        return reverse('django_comment_client.forum.views.single_thread',
+                       args=[content['course_id'], content['commentable_id'], content['thread_id']]) + '#' + content['id']
+
+def extend_content(content):
+    content_info = {
+        'displayed_title': content.get('highlighted_title') or content.get('title', ''),
+        'displayed_body': content.get('highlighted_body') or content.get('body', ''),
+        'raw_tags': ','.join(content.get('tags', [])),
+        'permalink': permalink(content),
+    }
+    return merge_dict(content, content_info)

lms/static/coffee/src/discussion/discussion_module.coffee

-class @DiscussionModuleView extends Backbone.View
-  events:
-    "click .discussion-show": "toggleDiscussion"
-  toggleDiscussion: (event) ->
-    if @showed
-      @$("section.discussion").hide()
-      $(event.target).html("Show Discussion")
-      @showed = false
-    else
-      if @retrieved
-        @$("section.discussion").show()
-        $(event.target).html("Hide Discussion")
-        @showed = true
+if Backbone?
+  class @DiscussionModuleView extends Backbone.View
+    events:
+      "click .discussion-show": "toggleDiscussion"
+    toggleDiscussion: (event) ->
+      if @showed
+        @$("section.discussion").hide()
+        $(event.target).html("Show Discussion")
+        @showed = false
       else
-        $elem = $(event.target)
-        discussion_id = $elem.attr("discussion_id")
-        url = DiscussionUtil.urlFor 'retrieve_discussion', discussion_id
-        Discussion.safeAjax
-          $elem: $elem
-          url: url
-          type: "GET"
-          dataType: 'json'
-          success: (response, textStatus) =>
-            @$el.append(response.html)
-            $discussion = @$el.find("section.discussion")
-            $(event.target).html("Hide Discussion")
-            discussion = new Discussion()
-            discussion.reset(response.discussionData, {silent: false})
-            view = new DiscussionView(el: $discussion[0], model: discussion)
-            DiscussionUtil.bulkUpdateContentInfo(window.$$annotated_content_info)
-            @retrieved = true
-            @showed = true
+        if @retrieved
+          @$("section.discussion").show()
+          $(event.target).html("Hide Discussion")
+          @showed = true
+        else
+          $elem = $(event.target)
+          discussion_id = $elem.attr("discussion_id")
+          url = DiscussionUtil.urlFor 'retrieve_discussion', discussion_id
+          DiscussionUtil.safeAjax
+            $elem: $elem
+            url: url
+            type: "GET"
+            dataType: 'json'
+            success: (response, textStatus) =>
+              @$el.append(response.html)
+              $discussion = @$el.find("section.discussion")
+              $(event.target).html("Hide Discussion")
+              discussion = new Discussion()
+              discussion.reset(response.discussionData, {silent: false})
+              view = new DiscussionView(el: $discussion[0], model: discussion)
+              DiscussionUtil.bulkUpdateContentInfo(window.$$annotated_content_info)
+              @retrieved = true
+              @showed = true

lms/static/coffee/src/discussion/main.coffee

@@ -12,4 +12,10 @@ $ ->
     discussion.reset(discussionData, {silent: false})
     view = new DiscussionView(el: elem, model: discussion)
 
-  DiscussionUtil.bulkUpdateContentInfo(window.$$annotated_content_info)
+  if window.$$annotated_content_info?
+    DiscussionUtil.bulkUpdateContentInfo(window.$$annotated_content_info)
+
+  $userProfile = $(".discussion-sidebar>.user-profile")
+  if $userProfile.length
+    console.log "initialize user profile"
+    view = new DiscussionUserProfileView(el: $userProfile[0])

lms/static/coffee/src/discussion/user_profile.coffee

-if not @Discussion?
-  @Discussion = {}
+class @DiscussionUserProfileView extends Backbone.View
+  toggleModeratorStatus: (event) ->
+    confirmValue = confirm("Are you sure?")
+    if not confirmValue then return
+    $elem = $(event.target)
+    if $elem.hasClass("sidebar-promote-moderator-button")
+      isModerator = true
+    else if $elem.hasClass("sidebar-revoke-moderator-button")
+      isModerator = false
+    else
+      console.error "unrecognized moderator status"
+      return
+    url = DiscussionUtil.urlFor('update_moderator_status', $$profiled_user_id)
+    DiscussionUtil.safeAjax
+      $elem: $elem
+      url: url
+      type: "POST"
+      dataType: 'json'
+      data:
+        is_moderator: isModerator
+      error: (response, textStatus, e) ->
+        console.log e
+      success: (response, textStatus) =>
+        parent = @$el.parent()
+        @$el.replaceWith(response.html)
+        view = new DiscussionUserProfileView el: parent.children(".user-profile")
 
-Discussion = @Discussion
-
-@Discussion = $.extend @Discussion,
-  initializeUserProfile: ($userProfile) ->
-    $local = Discussion.generateLocal $userProfile
-
-    handleUpdateModeratorStatus = (elem, isModerator) ->
-      confirmValue = confirm("Are you sure?")
-      if not confirmValue then return
-      url = Discussion.urlFor('update_moderator_status', $$profiled_user_id)
-      Discussion.safeAjax
-        $elem: $(elem)
-        url: url
-        type: "POST"
-        dataType: 'json'
-        data:
-          is_moderator: isModerator
-        error: (response, textStatus, e) ->
-          console.log e
-        success: (response, textStatus) ->
-          parent = $userProfile.parent()
-          $userProfile.replaceWith(response.html)
-          Discussion.initializeUserProfile parent.children(".user-profile")
-
-    Discussion.bindLocalEvents $local,
-      "click .sidebar-revoke-moderator-button": (event) ->
-        handleUpdateModeratorStatus(this, false)
-      "click .sidebar-promote-moderator-button": (event) ->
-        handleUpdateModeratorStatus(this, true)
-
-  initializeUserActiveDiscussion: ($discussion) ->
+  events:
+    "click .sidebar-toggle-moderator-button": "toggleModeratorStatus"

lms/templates/courseware/courseware.html

@@ -22,6 +22,7 @@
   ##  <script type="text/javascript" src="${static.url('js/vendor/CodeMirror-2.25/mode/python/python.js')}"></script>
 
   <%static:js group='courseware'/>
+  <%static:js group='discussion'/>
 
   <%include file="../discussion/_js_body_dependencies.html" />
   

lms/templates/discussion/_content_renderer.html

 <%! import django_comment_client.helpers as helpers %>
 
-<%def name="render_content(content)">
-  ${helpers.render_content(content)}
+<%def name="render_content(content, *args, **kwargs)">
+  ${helpers.render_content(content, *args, **kwargs)}
 </%def>
 
-<%def name="render_content_with_comments(content)">
+<%def name="render_content_with_comments(content, *args, **kwargs)">
   <div class="${content['type']}${helpers.show_if(' endorsed', content.get('endorsed'))}" _id="${content['id']}" _discussion_id="${content.get('commentable_id', '')}" _author_id="${helpers.show_if(content['user_id'], not content.get('anonymous'))}">
-    ${render_content(content)}
-    ${render_comments(content.get('children', []))}
+    ${render_content(content, *args, **kwargs)}
+    ${render_comments(content.get('children', []), *args, **kwargs)}
   </div>
 </%def>
 
-<%def name="render_comments(comments)">
+<%def name="render_comments(comments, *args, **kwargs)">
   <div class="comments">
     % for comment in comments:
-      ${render_content_with_comments(comment)}
+      ${render_content_with_comments(comment, *args, **kwargs)}
     % endfor
   </div>
 </%def>

lms/templates/discussion/_similar_posts.html

+% if len(threads) > 0:
+  Similar Posts: 
+  <a class="hide-similar-posts" href="javascript:void(0)">Hide</a>
+  <div class="new-post-similar-posts">
+    % for thread in threads:
+      <a class="similar-post" href="${thread['permalink']}">${thread['title']}</a>
+    % endfor
+  </div>
+% endif

lms/templates/discussion/_user_active_threads.html

-<%namespace name="renderer" file="_thread.html"/>
+<%namespace name="renderer" file="_content_renderer.html"/>
 
-<section class="discussion user-active-discussion">
+<section class="discussion user-active-discussion" _id="${user_id}">
 
-  <div class="discussion-non-content discussion-local"></div>
+  <div class="discussion-non-content local"></div>
 
   <div class="threads">
     % for thread in threads:
-      ${renderer.render_thread(course_id, thread, show_comments=True)}
+      ${renderer.render_content_with_comments(thread, {'partial_comments': True})}
     % endfor
   </div>
 

lms/templates/discussion/_user_profile.html

-<%! from django_comment_client.utils import pluralize %>
+<%! from django_comment_client.helpers import pluralize %>
 <%! from django_comment_client.permissions import has_permission, check_permissions_by_view %>
 <%! from operator import attrgetter %>
 
@@ -15,9 +15,9 @@
   <div class="sidebar-comments-count"><span>${profiled_user['comments_count']}</span> ${pluralize('comment', profiled_user['comments_count'])}</div>
   % if check_permissions_by_view(user, course.id, content=None, name='update_moderator_status'):
     % if "Moderator" in role_names:
-      <a href="javascript:void(0)" class="sidebar-revoke-moderator-button">Revoke Moderator provileges</a>
+      <a href="javascript:void(0)" class="sidebar-toggle-moderator-button sidebar-revoke-moderator-button">Revoke Moderator provileges</a>
     % else:
-      <a href="javascript:void(0)" class="sidebar-promote-moderator-button">Promote to Moderator</a>
+      <a href="javascript:void(0)" class="sidebar-toggle-moderator-button sidebar-promote-moderator-button">Promote to Moderator</a>
     % endif
   % endif
 </div>

lms/templates/discussion/index.html

 <%inherit file="../main.html" />
 <%namespace name='static' file='../static_content.html'/>
 <%block name="bodyclass">discussion</%block>
-<%block name="title"><title>Discussion – MITx 6.002x</title></%block>
+<%block name="title"><title>Discussion – ${course.number}</title></%block>
 
 <%block name="headextra">
 <%static:css group='course'/>

lms/templates/discussion/mustache/_content.mustache

@@ -37,7 +37,7 @@
               anonymous
             {{/content.anonymous}}
             {{^content.anonymous}}
-              {{content.username}}
+              <a href="{{##url_for_user}}{{content.user_id}}{{/url_for_user}}">{{content.username}}</a>
             {{/content.anonymous}}
           </div>
           <div class="show-comments-wrapper">

lms/templates/discussion/mustache/_new_post.mustache

 <form class="new-post-form collapsed" id="new-post-form" style="display: block; ">
   <ul class="new-post-form-errors discussion-errors"></ul>
   <input type="text" class="new-post-title title-input" placeholder="Title" />
-  <div class="new-post-similar-posts-wrapper" style="display: none">
-    Similar Posts: 
-    <a class="hide-similar-posts" href="javascript:void(0)">Hide</a>
-    <div class="new-post-similar-posts"></div>
-  </div>
+  <div class="new-post-similar-posts-wrapper" style="display: none"></div>
   <div class="new-post-body reply-body"></div>
   <input class="new-post-tags" placeholder="Tags" />
   <div class="post-options">

lms/templates/discussion/single_thread.html

 <%inherit file="../main.html" />
 <%namespace name='static' file='../static_content.html'/>
 <%block name="bodyclass">discussion</%block>
-<%block name="title"><title>Discussion – MITx 6.002x</title></%block>
+<%block name="title"><title>Discussion – ${course.number}</title></%block>
 
 <%block name="headextra">
 <%static:css group='course'/>

lms/templates/discussion/user_profile.html

 <%! from django.template.defaultfilters import escapejs %>
-<%namespace name="renderer" file="_thread.html"/>
 
 <%inherit file="../main.html" />
 <%namespace name='static' file='../static_content.html'/>
 <%block name="bodyclass">discussion</%block>
-<%block name="title"><title>Discussion – MITx 6.002x</title></%block>
+<%block name="title"><title>Discussion – ${course.number}</title></%block>
 
 <%block name="headextra">
 <%static:css group='course'/>
+<%include file="_js_head_dependencies.html" />
 </%block>
 
 <%block name="js_extra">
-<%include file="_js_dependencies.html" />
+<%include file="_js_body_dependencies.html" />
+<%static:js group='discussion'/>
 </%block>
 
-<%include file="/courseware/course_navigation.html" args="active_page='discussion'" />
+<%include file="../courseware/course_navigation.html" args="active_page='discussion'" />
 
 <section class="container">
   <div class="course-wrapper">