Merge pull request #9693 from edx/muhhshoaib/fix-flaky-test

SOL-1182 Fix of Flaky test in proctored exams.

common/test/acceptance/pages/lms/instructor_dashboard.py

@@ -72,7 +72,7 @@ class InstructorDashboardPage(CoursePage):
         """
         self.q(css='a[data-section=proctoring]').first.click()
         proctoring_section = ProctoringPage(self.browser)
-        proctoring_section.wait_for_ajax()
+        proctoring_section.wait_for_page()
         return proctoring_section
 
     @staticmethod

common/test/acceptance/tests/lms/test_lms_instructor_dashboard.py

@@ -209,7 +209,7 @@ class ProctoredExamsTest(BaseInstructorDashboardTest):
         self._auto_auth("STAFF_TESTER", "staff101@example.com", True)
         self.course_outline.visit()
 
-        #open the exam settings to make it a proctored exam.
+        # open the exam settings to make it a proctored exam.
         self.course_outline.open_exam_settings_dialog()
         self.course_outline.make_exam_timed()
         time.sleep(2)  # Wait for 2 seconds to save the settings.
@@ -222,14 +222,12 @@ class ProctoredExamsTest(BaseInstructorDashboardTest):
         # Start the proctored exam.
         self.courseware_page.start_timed_exam()
 
-    @flaky  # TODO fix this, see SOL-1183
     def test_can_add_remove_allowance(self):
         """
         Make sure that allowances can be added and removed.
         """
-
-        # Given that an exam has been configured to be a proctored exam.
-        self._create_a_proctored_exam_and_attempt()
+        # Given that an exam has been configured to be a timed exam.
+        self._create_a_timed_exam_and_attempt()
 
         # When I log in as an instructor,
         self.log_in_as_instructor()