Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
204b52e9
Commit
204b52e9
authored
Oct 17, 2014
by
Waheed Ahmed
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Added three missing required states for video progress slider.
TNL-89
parent
16771e69
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
15 additions
and
1 deletions
+15
-1
common/lib/xmodule/xmodule/js/spec/video/video_progress_slider_spec.js
+5
-0
common/lib/xmodule/xmodule/js/src/video/06_video_progress_slider.js
+10
-1
No files found.
common/lib/xmodule/xmodule/js/spec/video/video_progress_slider_spec.js
View file @
204b52e9
...
...
@@ -122,6 +122,11 @@
'option'
,
'value'
,
20
);
});
it
(
'required aria values updated'
,
function
()
{
expect
(
state
.
videoProgressSlider
.
handle
.
attr
(
'aria-valuenow'
)).
toBe
(
'20'
);
expect
(
state
.
videoProgressSlider
.
handle
.
attr
(
'aria-valuemax'
)).
toBe
(
'120'
);
});
});
});
...
...
common/lib/xmodule/xmodule/js/src/video/06_video_progress_slider.js
View file @
204b52e9
...
...
@@ -76,7 +76,10 @@ function () {
'title'
:
gettext
(
'Video position'
),
'aria-disabled'
:
false
,
'aria-valuetext'
:
getTimeDescription
(
state
.
videoProgressSlider
.
slider
.
slider
(
'option'
,
'value'
))
.
slider
.
slider
(
'option'
,
'value'
)),
'aria-valuemax'
:
state
.
videoPlayer
.
duration
(),
'aria-valuemin'
:
'0'
,
'aria-valuenow'
:
state
.
videoPlayer
.
currentTime
});
}
...
...
@@ -243,6 +246,12 @@ function () {
.
slider
(
'option'
,
'max'
,
duration
)
.
slider
(
'option'
,
'value'
,
time
);
}
// Update aria values.
this
.
videoProgressSlider
.
handle
.
attr
({
'aria-valuemax'
:
duration
,
'aria-valuenow'
:
time
});
}
// When the video stops playing (either because the end was reached, or
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment