Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
1708dc40
Commit
1708dc40
authored
Jan 08, 2013
by
Don Mitchell
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Use html rather than xml parsing for course updates
parent
7377f4bd
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
with
14 additions
and
14 deletions
+14
-14
cms/djangoapps/contentstore/course_info_model.py
+14
-14
No files found.
cms/djangoapps/contentstore/course_info_model.py
View file @
1708dc40
from
xmodule.modulestore.exceptions
import
ItemNotFoundError
from
xmodule.modulestore.exceptions
import
ItemNotFoundError
from
xmodule.modulestore
import
Location
from
xmodule.modulestore
import
Location
from
xmodule.modulestore.django
import
modulestore
from
xmodule.modulestore.django
import
modulestore
from
lxml
import
etree
from
lxml
import
html
import
re
import
re
from
django.http
import
HttpResponseBadRequest
from
django.http
import
HttpResponseBadRequest
import
logging
import
logging
...
@@ -24,9 +24,9 @@ def get_course_updates(location):
...
@@ -24,9 +24,9 @@ def get_course_updates(location):
# purely to handle free formed updates not done via editor. Actually kills them, but at least doesn't break.
# purely to handle free formed updates not done via editor. Actually kills them, but at least doesn't break.
try
:
try
:
course_html_parsed
=
etree
.
fromstring
(
course_updates
.
definition
[
'data'
])
course_html_parsed
=
html
.
fromstring
(
course_updates
.
definition
[
'data'
])
except
etree
.
XMLSyntaxError
:
except
:
course_html_parsed
=
etree
.
fromstring
(
"<ol></ol>"
)
course_html_parsed
=
html
.
fromstring
(
"<ol></ol>"
)
# Confirm that root is <ol>, iterate over <li>, pull out <h2> subs and then rest of val
# Confirm that root is <ol>, iterate over <li>, pull out <h2> subs and then rest of val
course_upd_collection
=
[]
course_upd_collection
=
[]
...
@@ -39,7 +39,7 @@ def get_course_updates(location):
...
@@ -39,7 +39,7 @@ def get_course_updates(location):
# could enforce that update[0].tag == 'h2'
# could enforce that update[0].tag == 'h2'
content
=
update
[
0
]
.
tail
content
=
update
[
0
]
.
tail
else
:
else
:
content
=
"
\n
"
.
join
([
etree
.
tostring
(
ele
)
for
ele
in
update
[
1
:]])
content
=
"
\n
"
.
join
([
html
.
tostring
(
ele
)
for
ele
in
update
[
1
:]])
# make the id on the client be 1..len w/ 1 being the oldest and len being the newest
# make the id on the client be 1..len w/ 1 being the oldest and len being the newest
course_upd_collection
.
append
({
"id"
:
location_base
+
"/"
+
str
(
len
(
course_html_parsed
)
-
idx
),
course_upd_collection
.
append
({
"id"
:
location_base
+
"/"
+
str
(
len
(
course_html_parsed
)
-
idx
),
...
@@ -61,12 +61,12 @@ def update_course_updates(location, update, passed_id=None):
...
@@ -61,12 +61,12 @@ def update_course_updates(location, update, passed_id=None):
# purely to handle free formed updates not done via editor. Actually kills them, but at least doesn't break.
# purely to handle free formed updates not done via editor. Actually kills them, but at least doesn't break.
try
:
try
:
course_html_parsed
=
etree
.
fromstring
(
course_updates
.
definition
[
'data'
])
course_html_parsed
=
html
.
fromstring
(
course_updates
.
definition
[
'data'
])
except
etree
.
XMLSyntaxError
:
except
:
course_html_parsed
=
etree
.
fromstring
(
"<ol></ol>"
)
course_html_parsed
=
html
.
fromstring
(
"<ol></ol>"
)
# No try/catch b/c failure generates an error back to client
# No try/catch b/c failure generates an error back to client
new_html_parsed
=
etree
.
fromstring
(
'<li><h2>'
+
update
[
'date'
]
+
'</h2>'
+
update
[
'content'
]
+
'</li>'
)
new_html_parsed
=
html
.
fromstring
(
'<li><h2>'
+
update
[
'date'
]
+
'</h2>'
+
update
[
'content'
]
+
'</li>'
)
# Confirm that root is <ol>, iterate over <li>, pull out <h2> subs and then rest of val
# Confirm that root is <ol>, iterate over <li>, pull out <h2> subs and then rest of val
if
course_html_parsed
.
tag
==
'ol'
:
if
course_html_parsed
.
tag
==
'ol'
:
...
@@ -82,7 +82,7 @@ def update_course_updates(location, update, passed_id=None):
...
@@ -82,7 +82,7 @@ def update_course_updates(location, update, passed_id=None):
passed_id
=
course_updates
.
location
.
url
()
+
"/"
+
str
(
idx
)
passed_id
=
course_updates
.
location
.
url
()
+
"/"
+
str
(
idx
)
# update db record
# update db record
course_updates
.
definition
[
'data'
]
=
etree
.
tostring
(
course_html_parsed
)
course_updates
.
definition
[
'data'
]
=
html
.
tostring
(
course_html_parsed
)
modulestore
(
'direct'
)
.
update_item
(
location
,
course_updates
.
definition
[
'data'
])
modulestore
(
'direct'
)
.
update_item
(
location
,
course_updates
.
definition
[
'data'
])
return
{
"id"
:
passed_id
,
return
{
"id"
:
passed_id
,
...
@@ -105,9 +105,9 @@ def delete_course_update(location, update, passed_id):
...
@@ -105,9 +105,9 @@ def delete_course_update(location, update, passed_id):
# TODO use delete_blank_text parser throughout and cache as a static var in a class
# TODO use delete_blank_text parser throughout and cache as a static var in a class
# purely to handle free formed updates not done via editor. Actually kills them, but at least doesn't break.
# purely to handle free formed updates not done via editor. Actually kills them, but at least doesn't break.
try
:
try
:
course_html_parsed
=
etree
.
fromstring
(
course_updates
.
definition
[
'data'
])
course_html_parsed
=
html
.
fromstring
(
course_updates
.
definition
[
'data'
])
except
etree
.
XMLSyntaxError
:
except
:
course_html_parsed
=
etree
.
fromstring
(
"<ol></ol>"
)
course_html_parsed
=
html
.
fromstring
(
"<ol></ol>"
)
if
course_html_parsed
.
tag
==
'ol'
:
if
course_html_parsed
.
tag
==
'ol'
:
# ??? Should this use the id in the json or in the url or does it matter?
# ??? Should this use the id in the json or in the url or does it matter?
...
@@ -118,7 +118,7 @@ def delete_course_update(location, update, passed_id):
...
@@ -118,7 +118,7 @@ def delete_course_update(location, update, passed_id):
course_html_parsed
.
remove
(
element_to_delete
)
course_html_parsed
.
remove
(
element_to_delete
)
# update db record
# update db record
course_updates
.
definition
[
'data'
]
=
etree
.
tostring
(
course_html_parsed
)
course_updates
.
definition
[
'data'
]
=
html
.
tostring
(
course_html_parsed
)
store
=
modulestore
(
'direct'
)
store
=
modulestore
(
'direct'
)
store
.
update_item
(
location
,
course_updates
.
definition
[
'data'
])
store
.
update_item
(
location
,
course_updates
.
definition
[
'data'
])
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment