Commit 1162dbc1 by Diana Huang

Enable VERIFY_XSS checking by default.

parent 9f1971ce
...@@ -18,7 +18,7 @@ class TestPaverBokChoyCmd(unittest.TestCase): ...@@ -18,7 +18,7 @@ class TestPaverBokChoyCmd(unittest.TestCase):
Paver Bok Choy Command test cases Paver Bok Choy Command test cases
""" """
def _expected_command(self, name, store=None, verify_xss=False): def _expected_command(self, name, store=None, verify_xss=True):
""" """
Returns the command that is expected to be run for the given test spec Returns the command that is expected to be run for the given test spec
and store. and store.
...@@ -101,11 +101,11 @@ class TestPaverBokChoyCmd(unittest.TestCase): ...@@ -101,11 +101,11 @@ class TestPaverBokChoyCmd(unittest.TestCase):
self.assertEqual(suite.cmd, self._expected_command(name=name, verify_xss=True)) self.assertEqual(suite.cmd, self._expected_command(name=name, verify_xss=True))
def test_verify_xss_env_var(self): def test_verify_xss_env_var(self):
self.env_var_override.set('VERIFY_XSS', 'True') self.env_var_override.set('VERIFY_XSS', 'False')
with self.env_var_override: with self.env_var_override:
suite = BokChoyTestSuite('') suite = BokChoyTestSuite('')
name = 'tests' name = 'tests'
self.assertEqual(suite.cmd, self._expected_command(name=name, verify_xss=True)) self.assertEqual(suite.cmd, self._expected_command(name=name, verify_xss=False))
def test_test_dir(self): def test_test_dir(self):
test_dir = 'foo' test_dir = 'foo'
......
...@@ -58,7 +58,7 @@ class BokChoyTestSuite(TestSuite): ...@@ -58,7 +58,7 @@ class BokChoyTestSuite(TestSuite):
self.default_store = kwargs.get('default_store', None) self.default_store = kwargs.get('default_store', None)
self.verbosity = kwargs.get('verbosity', DEFAULT_VERBOSITY) self.verbosity = kwargs.get('verbosity', DEFAULT_VERBOSITY)
self.num_processes = kwargs.get('num_processes', DEFAULT_NUM_PROCESSES) self.num_processes = kwargs.get('num_processes', DEFAULT_NUM_PROCESSES)
self.verify_xss = kwargs.get('verify_xss', os.environ.get('VERIFY_XSS', False)) self.verify_xss = kwargs.get('verify_xss', os.environ.get('VERIFY_XSS', True))
self.extra_args = kwargs.get('extra_args', '') self.extra_args = kwargs.get('extra_args', '')
self.har_dir = self.log_dir / 'hars' self.har_dir = self.log_dir / 'hars'
self.a11y_file = Env.BOK_CHOY_A11Y_CUSTOM_RULES_FILE self.a11y_file = Env.BOK_CHOY_A11Y_CUSTOM_RULES_FILE
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment