Skip to content

E
edx-platform
Commit 1122cdb2 by David Ormsbee
Options

Added more comments in response to code review.

parent 051339af
Showing with 9 additions and 7 deletions
common/lib/xmodule/xmodule/modulestore/__init__.py
...@@ -346,8 +346,8 @@ class ModuleStore(object): ...@@ -346,8 +346,8 @@ class ModuleStore(object):
raise NotImplementedError raise NotImplementedError
def get_parent_locations(self, location, course_id): def get_parent_locations(self, location, course_id):
'''Find all locations that are the parents of this location. Needed '''Find all locations that are the parents of this location in this
for path_to_location(). course. Needed for path_to_location().
returns an iterable of things that can be passed to Location. returns an iterable of things that can be passed to Location.
''' '''
......
common/lib/xmodule/xmodule/modulestore/mongo.py
...@@ -310,8 +310,8 @@ class MongoModuleStore(ModuleStoreBase): ...@@ -310,8 +310,8 @@ class MongoModuleStore(ModuleStoreBase):
self._update_single_item(location, {'metadata': metadata}) self._update_single_item(location, {'metadata': metadata})
def get_parent_locations(self, location, course_id): def get_parent_locations(self, location, course_id):
'''Find all locations that are the parents of this location. Needed '''Find all locations that are the parents of this location in this
for path_to_location(). course. Needed for path_to_location().
If there is no data at location in this modulestore, raise If there is no data at location in this modulestore, raise
ItemNotFoundError. ItemNotFoundError.
......
common/lib/xmodule/xmodule/modulestore/xml.py
...@@ -279,7 +279,9 @@ class XMLModuleStore(ModuleStoreBase): ...@@ -279,7 +279,9 @@ class XMLModuleStore(ModuleStoreBase):
# If we are specifically asked for missing courses, that should # If we are specifically asked for missing courses, that should
# be an error. If we are asked for "all" courses, find the ones # be an error. If we are asked for "all" courses, find the ones
# that have a course.xml # that have a course.xml. We sort the dirs in alpha order so we always
# read things in the same order (OS differences in load order have
# bitten us in the past.)
if course_dirs is None: if course_dirs is None:
course_dirs = sorted([d for d in os.listdir(self.data_dir) if course_dirs = sorted([d for d in os.listdir(self.data_dir) if
os.path.exists(self.data_dir / d / "course.xml")]) os.path.exists(self.data_dir / d / "course.xml")])
...@@ -542,8 +544,8 @@ class XMLModuleStore(ModuleStoreBase): ...@@ -542,8 +544,8 @@ class XMLModuleStore(ModuleStoreBase):
raise NotImplementedError("XMLModuleStores are read-only") raise NotImplementedError("XMLModuleStores are read-only")
def get_parent_locations(self, location, course_id): def get_parent_locations(self, location, course_id):
'''Find all locations that are the parents of this location. Needed '''Find all locations that are the parents of this location in this
for path_to_location(). course. Needed for path_to_location().
If there is no data at location in this modulestore, raise If there is no data at location in this modulestore, raise
ItemNotFoundError. ItemNotFoundError.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment