Commit 10d2e818 by clrux

Merge pull request #10866 from edx/clrux/ac-245

Fix: correcting play/skip icon for bumper
parents ad95413c 4161ae99
...@@ -25,12 +25,6 @@ ...@@ -25,12 +25,6 @@
expect($('.video_control.play')).toExist(); expect($('.video_control.play')).toExist();
}); });
it('add ARIA attributes to play control', function () {
expect($('.video_control.play')).toHaveAttrs({
'aria-disabled': 'false'
});
});
it('can update state on play', function () { it('can update state on play', function () {
state.el.trigger('play'); state.el.trigger('play');
expect($('.video_control.play')).not.toExist(); expect($('.video_control.play')).not.toExist();
......
...@@ -30,13 +30,6 @@ ...@@ -30,13 +30,6 @@
expect($('.skip-control')).toExist(); expect($('.skip-control')).toExist();
}); });
it('add ARIA attributes to play control', function () {
state.el.trigger('play');
expect($('.skip-control')).toHaveAttrs({
'aria-disabled': 'false'
});
});
it('can skip the video on click', function () { it('can skip the video on click', function () {
spyOn(state.bumperState.videoBumper, 'skipAndDoNotShowAgain'); spyOn(state.bumperState.videoBumper, 'skipAndDoNotShowAgain');
state.el.trigger('play'); state.el.trigger('play');
......
...@@ -25,9 +25,9 @@ define('video/09_play_skip_control.js', [], function() { ...@@ -25,9 +25,9 @@ define('video/09_play_skip_control.js', [], function() {
PlaySkipControl.prototype = { PlaySkipControl.prototype = {
template: [ template: [
'<button class="control video_control play play-skip-control" aria-disabled="false">', '<button class="control video_control play play-skip-control">',
'<span class="icon-fallback-img">', '<span class="icon-fallback-img">',
'<span class="icon icon-play" aria-hidden="true"></span>', '<span class="icon fa fa-play" aria-hidden="true"></span>',
'<span class="text control-text">', '<span class="text control-text">',
gettext('Play'), gettext('Play'),
'</span>', '</span>',
...@@ -79,8 +79,8 @@ define('video/09_play_skip_control.js', [], function() { ...@@ -79,8 +79,8 @@ define('video/09_play_skip_control.js', [], function() {
.removeClass('play') .removeClass('play')
.addClass('skip') .addClass('skip')
.find('.icon') .find('.icon')
.removeClass('icon-play') .removeClass('fa-play')
.addClass('icon-step-forward') .addClass('fa-step-forward')
.find('.control-text') .find('.control-text')
.text(gettext('Skip')); .text(gettext('Skip'));
// Disable possibility to pause the video. // Disable possibility to pause the video.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment