Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
0f17d8c9
Commit
0f17d8c9
authored
Feb 23, 2015
by
Will Daly
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Preserve enrollment_action and course_id querystring params in header 'Sign In' button
parent
0f19d1fc
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
25 additions
and
0 deletions
+25
-0
lms/djangoapps/student_account/test/test_views.py
+20
-0
lms/djangoapps/student_account/views.py
+5
-0
No files found.
lms/djangoapps/student_account/test/test_views.py
View file @
0f17d8c9
...
...
@@ -408,6 +408,26 @@ class StudentAccountLoginAndRegistrationTest(UrlResetMixin, ModuleStoreTestCase)
response
=
self
.
client
.
get
(
reverse
(
url_name
))
self
.
assertRedirects
(
response
,
reverse
(
"dashboard"
))
@ddt.data
(
(
False
,
"account_login"
),
(
False
,
"account_login"
),
(
True
,
"account_login"
),
(
True
,
"account_register"
),
)
@ddt.unpack
def
test_login_and_registration_form_signin_preserves_params
(
self
,
is_edx_domain
,
url_name
):
params
=
{
'enrollment_action'
:
'enroll'
,
'course_id'
:
'edX/DemoX/Demo_Course'
}
with
mock
.
patch
.
dict
(
settings
.
FEATURES
,
{
'IS_EDX_DOMAIN'
:
is_edx_domain
}):
response
=
self
.
client
.
get
(
reverse
(
url_name
),
params
)
# The response should have a "Sign In" button with the URL
# that preserves the querystring params
self
.
assertContains
(
response
,
"login?course_id=edX
%2
FDemoX
%2
FDemo_Course&enrollment_action=enroll"
)
@mock.patch.dict
(
settings
.
FEATURES
,
{
"ENABLE_THIRD_PARTY_AUTH"
:
False
})
@ddt.data
(
"account_login"
,
"account_register"
)
def
test_third_party_auth_disabled
(
self
,
url_name
):
...
...
lms/djangoapps/student_account/views.py
View file @
0f17d8c9
...
...
@@ -114,6 +114,11 @@ def login_and_registration_form(request, initial_mode="login"):
'login_form_desc'
:
form_descriptions
[
'login'
],
'registration_form_desc'
:
form_descriptions
[
'registration'
],
'password_reset_form_desc'
:
form_descriptions
[
'password_reset'
],
# We need to pass these parameters so that the header's
# "Sign In" button preserves the querystring params.
'enrollment_action'
:
request
.
GET
.
get
(
'enrollment_action'
),
'course_id'
:
request
.
GET
.
get
(
'course_id'
)
}
return
render_to_response
(
'student_account/login_and_register.html'
,
context
)
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment