Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
0d931107
Unverified
Commit
0d931107
authored
Nov 21, 2017
by
Christopher Lee
Committed by
GitHub
Nov 21, 2017
Browse files
Options
Browse Files
Download
Plain Diff
Merge pull request #16589 from edx/clee/LEARNER-2891
Remove uneccessary aria labels in the student dashboard
parents
6457e76d
4e32bd5a
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
with
7 additions
and
9 deletions
+7
-9
common/djangoapps/student/tests/test_verification_status.py
+2
-1
lms/templates/dashboard/_dashboard_course_listing.html
+5
-6
lms/templates/learner_dashboard/_dashboard_navigation_courses.html
+0
-2
No files found.
common/djangoapps/student/tests/test_verification_status.py
View file @
0d931107
...
@@ -371,7 +371,8 @@ class TestCourseVerificationStatus(UrlResetMixin, ModuleStoreTestCase):
...
@@ -371,7 +371,8 @@ class TestCourseVerificationStatus(UrlResetMixin, ModuleStoreTestCase):
# Verify that the correct banner color is rendered
# Verify that the correct banner color is rendered
self
.
assertContains
(
self
.
assertContains
(
response
,
response
,
"<article class=
\"
course {}
\"
>"
.
format
(
self
.
MODE_CLASSES
[
status
])
"<div class=
\"
course {}
\"
aria-labelledby=
\"
course-title-{}
\"
>"
.
format
(
self
.
MODE_CLASSES
[
status
],
self
.
course
.
id
)
)
)
# Verify that the correct copy is rendered on the dashboard
# Verify that the correct copy is rendered on the dashboard
...
...
lms/templates/dashboard/_dashboard_course_listing.html
View file @
0d931107
...
@@ -59,10 +59,9 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
...
@@ -59,10 +59,9 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
lang=
"${course_overview.language}"
lang=
"${course_overview.language}"
%
endif
%
endif
>
>
<
article
class=
"course${mode_class
}"
>
<
div
class=
"course${mode_class}"
aria-labelledby=
"course-title-${enrollment.course_id
}"
>
<
%
course_target =
reverse(course_home_url_name(course_overview.id),
args=
[unicode(course_overview.id)])
%
>
<
%
course_target =
reverse(course_home_url_name(course_overview.id),
args=
[unicode(course_overview.id)])
%
>
<section
class=
"details"
aria-labelledby=
"details-heading-${course_overview.number}"
>
<div
class=
"details"
>
<h2
class=
"hd hd-2 sr"
id=
"details-heading-${course_overview.number}"
>
${_('Course details')}
</h2>
<div
class=
"wrapper-course-image"
aria-hidden=
"true"
>
<div
class=
"wrapper-course-image"
aria-hidden=
"true"
>
% if show_courseware_link:
% if show_courseware_link:
% if not is_course_blocked:
% if not is_course_blocked:
...
@@ -90,7 +89,7 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
...
@@ -90,7 +89,7 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
% endif
% endif
</div>
</div>
<div
class=
"wrapper-course-details"
>
<div
class=
"wrapper-course-details"
>
<h3
class=
"course-title"
>
<h3
class=
"course-title"
id=
"course-title-${enrollment.course_id}"
>
% if show_courseware_link:
% if show_courseware_link:
% if not is_course_blocked:
% if not is_course_blocked:
<a
data-course-key=
"${enrollment.course_id}"
href=
"${course_target}"
>
${course_overview.display_name_with_default}
</a>
<a
data-course-key=
"${enrollment.course_id}"
href=
"${course_target}"
>
${course_overview.display_name_with_default}
</a>
...
@@ -264,7 +263,7 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
...
@@ -264,7 +263,7 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
</div>
</div>
</div>
</div>
</div>
</div>
</
section
>
</
div
>
<footer
class=
"wrapper-messages-primary"
>
<footer
class=
"wrapper-messages-primary"
>
<div
class=
"messages-list"
>
<div
class=
"messages-list"
>
% if related_programs:
% if related_programs:
...
@@ -411,7 +410,7 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
...
@@ -411,7 +410,7 @@ from util.course import get_link_for_about_page, get_encoded_course_sharing_utm_
% endif
% endif
</div>
</div>
</footer>
</footer>
</
article
>
</
div
>
</div>
</div>
</li>
</li>
<script>
<script>
...
...
lms/templates/learner_dashboard/_dashboard_navigation_courses.html
View file @
0d931107
...
@@ -6,5 +6,3 @@ from django.utils.translation import ugettext as _
...
@@ -6,5 +6,3 @@ from django.utils.translation import ugettext as _
<header
class=
"wrapper-header-courses"
>
<header
class=
"wrapper-header-courses"
>
<h2
class=
"header-courses"
>
${_("My Courses")}
</h2>
<h2
class=
"header-courses"
>
${_("My Courses")}
</h2>
</header>
</header>
<h2
class=
"hd hd-2 sr"
id=
"courses-tab"
>
${_('My Courses')}
</h2>
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment