Commit 0d1765e1 by Adam

Merge pull request #11311 from edx/jsa/fail-safe-reverse

ensure reverse migration to delete a specific row won’t fail.
parents d2eaa633 f65c5b9c
# -*- coding: utf-8 -*- # -*- coding: utf-8 -*-
from __future__ import unicode_literals from __future__ import unicode_literals
import logging
from django.db import migrations, models from django.db import migrations
from django.conf import settings from django.conf import settings
from django.contrib.auth.models import User from django.contrib.auth.models import User
logger = logging.getLogger(__name__)
def add_service_user(apps, schema_editor): def add_service_user(apps, schema_editor):
"""Add service user.""" """Add service user."""
user, created = User.objects.get_or_create(username=settings.CREDENTIALS_SERVICE_USERNAME) user, created = User.objects.get_or_create(username=settings.CREDENTIALS_SERVICE_USERNAME)
...@@ -20,8 +24,9 @@ def remove_service_user(apps, schema_editor): ...@@ -20,8 +24,9 @@ def remove_service_user(apps, schema_editor):
"""Remove service user.""" """Remove service user."""
try: try:
User.objects.get(username=settings.CREDENTIALS_SERVICE_USERNAME).delete() User.objects.get(username=settings.CREDENTIALS_SERVICE_USERNAME).delete()
except User.DoesNotExist: except Exception: # pylint: disable=broad-except
return logger.exception('Unexpected error while attempting to delete credentials service user.')
logger.warning('This service user account may need cleanup, but migrations can safely continue.')
class Migration(migrations.Migration): class Migration(migrations.Migration):
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment