Commit 073826ca by Muhammad Ammar Committed by GitHub

Merge pull request #14738 from edx/ammar/fix-flaky-video-js-test

fix flaky video js test
parents 4ef009cf 2628c224
...@@ -41,19 +41,17 @@ ...@@ -41,19 +41,17 @@
expect(state.videoPlayer.player.video.play).toHaveBeenCalled(); expect(state.videoPlayer.player.video.play).toHaveBeenCalled();
}); });
// Failing on master. See TNL-6748. it('player state was changed', function(done) {
xit('player state was changed', function(done) {
jasmine.waitUntil(function() { jasmine.waitUntil(function() {
return state.videoPlayer.player.getPlayerState() === STATUS.PLAYING; return state.videoPlayer.player.getPlayerState() === STATUS.PLAYING;
}).always(done); }).always(done);
}); });
// Flaky. Checking the parameters of calls to onStateChange() will likely be more reliable. it('callback was called', function(done) {
xit('callback was not called', function(done) {
jasmine.waitUntil(function() { jasmine.waitUntil(function() {
return state.videoPlayer.player.getPlayerState() !== STATUS.PAUSED; return state.videoPlayer.player.getPlayerState() !== STATUS.PAUSED;
}).then(function() { }).then(function() {
expect(state.videoPlayer.player.callStateChangeCallback).not.toHaveBeenCalled(); expect(state.videoPlayer.player.callStateChangeCallback).toHaveBeenCalled();
}).always(done); }).always(done);
}); });
}); });
...@@ -105,8 +103,9 @@ ...@@ -105,8 +103,9 @@
jasmine.waitUntil(function() { jasmine.waitUntil(function() {
return state.videoPlayer.player.getPlayerState() !== STATUS.PAUSED; return state.videoPlayer.player.getPlayerState() !== STATUS.PAUSED;
}).then(function() { }).then(function() {
expect(state.videoPlayer.player.getPlayerState()) expect([STATUS.BUFFERING, STATUS.PLAYING]).toContain(
.toBe(STATUS.BUFFERING); state.videoPlayer.player.getPlayerState()
);
}).always(done); }).always(done);
}); });
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment