Skip to content
Projects
Groups
Snippets
Help
This project
Loading...
Sign in / Register
Toggle navigation
E
edx-platform
Overview
Overview
Details
Activity
Cycle Analytics
Repository
Repository
Files
Commits
Branches
Tags
Contributors
Graph
Compare
Charts
Issues
0
Issues
0
List
Board
Labels
Milestones
Merge Requests
0
Merge Requests
0
CI / CD
CI / CD
Pipelines
Jobs
Schedules
Charts
Wiki
Wiki
Snippets
Snippets
Members
Members
Collapse sidebar
Close sidebar
Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards
Open sidebar
edx
edx-platform
Commits
0052eaac
Commit
0052eaac
authored
May 17, 2013
by
David Baumgold
Browse files
Options
Browse Files
Download
Email Patches
Plain Diff
Backbone section: don't save name on validation error
parent
55cd8afe
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
with
8 additions
and
0 deletions
+8
-0
cms/static/coffee/spec/views/section_spec.coffee
+7
-0
cms/static/js/views/section.js
+1
-0
No files found.
cms/static/coffee/spec/views/section_spec.coffee
View file @
0052eaac
...
...
@@ -74,3 +74,10 @@ describe "CMS.Views.SectionEdit", ->
expect
(
@
view
.
showInvalidMessage
).
toHaveBeenCalledWith
(
jasmine
.
any
(
Object
),
"BLARRGH"
,
jasmine
.
any
(
Object
))
expect
(
@
view
.
switchToShowView
).
not
.
toHaveBeenCalled
()
it
"should not save when validation is unsuccessful"
,
->
spyOn
(
@
model
,
'validate'
).
andReturn
(
"BLARRGH"
)
@
view
.
$
(
"input[type=text]"
).
val
(
"changed"
)
@
view
.
$
(
"input[type=submit]"
).
click
()
expect
(
@
model
.
get
(
'name'
)).
not
.
toEqual
(
"changed"
)
cms/static/js/views/section.js
View file @
0052eaac
...
...
@@ -68,6 +68,7 @@ CMS.Views.SectionEdit = Backbone.View.extend({
this
.
showView
.
render
();
},
showInvalidMessage
:
function
(
model
,
error
,
options
)
{
model
.
set
(
"name"
,
model
.
previous
(
"name"
));
var
that
=
this
;
var
msg
=
new
CMS
.
Models
.
ErrorMessage
({
title
:
gettext
(
"Your change could not be saved"
),
...
...
Write
Preview
Markdown
is supported
0%
Try again
or
attach a new file
Attach a file
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Cancel
Please
register
or
sign in
to comment