storage.py
12.5 KB
-
Remove collection of JS bundles for themes. · 255dc792
Comprehensive themes used to allow you to override JS within one of the bundles created for Studio and LMS (specified in the common.py env files). So for instance, the bundle that becomes lms-base-application.js is defined like this: base_application_js = [ 'js/src/utility.js', 'js/src/logger.js', 'js/user_dropdown_v1.js', 'js/dialog_tab_controls.js', 'js/src/string_utils.js', 'js/form.ext.js', 'js/src/ie_shim.js', 'js/src/accessibility_tools.js', 'js/toggle_login_modal.js', 'js/src/lang_edx.js', ] You could not add a custom file to this list in your theme, but if you created a themes/mytheme/lms/static/js/dialog_tab_controls.js, then your theme's version of that file would be wrapped into the bundle, which would be created at {staticfiles}/mytheme/js/lms-base-application.js It doesn't appear that this functionality has seen much use in practice, and it adds minutes to the compile time for sites compiling multiple themes, so this commit removes this capability. It is still possible to create and invoke custom JavaScript that is theme specific, and will compile out to {staticfiles}/mytheme/js -- it's just not possible to override a file that becomes part of the standard Studio/LMS bundles.
David Ormsbee committed