extract_tar.py 2.37 KB
Newer Older
Julian Arni committed
1 2 3 4 5 6 7 8 9
"""
Safe version of tarfile.extractall which does not extract any files that would
be, or symlink to a file that is, outside of the directory extracted in.

Adapted from:
http://stackoverflow.com/questions/10060069/safely-extract-zip-or-tar-using-python
"""
from os.path import abspath, realpath, dirname, join as joinpath
from django.core.exceptions import SuspiciousOperation
10
from django.conf import settings
Julian Arni committed
11 12
import logging

13 14
log = logging.getLogger(__name__)

Julian Arni committed
15 16 17 18 19 20 21

def resolved(rpath):
    """
    Returns the canonical absolute path of `rpath`.
    """
    return realpath(abspath(rpath))

22

Julian Arni committed
23 24 25 26 27 28
def _is_bad_path(path, base):
    """
    Is (the canonical absolute path of) `path` outside `base`?
    """
    return not resolved(joinpath(base, path)).startswith(base)

29

Julian Arni committed
30 31
def _is_bad_link(info, base):
    """
32
    Does the file sym- or hard-link to files outside `base`?
Julian Arni committed
33 34 35 36 37
    """
    # Links are interpreted relative to the directory containing the link
    tip = resolved(joinpath(base, dirname(info.name)))
    return _is_bad_path(info.linkname, base=tip)

38

39
def safemembers(members, base):
Julian Arni committed
40 41 42 43
    """
    Check that all elements of a tar file are safe.
    """

44 45 46 47 48
    base = resolved(base)

    # check that we're not trying to import outside of the data_dir
    if not base.startswith(resolved(settings.DATA_DIR)):
        raise SuspiciousOperation("Attempted to import course outside of data dir")
Julian Arni committed
49 50 51 52 53 54

    for finfo in members:
        if _is_bad_path(finfo.name, base):
            log.debug("File %r is blocked (illegal path)", finfo.name)
            raise SuspiciousOperation("Illegal path")
        elif finfo.issym() and _is_bad_link(finfo, base):
55
            log.debug("File %r is blocked: Hard link to %r", finfo.name, finfo.linkname)
Julian Arni committed
56 57 58
            raise SuspiciousOperation("Hard link")
        elif finfo.islnk() and _is_bad_link(finfo, base):
            log.debug("File %r is blocked: Symlink to %r", finfo.name,
59
                      finfo.linkname)
Julian Arni committed
60 61 62
            raise SuspiciousOperation("Symlink")
        elif finfo.isdev():
            log.debug("File %r is blocked: FIFO, device or character file",
63
                      finfo.name)
Julian Arni committed
64 65 66 67
            raise SuspiciousOperation("Dev file")

    return members

68

Adam Palay committed
69
def safetar_extractall(tar_file, path=".", members=None):  # pylint: disable=unused-argument
Julian Arni committed
70
    """
71
    Safe version of `tar_file.extractall()`.
Julian Arni committed
72
    """
73
    return tar_file.extractall(path, safemembers(tar_file, path))