tests.py 41 KB
Newer Older
1
import logging
2
import json
3

4
from django.test.client import Client, RequestFactory
5
from django.test.utils import override_settings
6
from django.contrib.auth.models import User
7
from django.core.management import call_command
8
from django.core.urlresolvers import reverse
9
from mock import patch, ANY, Mock
10
from nose.tools import assert_true, assert_equal  # pylint: disable=no-name-in-module
11
from opaque_keys.edx.locations import SlashSeparatedCourseKey
12

13
from xmodule.modulestore.tests.django_utils import TEST_DATA_MOCK_MODULESTORE
14
from django_comment_client.base import views
15
from django_comment_client.tests.group_id import CohortedTopicGroupIdTestMixin, NonCohortedTopicGroupIdTestMixin, GroupIdAssertionMixin
16
from django_comment_client.tests.utils import CohortedContentTestCase
17
from django_comment_client.tests.unicode import UnicodeTestMixin
18
from django_comment_common.models import Role
19 20 21 22 23
from django_comment_common.utils import seed_permissions_roles
from student.tests.factories import CourseEnrollmentFactory, UserFactory
from util.testing import UrlResetMixin
from xmodule.modulestore.tests.factories import CourseFactory
from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
24

25

26 27
log = logging.getLogger(__name__)

28
CS_PREFIX = "http://localhost:4567/api/v1"
29

30
# pylint: disable=missing-docstring
muhammad-ammar committed
31

32 33

class MockRequestSetupMixin(object):
34 35
    def _create_response_mock(self, data):
        return Mock(text=json.dumps(data), json=Mock(return_value=data))
36

37
    def _set_mock_request_data(self, mock_request, data):
38
        mock_request.return_value = self._create_response_mock(data)
39 40


41
@patch('lms.lib.comment_client.utils.requests.request')
42
class CreateThreadGroupIdTestCase(
43
        MockRequestSetupMixin,
44 45 46 47 48 49 50
        CohortedContentTestCase,
        CohortedTopicGroupIdTestMixin,
        NonCohortedTopicGroupIdTestMixin
):
    cs_endpoint = "/threads"

    def call_view(self, mock_request, commentable_id, user, group_id, pass_group_id=True):
51
        self._set_mock_request_data(mock_request, {})
52 53 54 55 56 57 58 59 60 61 62 63 64
        mock_request.return_value.status_code = 200
        request_data = {"body": "body", "title": "title", "thread_type": "discussion"}
        if pass_group_id:
            request_data["group_id"] = group_id
        request = RequestFactory().post("dummy_url", request_data)
        request.user = user
        request.view_name = "create_thread"

        return views.create_thread(
            request,
            course_id=self.course.id.to_deprecated_string(),
            commentable_id=commentable_id
        )
65

66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164
    def test_group_info_in_response(self, mock_request):
        response = self.call_view(
            mock_request,
            "cohorted_topic",
            self.student,
            None
        )
        self._assert_json_response_contains_group_info(response)


@patch('lms.lib.comment_client.utils.requests.request')
class ThreadActionGroupIdTestCase(
        MockRequestSetupMixin,
        CohortedContentTestCase,
        GroupIdAssertionMixin
):
    def call_view(
            self,
            view_name,
            mock_request,
            user=None,
            post_params=None,
            view_args=None
    ):
        self._set_mock_request_data(
            mock_request,
            {
                "user_id": str(self.student.id),
                "group_id": self.student_cohort.id,
                "closed": False,
                "type": "thread"
            }
        )
        mock_request.return_value.status_code = 200
        request = RequestFactory().post("dummy_url", post_params or {})
        request.user = user or self.student
        request.view_name = view_name

        return getattr(views, view_name)(
            request,
            course_id=self.course.id.to_deprecated_string(),
            thread_id="dummy",
            **(view_args or {})
        )

    def test_update(self, mock_request):
        response = self.call_view(
            "update_thread",
            mock_request,
            post_params={"body": "body", "title": "title"}
        )
        self._assert_json_response_contains_group_info(response)

    def test_delete(self, mock_request):
        response = self.call_view("delete_thread", mock_request)
        self._assert_json_response_contains_group_info(response)

    def test_vote(self, mock_request):
        response = self.call_view(
            "vote_for_thread",
            mock_request,
            view_args={"value": "up"}
        )
        self._assert_json_response_contains_group_info(response)
        response = self.call_view("undo_vote_for_thread", mock_request)
        self._assert_json_response_contains_group_info(response)

    def test_flag(self, mock_request):
        response = self.call_view("flag_abuse_for_thread", mock_request)
        self._assert_json_response_contains_group_info(response)
        response = self.call_view("un_flag_abuse_for_thread", mock_request)
        self._assert_json_response_contains_group_info(response)

    def test_pin(self, mock_request):
        response = self.call_view(
            "pin_thread",
            mock_request,
            user=self.moderator
        )
        self._assert_json_response_contains_group_info(response)
        response = self.call_view(
            "un_pin_thread",
            mock_request,
            user=self.moderator
        )
        self._assert_json_response_contains_group_info(response)

    def test_openclose(self, mock_request):
        response = self.call_view(
            "openclose_thread",
            mock_request,
            user=self.moderator
        )
        self._assert_json_response_contains_group_info(
            response,
            lambda d: d['content']
        )


165
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
166
@patch('lms.lib.comment_client.utils.requests.request')
167
class ViewsTestCase(UrlResetMixin, ModuleStoreTestCase, MockRequestSetupMixin):
168

169
    @patch.dict("django.conf.settings.FEATURES", {"ENABLE_DISCUSSION_SERVICE": True})
170
    def setUp(self):
171

172 173
        # Patching the ENABLE_DISCUSSION_SERVICE value affects the contents of urls.py,
        # so we need to call super.setUp() which reloads urls.py (because
174
        # of the UrlResetMixin)
175
        super(ViewsTestCase, self).setUp(create_user=False)
176

177
        # create a course
polesye committed
178 179 180 181 182
        self.course = CourseFactory.create(
            org='MITx', course='999',
            discussion_topics={"Some Topic": {"id": "some_topic"}},
            display_name='Robot Super Course',
        )
183 184
        self.course_id = self.course.id
        # seed the forums permissions and roles
185
        call_command('seed_permissions_roles', self.course_id.to_deprecated_string())
186

187 188 189 190 191 192 193 194 195 196 197 198 199 200 201
        # Patch the comment client user save method so it does not try
        # to create a new cc user when creating a django user
        with patch('student.models.cc.User.save'):
            uname = 'student'
            email = 'student@edx.org'
            password = 'test'

            # Create the user and make them active so we can log them in.
            self.student = User.objects.create_user(uname, email, password)
            self.student.is_active = True
            self.student.save()

            # Enroll the student in the course
            CourseEnrollmentFactory(user=self.student,
                                    course_id=self.course_id)
202

203 204
            self.client = Client()
            assert_true(self.client.login(username='student', password='test'))
205

206 207
    def test_create_thread(self, mock_request):
        mock_request.return_value.status_code = 200
208
        self._set_mock_request_data(mock_request, {
209
            "thread_type": "discussion",
210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237
            "title": "Hello",
            "body": "this is a post",
            "course_id": "MITx/999/Robot_Super_Course",
            "anonymous": False,
            "anonymous_to_peers": False,
            "commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
            "created_at": "2013-05-10T18:53:43Z",
            "updated_at": "2013-05-10T18:53:43Z",
            "at_position_list": [],
            "closed": False,
            "id": "518d4237b023791dca00000d",
            "user_id": "1",
            "username": "robot",
            "votes": {
                "count": 0,
                "up_count": 0,
                "down_count": 0,
                "point": 0
            },
            "abuse_flaggers": [],
            "type": "thread",
            "group_id": None,
            "pinned": False,
            "endorsed": False,
            "unread_comments_count": 0,
            "read": False,
            "comments_count": 0,
        })
238 239 240 241 242 243 244 245
        thread = {
            "thread_type": "discussion",
            "body": ["this is a post"],
            "anonymous_to_peers": ["false"],
            "auto_subscribe": ["false"],
            "anonymous": ["false"],
            "title": ["Hello"],
        }
246
        url = reverse('create_thread', kwargs={'commentable_id': 'i4x-MITx-999-course-Robot_Super_Course',
247
                                               'course_id': self.course_id.to_deprecated_string()})
248
        response = self.client.post(url, data=thread)
249
        assert_true(mock_request.called)
250 251
        mock_request.assert_called_with(
            'post',
252
            '{prefix}/i4x-MITx-999-course-Robot_Super_Course/threads'.format(prefix=CS_PREFIX),
253
            data={
254
                'thread_type': 'discussion',
255 256 257 258
                'body': u'this is a post',
                'anonymous_to_peers': False, 'user_id': 1,
                'title': u'Hello',
                'commentable_id': u'i4x-MITx-999-course-Robot_Super_Course',
259 260
                'anonymous': False,
                'course_id': u'MITx/999/Robot_Super_Course',
261
            },
262
            params={'request_id': ANY},
263
            headers=ANY,
264 265
            timeout=5
        )
266
        assert_equal(response.status_code, 200)
267

268
    def test_delete_comment(self, mock_request):
269
        self._set_mock_request_data(mock_request, {
270 271 272 273 274 275 276
            "user_id": str(self.student.id),
            "closed": False,
        })
        test_comment_id = "test_comment_id"
        request = RequestFactory().post("dummy_url", {"id": test_comment_id})
        request.user = self.student
        request.view_name = "delete_comment"
277
        response = views.delete_comment(request, course_id=self.course.id.to_deprecated_string(), comment_id=test_comment_id)
278 279 280 281 282 283 284

        self.assertEqual(response.status_code, 200)
        self.assertTrue(mock_request.called)
        args = mock_request.call_args[0]
        self.assertEqual(args[0], "delete")
        self.assertTrue(args[1].endswith("/{}".format(test_comment_id)))

285
    def _setup_mock_request(self, mock_request, include_depth=False):
286
        """
287 288
        Ensure that mock_request returns the data necessary to make views
        function correctly
289 290
        """
        mock_request.return_value.status_code = 200
291
        data = {
292 293 294
            "user_id": str(self.student.id),
            "closed": False,
        }
295 296
        if include_depth:
            data["depth"] = 0
297
        self._set_mock_request_data(mock_request, data)
298 299 300 301 302 303 304 305

    def _test_request_error(self, view_name, view_kwargs, data, mock_request):
        """
        Submit a request against the given view with the given data and ensure
        that the result is a 400 error and that no data was posted using
        mock_request
        """
        self._setup_mock_request(mock_request, include_depth=(view_name == "create_sub_comment"))
306 307 308 309 310 311 312 313 314

        response = self.client.post(reverse(view_name, kwargs=view_kwargs), data=data)
        self.assertEqual(response.status_code, 400)
        for call in mock_request.call_args_list:
            self.assertEqual(call[0][0].lower(), "get")

    def test_create_thread_no_title(self, mock_request):
        self._test_request_error(
            "create_thread",
315
            {"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
316 317 318 319 320 321 322
            {"body": "foo"},
            mock_request
        )

    def test_create_thread_empty_title(self, mock_request):
        self._test_request_error(
            "create_thread",
323
            {"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
324 325 326 327 328 329 330
            {"body": "foo", "title": " "},
            mock_request
        )

    def test_create_thread_no_body(self, mock_request):
        self._test_request_error(
            "create_thread",
331
            {"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
332 333 334 335 336 337 338
            {"title": "foo"},
            mock_request
        )

    def test_create_thread_empty_body(self, mock_request):
        self._test_request_error(
            "create_thread",
339
            {"commentable_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
340 341 342 343 344 345 346
            {"body": " ", "title": "foo"},
            mock_request
        )

    def test_update_thread_no_title(self, mock_request):
        self._test_request_error(
            "update_thread",
347
            {"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
348 349 350 351 352 353 354
            {"body": "foo"},
            mock_request
        )

    def test_update_thread_empty_title(self, mock_request):
        self._test_request_error(
            "update_thread",
355
            {"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
356 357 358 359 360 361 362
            {"body": "foo", "title": " "},
            mock_request
        )

    def test_update_thread_no_body(self, mock_request):
        self._test_request_error(
            "update_thread",
363
            {"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
364 365 366 367 368 369 370
            {"title": "foo"},
            mock_request
        )

    def test_update_thread_empty_body(self, mock_request):
        self._test_request_error(
            "update_thread",
371
            {"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
372 373 374 375
            {"body": " ", "title": "foo"},
            mock_request
        )

polesye committed
376 377 378 379 380 381 382 383 384
    def test_update_thread_course_topic(self, mock_request):
        self._setup_mock_request(mock_request)
        response = self.client.post(
            reverse("update_thread", kwargs={"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()}),
            data={"body": "foo", "title": "foo", "commentable_id": "some_topic"}
        )
        self.assertEqual(response.status_code, 200)

    @patch('django_comment_client.base.views.get_discussion_categories_ids', return_value=["test_commentable"])
385 386 387 388 389 390 391 392
    def test_update_thread_wrong_commentable_id(self, mock_get_discussion_id_map, mock_request):
        self._test_request_error(
            "update_thread",
            {"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
            {"body": "foo", "title": "foo", "commentable_id": "wrong_commentable"},
            mock_request
        )

393 394 395
    def test_create_comment_no_body(self, mock_request):
        self._test_request_error(
            "create_comment",
396
            {"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
397 398 399 400 401 402 403
            {},
            mock_request
        )

    def test_create_comment_empty_body(self, mock_request):
        self._test_request_error(
            "create_comment",
404
            {"thread_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
405 406 407 408 409 410 411
            {"body": " "},
            mock_request
        )

    def test_create_sub_comment_no_body(self, mock_request):
        self._test_request_error(
            "create_sub_comment",
412
            {"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
413 414 415 416 417 418 419
            {},
            mock_request
        )

    def test_create_sub_comment_empty_body(self, mock_request):
        self._test_request_error(
            "create_sub_comment",
420
            {"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
421 422 423 424 425 426 427
            {"body": " "},
            mock_request
        )

    def test_update_comment_no_body(self, mock_request):
        self._test_request_error(
            "update_comment",
428
            {"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
429 430 431 432 433 434 435
            {},
            mock_request
        )

    def test_update_comment_empty_body(self, mock_request):
        self._test_request_error(
            "update_comment",
436
            {"comment_id": "dummy", "course_id": self.course_id.to_deprecated_string()},
437 438 439 440
            {"body": " "},
            mock_request
        )

441 442 443 444 445 446 447 448
    def test_update_comment_basic(self, mock_request):
        self._setup_mock_request(mock_request)
        comment_id = "test_comment_id"
        updated_body = "updated body"

        response = self.client.post(
            reverse(
                "update_comment",
449
                kwargs={"course_id": self.course_id.to_deprecated_string(), "comment_id": comment_id}
450 451 452 453 454 455 456 457 458 459 460 461 462 463
            ),
            data={"body": updated_body}
        )

        self.assertEqual(response.status_code, 200)
        mock_request.assert_called_with(
            "put",
            "{prefix}/comments/{comment_id}".format(prefix=CS_PREFIX, comment_id=comment_id),
            headers=ANY,
            params=ANY,
            timeout=ANY,
            data={"body": updated_body}
        )

464 465 466 467 468 469 470
    def test_flag_thread_open(self, mock_request):
        self.flag_thread(mock_request, False)

    def test_flag_thread_close(self, mock_request):
        self.flag_thread(mock_request, True)

    def flag_thread(self, mock_request, is_closed):
471
        mock_request.return_value.status_code = 200
472 473 474 475 476 477 478 479 480 481
        self._set_mock_request_data(mock_request, {
            "title": "Hello",
            "body": "this is a post",
            "course_id": "MITx/999/Robot_Super_Course",
            "anonymous": False,
            "anonymous_to_peers": False,
            "commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
            "created_at": "2013-05-10T18:53:43Z",
            "updated_at": "2013-05-10T18:53:43Z",
            "at_position_list": [],
482
            "closed": is_closed,
483
            "id": "518d4237b023791dca00000d",
484
            "user_id": "1", "username": "robot",
485 486 487 488 489 490 491 492 493 494 495 496 497 498 499
            "votes": {
                "count": 0,
                "up_count": 0,
                "down_count": 0,
                "point": 0
            },
            "abuse_flaggers": [1],
            "type": "thread",
            "group_id": None,
            "pinned": False,
            "endorsed": False,
            "unread_comments_count": 0,
            "read": False,
            "comments_count": 0,
        })
500
        url = reverse('flag_abuse_for_thread', kwargs={'thread_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
501
        response = self.client.post(url)
502
        assert_true(mock_request.called)
503

504 505
        call_list = [
            (
506
                ('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
507
                {
508 509
                    'data': None,
                    'params': {'mark_as_read': True, 'request_id': ANY},
510
                    'headers': ANY,
511 512 513 514
                    'timeout': 5
                }
            ),
            (
515
                ('put', '{prefix}/threads/518d4237b023791dca00000d/abuse_flag'.format(prefix=CS_PREFIX)),
516 517
                {
                    'data': {'user_id': '1'},
518
                    'params': {'request_id': ANY},
519
                    'headers': ANY,
520 521 522 523
                    'timeout': 5
                }
            ),
            (
524
                ('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
525
                {
526 527
                    'data': None,
                    'params': {'mark_as_read': True, 'request_id': ANY},
528
                    'headers': ANY,
529 530 531 532
                    'timeout': 5
                }
            )
        ]
533

534
        assert_equal(call_list, mock_request.call_args_list)
535 536

        assert_equal(response.status_code, 200)
537

538 539 540 541 542 543 544
    def test_un_flag_thread_open(self, mock_request):
        self.un_flag_thread(mock_request, False)

    def test_un_flag_thread_close(self, mock_request):
        self.un_flag_thread(mock_request, True)

    def un_flag_thread(self, mock_request, is_closed):
545
        mock_request.return_value.status_code = 200
546 547 548 549 550 551 552 553 554 555
        self._set_mock_request_data(mock_request, {
            "title": "Hello",
            "body": "this is a post",
            "course_id": "MITx/999/Robot_Super_Course",
            "anonymous": False,
            "anonymous_to_peers": False,
            "commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
            "created_at": "2013-05-10T18:53:43Z",
            "updated_at": "2013-05-10T18:53:43Z",
            "at_position_list": [],
556
            "closed": is_closed,
557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574
            "id": "518d4237b023791dca00000d",
            "user_id": "1",
            "username": "robot",
            "votes": {
                "count": 0,
                "up_count": 0,
                "down_count": 0,
                "point": 0
            },
            "abuse_flaggers": [],
            "type": "thread",
            "group_id": None,
            "pinned": False,
            "endorsed": False,
            "unread_comments_count": 0,
            "read": False,
            "comments_count": 0
        })
575
        url = reverse('un_flag_abuse_for_thread', kwargs={'thread_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
576 577 578
        response = self.client.post(url)
        assert_true(mock_request.called)

579 580
        call_list = [
            (
581
                ('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
582
                {
583 584
                    'data': None,
                    'params': {'mark_as_read': True, 'request_id': ANY},
585
                    'headers': ANY,
586 587 588 589
                    'timeout': 5
                }
            ),
            (
590
                ('put', '{prefix}/threads/518d4237b023791dca00000d/abuse_unflag'.format(prefix=CS_PREFIX)),
591 592
                {
                    'data': {'user_id': '1'},
593
                    'params': {'request_id': ANY},
594
                    'headers': ANY,
595 596 597 598
                    'timeout': 5
                }
            ),
            (
599
                ('get', '{prefix}/threads/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
600
                {
601 602
                    'data': None,
                    'params': {'mark_as_read': True, 'request_id': ANY},
603
                    'headers': ANY,
604 605 606 607
                    'timeout': 5
                }
            )
        ]
608

609
        assert_equal(call_list, mock_request.call_args_list)
610 611 612

        assert_equal(response.status_code, 200)

613 614 615 616 617 618 619
    def test_flag_comment_open(self, mock_request):
        self.flag_comment(mock_request, False)

    def test_flag_comment_close(self, mock_request):
        self.flag_comment(mock_request, True)

    def flag_comment(self, mock_request, is_closed):
620
        mock_request.return_value.status_code = 200
621 622 623 624 625 626 627 628 629
        self._set_mock_request_data(mock_request, {
            "body": "this is a comment",
            "course_id": "MITx/999/Robot_Super_Course",
            "anonymous": False,
            "anonymous_to_peers": False,
            "commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
            "created_at": "2013-05-10T18:53:43Z",
            "updated_at": "2013-05-10T18:53:43Z",
            "at_position_list": [],
630
            "closed": is_closed,
631 632 633 634 635 636 637 638 639 640 641 642 643
            "id": "518d4237b023791dca00000d",
            "user_id": "1",
            "username": "robot",
            "votes": {
                "count": 0,
                "up_count": 0,
                "down_count": 0,
                "point": 0
            },
            "abuse_flaggers": [1],
            "type": "comment",
            "endorsed": False
        })
644
        url = reverse('flag_abuse_for_comment', kwargs={'comment_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
645 646 647
        response = self.client.post(url)
        assert_true(mock_request.called)

648 649
        call_list = [
            (
650
                ('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
651
                {
652 653
                    'data': None,
                    'params': {'request_id': ANY},
654
                    'headers': ANY,
655 656 657 658
                    'timeout': 5
                }
            ),
            (
659
                ('put', '{prefix}/comments/518d4237b023791dca00000d/abuse_flag'.format(prefix=CS_PREFIX)),
660 661
                {
                    'data': {'user_id': '1'},
662
                    'params': {'request_id': ANY},
663
                    'headers': ANY,
664 665 666 667
                    'timeout': 5
                }
            ),
            (
668
                ('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
669
                {
670 671
                    'data': None,
                    'params': {'request_id': ANY},
672
                    'headers': ANY,
673 674 675 676
                    'timeout': 5
                }
            )
        ]
677

678
        assert_equal(call_list, mock_request.call_args_list)
679 680 681

        assert_equal(response.status_code, 200)

682 683 684 685 686 687 688
    def test_un_flag_comment_open(self, mock_request):
        self.un_flag_comment(mock_request, False)

    def test_un_flag_comment_close(self, mock_request):
        self.un_flag_comment(mock_request, True)

    def un_flag_comment(self, mock_request, is_closed):
689
        mock_request.return_value.status_code = 200
690 691 692 693 694 695 696 697 698
        self._set_mock_request_data(mock_request, {
            "body": "this is a comment",
            "course_id": "MITx/999/Robot_Super_Course",
            "anonymous": False,
            "anonymous_to_peers": False,
            "commentable_id": "i4x-MITx-999-course-Robot_Super_Course",
            "created_at": "2013-05-10T18:53:43Z",
            "updated_at": "2013-05-10T18:53:43Z",
            "at_position_list": [],
699
            "closed": is_closed,
700 701 702 703 704 705 706 707 708 709 710 711 712
            "id": "518d4237b023791dca00000d",
            "user_id": "1",
            "username": "robot",
            "votes": {
                "count": 0,
                "up_count": 0,
                "down_count": 0,
                "point": 0
            },
            "abuse_flaggers": [],
            "type": "comment",
            "endorsed": False
        })
713
        url = reverse('un_flag_abuse_for_comment', kwargs={'comment_id': '518d4237b023791dca00000d', 'course_id': self.course_id.to_deprecated_string()})
714 715 716
        response = self.client.post(url)
        assert_true(mock_request.called)

717 718
        call_list = [
            (
719
                ('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
720
                {
721 722
                    'data': None,
                    'params': {'request_id': ANY},
723
                    'headers': ANY,
724 725 726 727
                    'timeout': 5
                }
            ),
            (
728
                ('put', '{prefix}/comments/518d4237b023791dca00000d/abuse_unflag'.format(prefix=CS_PREFIX)),
729 730
                {
                    'data': {'user_id': '1'},
731
                    'params': {'request_id': ANY},
732
                    'headers': ANY,
733 734 735 736
                    'timeout': 5
                }
            ),
            (
737
                ('get', '{prefix}/comments/518d4237b023791dca00000d'.format(prefix=CS_PREFIX)),
738
                {
739 740
                    'data': None,
                    'params': {'request_id': ANY},
741
                    'headers': ANY,
742 743 744 745
                    'timeout': 5
                }
            )
        ]
746

747
        assert_equal(call_list, mock_request.call_args_list)
748

749
        assert_equal(response.status_code, 200)
750

751

752
@patch("lms.lib.comment_client.utils.requests.request")
753
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
754
class ViewPermissionsTestCase(UrlResetMixin, ModuleStoreTestCase, MockRequestSetupMixin):
755 756 757 758 759 760 761 762 763 764 765 766 767
    @patch.dict("django.conf.settings.FEATURES", {"ENABLE_DISCUSSION_SERVICE": True})
    def setUp(self):
        super(ViewPermissionsTestCase, self).setUp()
        self.password = "test password"
        self.course = CourseFactory.create()
        seed_permissions_roles(self.course.id)
        self.student = UserFactory.create(password=self.password)
        self.moderator = UserFactory.create(password=self.password)
        CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
        CourseEnrollmentFactory(user=self.moderator, course_id=self.course.id)
        self.moderator.roles.add(Role.objects.get(name="Moderator", course_id=self.course.id))

    def test_pin_thread_as_student(self, mock_request):
768
        self._set_mock_request_data(mock_request, {})
769 770
        self.client.login(username=self.student.username, password=self.password)
        response = self.client.post(
771
            reverse("pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
772 773 774 775
        )
        self.assertEqual(response.status_code, 401)

    def test_pin_thread_as_moderator(self, mock_request):
776
        self._set_mock_request_data(mock_request, {})
777 778
        self.client.login(username=self.moderator.username, password=self.password)
        response = self.client.post(
779
            reverse("pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
780 781 782 783
        )
        self.assertEqual(response.status_code, 200)

    def test_un_pin_thread_as_student(self, mock_request):
784
        self._set_mock_request_data(mock_request, {})
785 786
        self.client.login(username=self.student.username, password=self.password)
        response = self.client.post(
787
            reverse("un_pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
788 789 790 791
        )
        self.assertEqual(response.status_code, 401)

    def test_un_pin_thread_as_moderator(self, mock_request):
792
        self._set_mock_request_data(mock_request, {})
793 794
        self.client.login(username=self.moderator.username, password=self.password)
        response = self.client.post(
795
            reverse("un_pin_thread", kwargs={"course_id": self.course.id.to_deprecated_string(), "thread_id": "dummy"})
796 797 798
        )
        self.assertEqual(response.status_code, 200)

799 800 801 802
    def _set_mock_request_thread_and_comment(self, mock_request, thread_data, comment_data):
        def handle_request(*args, **kwargs):
            url = args[1]
            if "/threads/" in url:
803
                return self._create_response_mock(thread_data)
804
            elif "/comments/" in url:
805
                return self._create_response_mock(comment_data)
806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845
            else:
                raise ArgumentError("Bad url to mock request")
        mock_request.side_effect = handle_request

    def test_endorse_response_as_staff(self, mock_request):
        self._set_mock_request_thread_and_comment(
            mock_request,
            {"type": "thread", "thread_type": "question", "user_id": str(self.student.id)},
            {"type": "comment", "thread_id": "dummy"}
        )
        self.client.login(username=self.moderator.username, password=self.password)
        response = self.client.post(
            reverse("endorse_comment", kwargs={"course_id": self.course.id.to_deprecated_string(), "comment_id": "dummy"})
        )
        self.assertEqual(response.status_code, 200)

    def test_endorse_response_as_student(self, mock_request):
        self._set_mock_request_thread_and_comment(
            mock_request,
            {"type": "thread", "thread_type": "question", "user_id": str(self.moderator.id)},
            {"type": "comment", "thread_id": "dummy"}
        )
        self.client.login(username=self.student.username, password=self.password)
        response = self.client.post(
            reverse("endorse_comment", kwargs={"course_id": self.course.id.to_deprecated_string(), "comment_id": "dummy"})
        )
        self.assertEqual(response.status_code, 401)

    def test_endorse_response_as_student_question_author(self, mock_request):
        self._set_mock_request_thread_and_comment(
            mock_request,
            {"type": "thread", "thread_type": "question", "user_id": str(self.student.id)},
            {"type": "comment", "thread_id": "dummy"}
        )
        self.client.login(username=self.student.username, password=self.password)
        response = self.client.post(
            reverse("endorse_comment", kwargs={"course_id": self.course.id.to_deprecated_string(), "comment_id": "dummy"})
        )
        self.assertEqual(response.status_code, 200)

846

847
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
848
class CreateThreadUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
849 850 851 852 853 854 855 856
    def setUp(self):
        self.course = CourseFactory.create()
        seed_permissions_roles(self.course.id)
        self.student = UserFactory.create()
        CourseEnrollmentFactory(user=self.student, course_id=self.course.id)

    @patch('lms.lib.comment_client.utils.requests.request')
    def _test_unicode_data(self, text, mock_request):
857
        self._set_mock_request_data(mock_request, {})
858
        request = RequestFactory().post("dummy_url", {"thread_type": "discussion", "body": text, "title": text})
859 860
        request.user = self.student
        request.view_name = "create_thread"
861
        response = views.create_thread(request, course_id=self.course.id.to_deprecated_string(), commentable_id="test_commentable")
862 863 864 865 866 867 868

        self.assertEqual(response.status_code, 200)
        self.assertTrue(mock_request.called)
        self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
        self.assertEqual(mock_request.call_args[1]["data"]["title"], text)


869
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
870
class UpdateThreadUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
871 872 873 874 875 876
    def setUp(self):
        self.course = CourseFactory.create()
        seed_permissions_roles(self.course.id)
        self.student = UserFactory.create()
        CourseEnrollmentFactory(user=self.student, course_id=self.course.id)

polesye committed
877
    @patch('django_comment_client.base.views.get_discussion_categories_ids', return_value=["test_commentable"])
878
    @patch('lms.lib.comment_client.utils.requests.request')
879
    def _test_unicode_data(self, text, mock_request, mock_get_discussion_id_map):
880
        self._set_mock_request_data(mock_request, {
881 882 883
            "user_id": str(self.student.id),
            "closed": False,
        })
884
        request = RequestFactory().post("dummy_url", {"body": text, "title": text, "thread_type": "question", "commentable_id": "test_commentable"})
885 886
        request.user = self.student
        request.view_name = "update_thread"
887
        response = views.update_thread(request, course_id=self.course.id.to_deprecated_string(), thread_id="dummy_thread_id")
888 889 890 891 892

        self.assertEqual(response.status_code, 200)
        self.assertTrue(mock_request.called)
        self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
        self.assertEqual(mock_request.call_args[1]["data"]["title"], text)
893
        self.assertEqual(mock_request.call_args[1]["data"]["thread_type"], "question")
894
        self.assertEqual(mock_request.call_args[1]["data"]["commentable_id"], "test_commentable")
895 896


897
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
898
class CreateCommentUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
899 900 901 902 903 904 905 906
    def setUp(self):
        self.course = CourseFactory.create()
        seed_permissions_roles(self.course.id)
        self.student = UserFactory.create()
        CourseEnrollmentFactory(user=self.student, course_id=self.course.id)

    @patch('lms.lib.comment_client.utils.requests.request')
    def _test_unicode_data(self, text, mock_request):
907
        self._set_mock_request_data(mock_request, {
908 909 910 911 912
            "closed": False,
        })
        request = RequestFactory().post("dummy_url", {"body": text})
        request.user = self.student
        request.view_name = "create_comment"
913
        response = views.create_comment(request, course_id=self.course.id.to_deprecated_string(), thread_id="dummy_thread_id")
914 915 916 917 918 919

        self.assertEqual(response.status_code, 200)
        self.assertTrue(mock_request.called)
        self.assertEqual(mock_request.call_args[1]["data"]["body"], text)


920
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
921
class UpdateCommentUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
922 923 924 925 926 927 928 929
    def setUp(self):
        self.course = CourseFactory.create()
        seed_permissions_roles(self.course.id)
        self.student = UserFactory.create()
        CourseEnrollmentFactory(user=self.student, course_id=self.course.id)

    @patch('lms.lib.comment_client.utils.requests.request')
    def _test_unicode_data(self, text, mock_request):
930
        self._set_mock_request_data(mock_request, {
931 932 933 934 935 936
            "user_id": str(self.student.id),
            "closed": False,
        })
        request = RequestFactory().post("dummy_url", {"body": text})
        request.user = self.student
        request.view_name = "update_comment"
937
        response = views.update_comment(request, course_id=self.course.id.to_deprecated_string(), comment_id="dummy_comment_id")
938 939 940 941 942 943

        self.assertEqual(response.status_code, 200)
        self.assertTrue(mock_request.called)
        self.assertEqual(mock_request.call_args[1]["data"]["body"], text)


944
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
945
class CreateSubCommentUnicodeTestCase(ModuleStoreTestCase, UnicodeTestMixin, MockRequestSetupMixin):
946 947 948 949 950 951 952 953
    def setUp(self):
        self.course = CourseFactory.create()
        seed_permissions_roles(self.course.id)
        self.student = UserFactory.create()
        CourseEnrollmentFactory(user=self.student, course_id=self.course.id)

    @patch('lms.lib.comment_client.utils.requests.request')
    def _test_unicode_data(self, text, mock_request):
954
        self._set_mock_request_data(mock_request, {
955 956 957 958 959 960
            "closed": False,
            "depth": 1,
        })
        request = RequestFactory().post("dummy_url", {"body": text})
        request.user = self.student
        request.view_name = "create_sub_comment"
961
        response = views.create_sub_comment(request, course_id=self.course.id.to_deprecated_string(), comment_id="dummy_comment_id")
962 963 964 965

        self.assertEqual(response.status_code, 200)
        self.assertTrue(mock_request.called)
        self.assertEqual(mock_request.call_args[1]["data"]["body"], text)
966 967


968
@override_settings(MODULESTORE=TEST_DATA_MOCK_MODULESTORE)
969 970 971 972 973 974 975 976 977 978 979 980 981 982 983 984 985 986 987 988 989 990 991 992 993 994 995 996 997 998 999 1000 1001 1002 1003 1004 1005 1006 1007 1008 1009 1010 1011 1012 1013 1014 1015 1016 1017 1018 1019 1020 1021 1022 1023 1024 1025 1026 1027 1028 1029 1030 1031 1032 1033 1034 1035 1036 1037 1038
class UsersEndpointTestCase(ModuleStoreTestCase, MockRequestSetupMixin):

    def set_post_counts(self, mock_request, threads_count=1, comments_count=1):
        """
        sets up a mock response from the comments service for getting post counts for our other_user
        """
        self._set_mock_request_data(mock_request, {
            "threads_count": threads_count,
            "comments_count": comments_count,
        })

    def setUp(self):
        self.course = CourseFactory.create()
        seed_permissions_roles(self.course.id)
        self.student = UserFactory.create()
        self.enrollment = CourseEnrollmentFactory(user=self.student, course_id=self.course.id)
        self.other_user = UserFactory.create(username="other")
        CourseEnrollmentFactory(user=self.other_user, course_id=self.course.id)

    def make_request(self, method='get', course_id=None, **kwargs):
        course_id = course_id or self.course.id
        request = getattr(RequestFactory(), method)("dummy_url", kwargs)
        request.user = self.student
        request.view_name = "users"
        return views.users(request, course_id=course_id.to_deprecated_string())

    @patch('lms.lib.comment_client.utils.requests.request')
    def test_finds_exact_match(self, mock_request):
        self.set_post_counts(mock_request)
        response = self.make_request(username="other")
        self.assertEqual(response.status_code, 200)
        self.assertEqual(
            json.loads(response.content)["users"],
            [{"id": self.other_user.id, "username": self.other_user.username}]
        )

    @patch('lms.lib.comment_client.utils.requests.request')
    def test_finds_no_match(self, mock_request):
        self.set_post_counts(mock_request)
        response = self.make_request(username="othor")
        self.assertEqual(response.status_code, 200)
        self.assertEqual(json.loads(response.content)["users"], [])

    def test_requires_GET(self):
        response = self.make_request(method='post', username="other")
        self.assertEqual(response.status_code, 405)

    def test_requires_username_param(self):
        response = self.make_request()
        self.assertEqual(response.status_code, 400)
        content = json.loads(response.content)
        self.assertIn("errors", content)
        self.assertNotIn("users", content)

    def test_course_does_not_exist(self):
        course_id = SlashSeparatedCourseKey.from_deprecated_string("does/not/exist")
        response = self.make_request(course_id=course_id, username="other")

        self.assertEqual(response.status_code, 404)
        content = json.loads(response.content)
        self.assertIn("errors", content)
        self.assertNotIn("users", content)

    def test_requires_requestor_enrolled_in_course(self):
        # unenroll self.student from the course.
        self.enrollment.delete()

        response = self.make_request(username="other")
        self.assertEqual(response.status_code, 404)
        content = json.loads(response.content)
1039 1040
        self.assertIn("errors", content)
        self.assertNotIn("users", content)
1041 1042 1043 1044 1045 1046 1047

    @patch('lms.lib.comment_client.utils.requests.request')
    def test_requires_matched_user_has_forum_content(self, mock_request):
        self.set_post_counts(mock_request, 0, 0)
        response = self.make_request(username="other")
        self.assertEqual(response.status_code, 200)
        self.assertEqual(json.loads(response.content)["users"], [])