tests.py 16.1 KB
Newer Older
1
"""
Arthur Barrett committed
2
Unit tests for the notes app.
3 4
"""

5 6
from mock import patch, Mock

7
from opaque_keys.edx.locations import SlashSeparatedCourseKey
8
from django.test import TestCase, RequestFactory
Arthur Barrett committed
9 10 11
from django.test.client import Client
from django.core.urlresolvers import reverse
from django.contrib.auth.models import User
Arthur Barrett committed
12
from django.core.exceptions import ValidationError
Arthur Barrett committed
13 14 15

import json

16 17 18 19
from xmodule.modulestore.tests.django_utils import ModuleStoreTestCase
from xmodule.modulestore.tests.factories import CourseFactory
from courseware.tabs import get_course_tab_list, CourseTab
from student.tests.factories import UserFactory, CourseEnrollmentFactory
20
from notes import utils, api, models
Arthur Barrett committed
21

Arthur Barrett committed
22

23 24
class UtilsTest(ModuleStoreTestCase):
    """ Tests for the notes utils. """
Arthur Barrett committed
25 26
    def setUp(self):
        '''
Arthur Barrett committed
27
        Setup a dummy course-like object with a tabs field that can be
Arthur Barrett committed
28
        accessed via attribute lookup.
Arthur Barrett committed
29
        '''
30
        super(UtilsTest, self).setUp()
31
        self.course = CourseFactory.create()
Arthur Barrett committed
32 33 34 35 36 37 38 39 40 41 42 43 44

    def test_notes_not_enabled(self):
        '''
        Tests that notes are disabled when the course tab configuration does NOT
        contain a tab with type "notes."
        '''
        self.assertFalse(utils.notes_enabled_for_course(self.course))

    def test_notes_enabled(self):
        '''
        Tests that notes are enabled when the course tab configuration contains
        a tab with type "notes."
        '''
45 46 47
        with self.settings(FEATURES={'ENABLE_STUDENT_NOTES': True}):
            self.course.advanced_modules = ["notes"]
            self.assertTrue(utils.notes_enabled_for_course(self.course))
48

49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92

class CourseTabTest(ModuleStoreTestCase):
    """
    Test that the course tab shows up the way we expect.
    """
    def setUp(self):
        '''
        Setup a dummy course-like object with a tabs field that can be
        accessed via attribute lookup.
        '''
        super(CourseTabTest, self).setUp()
        self.course = CourseFactory.create()
        self.user = UserFactory()
        CourseEnrollmentFactory.create(user=self.user, course_id=self.course.id)

    def enable_notes(self):
        """Enable notes and add the tab to the course."""
        self.course.tabs.append(CourseTab.load("notes"))
        self.course.advanced_modules = ["notes"]

    def has_notes_tab(self, course, user):
        """ Returns true if the current course and user have a notes tab, false otherwise. """
        request = RequestFactory().request()
        request.user = user
        all_tabs = get_course_tab_list(request, course)
        return any([tab.name == u'My Notes' for tab in all_tabs])

    def test_course_tab_not_visible(self):
        # module not enabled in the course
        self.assertFalse(self.has_notes_tab(self.course, self.user))

        with self.settings(FEATURES={'ENABLE_STUDENT_NOTES': False}):
            # setting not enabled and the module is not enabled
            self.assertFalse(self.has_notes_tab(self.course, self.user))

            # module is enabled and the setting is not enabled
            self.course.advanced_modules = ["notes"]
            self.assertFalse(self.has_notes_tab(self.course, self.user))

    def test_course_tab_visible(self):
        self.enable_notes()
        self.assertTrue(self.has_notes_tab(self.course, self.user))
        self.course.advanced_modules = []
        self.assertFalse(self.has_notes_tab(self.course, self.user))
Arthur Barrett committed
93

Arthur Barrett committed
94

Arthur Barrett committed
95
class ApiTest(TestCase):
96

Arthur Barrett committed
97
    def setUp(self):
98
        super(ApiTest, self).setUp()
Arthur Barrett committed
99 100
        self.client = Client()

101
        # Mocks
102 103 104
        patcher = patch.object(api, 'api_enabled', Mock(return_value=True))
        patcher.start()
        self.addCleanup(patcher.stop)
105

Arthur Barrett committed
106 107 108
        # Create two accounts
        self.password = 'abc'
        self.student = User.objects.create_user('student', 'student@test.com', self.password)
Arthur Barrett committed
109
        self.student2 = User.objects.create_user('student2', 'student2@test.com', self.password)
Arthur Barrett committed
110
        self.instructor = User.objects.create_user('instructor', 'instructor@test.com', self.password)
111
        self.course_key = SlashSeparatedCourseKey('HarvardX', 'CB22x', 'The_Ancient_Greek_Hero')
Arthur Barrett committed
112
        self.note = {
Arthur Barrett committed
113
            'user': self.student,
114
            'course_id': self.course_key,
Arthur Barrett committed
115 116 117 118 119 120 121 122
            'uri': '/',
            'text': 'foo',
            'quote': 'bar',
            'range_start': 0,
            'range_start_offset': 0,
            'range_end': 100,
            'range_end_offset': 0,
            'tags': 'a,b,c'
Arthur Barrett committed
123 124
        }

125 126 127
        # Make sure no note with this ID ever exists for testing purposes
        self.NOTE_ID_DOES_NOT_EXIST = 99999

Arthur Barrett committed
128 129 130
    def login(self, as_student=None):
        username = None
        password = self.password
Arthur Barrett committed
131

Arthur Barrett committed
132 133 134 135 136 137 138 139
        if as_student is None:
            username = self.student.username
        else:
            username = as_student.username

        self.client.login(username=username, password=password)

    def url(self, name, args={}):
140
        args.update({'course_id': self.course_key.to_deprecated_string()})
Arthur Barrett committed
141 142 143 144 145 146 147 148 149
        return reverse(name, kwargs=args)

    def create_notes(self, num_notes, create=True):
        notes = []
        for n in range(num_notes):
            note = models.Note(**self.note)
            if create:
                note.save()
            notes.append(note)
Arthur Barrett committed
150 151 152 153 154 155
        return notes

    def test_root(self):
        self.login()

        resp = self.client.get(self.url('notes_api_root'))
Arthur Barrett committed
156
        self.assertEqual(resp.status_code, 200)
Arthur Barrett committed
157 158 159 160
        self.assertNotEqual(resp.content, '')

        content = json.loads(resp.content)

Arthur Barrett committed
161
        self.assertEqual(set(('name', 'version')), set(content.keys()))
Arthur Barrett committed
162 163 164 165 166 167 168 169 170 171 172 173 174 175
        self.assertIsInstance(content['version'], int)
        self.assertEqual(content['name'], 'Notes API')

    def test_index_empty(self):
        self.login()

        resp = self.client.get(self.url('notes_api_notes'))
        self.assertEqual(resp.status_code, 200)
        self.assertNotEqual(resp.content, '')

        content = json.loads(resp.content)
        self.assertEqual(len(content), 0)

    def test_index_with_notes(self):
Arthur Barrett committed
176
        num_notes = 3
Arthur Barrett committed
177 178 179 180 181 182 183 184
        self.login()
        self.create_notes(num_notes)

        resp = self.client.get(self.url('notes_api_notes'))
        self.assertEqual(resp.status_code, 200)
        self.assertNotEqual(resp.content, '')

        content = json.loads(resp.content)
Arthur Barrett committed
185
        self.assertIsInstance(content, list)
Arthur Barrett committed
186 187 188 189 190
        self.assertEqual(len(content), num_notes)

    def test_index_max_notes(self):
        self.login()

Arthur Barrett committed
191
        MAX_LIMIT = api.API_SETTINGS.get('MAX_NOTE_LIMIT')
Arthur Barrett committed
192 193
        num_notes = MAX_LIMIT + 1
        self.create_notes(num_notes)
194

Arthur Barrett committed
195 196 197
        resp = self.client.get(self.url('notes_api_notes'))
        self.assertEqual(resp.status_code, 200)
        self.assertNotEqual(resp.content, '')
198

Arthur Barrett committed
199
        content = json.loads(resp.content)
Arthur Barrett committed
200
        self.assertIsInstance(content, list)
Arthur Barrett committed
201
        self.assertEqual(len(content), MAX_LIMIT)
Arthur Barrett committed
202 203 204 205 206 207 208 209 210

    def test_create_note(self):
        self.login()

        notes = self.create_notes(1)
        self.assertEqual(len(notes), 1)

        note_dict = notes[0].as_dict()
        excluded_fields = ['id', 'user_id', 'created', 'updated']
Arthur Barrett committed
211
        note = dict([(k, v) for k, v in note_dict.items() if k not in excluded_fields])
Arthur Barrett committed
212

Arthur Barrett committed
213 214 215 216
        resp = self.client.post(self.url('notes_api_notes'),
                                json.dumps(note),
                                content_type='application/json',
                                HTTP_X_REQUESTED_WITH='XMLHttpRequest')
Arthur Barrett committed
217 218 219 220 221 222 223 224

        self.assertEqual(resp.status_code, 303)
        self.assertEqual(len(resp.content), 0)

    def test_create_empty_notes(self):
        self.login()

        for empty_test in [None, [], '']:
Arthur Barrett committed
225 226 227 228
            resp = self.client.post(self.url('notes_api_notes'),
                                    json.dumps(empty_test),
                                    content_type='application/json',
                                    HTTP_X_REQUESTED_WITH='XMLHttpRequest')
229
            self.assertEqual(resp.status_code, 400)
Arthur Barrett committed
230 231 232 233 234 235 236 237 238

    def test_create_note_missing_ranges(self):
        self.login()

        notes = self.create_notes(1)
        self.assertEqual(len(notes), 1)
        note_dict = notes[0].as_dict()

        excluded_fields = ['id', 'user_id', 'created', 'updated'] + ['ranges']
Arthur Barrett committed
239
        note = dict([(k, v) for k, v in note_dict.items() if k not in excluded_fields])
Arthur Barrett committed
240

Arthur Barrett committed
241 242 243 244
        resp = self.client.post(self.url('notes_api_notes'),
                                json.dumps(note),
                                content_type='application/json',
                                HTTP_X_REQUESTED_WITH='XMLHttpRequest')
245
        self.assertEqual(resp.status_code, 400)
Arthur Barrett committed
246

Arthur Barrett committed
247
    def test_read_note(self):
Arthur Barrett committed
248 249 250 251 252 253
        self.login()

        notes = self.create_notes(3)
        self.assertEqual(len(notes), 3)

        for note in notes:
254
            resp = self.client.get(self.url('notes_api_note', {'note_id': note.pk}))
Arthur Barrett committed
255 256 257 258
            self.assertEqual(resp.status_code, 200)
            self.assertNotEqual(resp.content, '')

            content = json.loads(resp.content)
259
            self.assertEqual(content['id'], note.pk)
Arthur Barrett committed
260 261 262 263 264
            self.assertEqual(content['user_id'], note.user_id)

    def test_note_doesnt_exist_to_read(self):
        self.login()
        resp = self.client.get(self.url('notes_api_note', {
265
            'note_id': self.NOTE_ID_DOES_NOT_EXIST
Arthur Barrett committed
266 267 268 269 270 271 272 273 274 275 276
        }))
        self.assertEqual(resp.status_code, 404)
        self.assertEqual(resp.content, '')

    def test_student_doesnt_have_permission_to_read_note(self):
        notes = self.create_notes(1)
        self.assertEqual(len(notes), 1)
        note = notes[0]

        # set the student id to a different student (not the one that created the notes)
        self.login(as_student=self.student2)
277
        resp = self.client.get(self.url('notes_api_note', {'note_id': note.pk}))
Arthur Barrett committed
278 279 280
        self.assertEqual(resp.status_code, 403)
        self.assertEqual(resp.content, '')

281 282 283 284 285 286 287 288
    def test_delete_note(self):
        self.login()

        notes = self.create_notes(1)
        self.assertEqual(len(notes), 1)
        note = notes[0]

        resp = self.client.delete(self.url('notes_api_note', {
289
            'note_id': note.pk
290 291 292 293 294
        }))
        self.assertEqual(resp.status_code, 204)
        self.assertEqual(resp.content, '')

        with self.assertRaises(models.Note.DoesNotExist):
295
            models.Note.objects.get(pk=note.pk)
296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312

    def test_note_does_not_exist_to_delete(self):
        self.login()

        resp = self.client.delete(self.url('notes_api_note', {
            'note_id': self.NOTE_ID_DOES_NOT_EXIST
        }))
        self.assertEqual(resp.status_code, 404)
        self.assertEqual(resp.content, '')

    def test_student_doesnt_have_permission_to_delete_note(self):
        notes = self.create_notes(1)
        self.assertEqual(len(notes), 1)
        note = notes[0]

        self.login(as_student=self.student2)
        resp = self.client.delete(self.url('notes_api_note', {
313
            'note_id': note.pk
314 315 316 317 318
        }))
        self.assertEqual(resp.status_code, 403)
        self.assertEqual(resp.content, '')

        try:
319
            models.Note.objects.get(pk=note.pk)
320 321 322
        except models.Note.DoesNotExist:
            self.fail('note should exist and not be deleted because the student does not have permission to do so')

Arthur Barrett committed
323
    def test_update_note(self):
324 325 326 327 328 329 330 331 332 333
        notes = self.create_notes(1)
        note = notes[0]

        updated_dict = note.as_dict()
        updated_dict.update({
            'text': 'itchy and scratchy',
            'tags': ['simpsons', 'cartoons', 'animation']
        })

        self.login()
334
        resp = self.client.put(self.url('notes_api_note', {'note_id': note.pk}),
335 336 337 338 339 340
                               json.dumps(updated_dict),
                               content_type='application/json',
                               HTTP_X_REQUESTED_WITH='XMLHttpRequest')
        self.assertEqual(resp.status_code, 303)
        self.assertEqual(resp.content, '')

341
        actual = models.Note.objects.get(pk=note.pk)
342 343 344
        actual_dict = actual.as_dict()
        for field in ['text', 'tags']:
            self.assertEqual(actual_dict[field], updated_dict[field])
Arthur Barrett committed
345

Arthur Barrett committed
346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389
    def test_search_note_params(self):
        self.login()

        total = 3
        notes = self.create_notes(total)
        invalid_uri = ''.join([note.uri for note in notes])

        tests = [{'limit': 0, 'offset': 0, 'expected_rows': total},
                 {'limit': 0, 'offset': 2, 'expected_rows': total - 2},
                 {'limit': 0, 'offset': total, 'expected_rows': 0},
                 {'limit': 1, 'offset': 0, 'expected_rows': 1},
                 {'limit': 2, 'offset': 0, 'expected_rows': 2},
                 {'limit': total, 'offset': 2, 'expected_rows': 1},
                 {'limit': total, 'offset': total, 'expected_rows': 0},
                 {'limit': total + 1, 'offset': total + 1, 'expected_rows': 0},
                 {'limit': total + 1, 'offset': 0, 'expected_rows': total},
                 {'limit': 0, 'offset': 0, 'uri': invalid_uri, 'expected_rows': 0, 'expected_total': 0}]

        for test in tests:
            params = dict([(k, str(test[k]))
                          for k in ('limit', 'offset', 'uri')
                          if k in test])
            resp = self.client.get(self.url('notes_api_search'),
                                   params,
                                   content_type='application/json',
                                   HTTP_X_REQUESTED_WITH='XMLHttpRequest')

            self.assertEqual(resp.status_code, 200)
            self.assertNotEqual(resp.content, '')

            content = json.loads(resp.content)

            for expected_key in ('total', 'rows'):
                self.assertTrue(expected_key in content)

            if 'expected_total' in test:
                self.assertEqual(content['total'], test['expected_total'])
            else:
                self.assertEqual(content['total'], total)

            self.assertEqual(len(content['rows']), test['expected_rows'])

            for row in content['rows']:
                self.assertTrue('id' in row)
Arthur Barrett committed
390 391 392 393


class NoteTest(TestCase):
    def setUp(self):
394 395
        super(NoteTest, self).setUp()

Arthur Barrett committed
396 397
        self.password = 'abc'
        self.student = User.objects.create_user('student', 'student@test.com', self.password)
398
        self.course_key = SlashSeparatedCourseKey('HarvardX', 'CB22x', 'The_Ancient_Greek_Hero')
Arthur Barrett committed
399 400
        self.note = {
            'user': self.student,
401
            'course_id': self.course_key,
Arthur Barrett committed
402 403 404 405 406 407 408 409 410 411 412
            'uri': '/',
            'text': 'foo',
            'quote': 'bar',
            'range_start': 0,
            'range_start_offset': 0,
            'range_end': 100,
            'range_end_offset': 0,
            'tags': 'a,b,c'
        }

    def test_clean_valid_note(self):
413
        reference_note = models.Note(**self.note)
Arthur Barrett committed
414 415
        body = reference_note.as_dict()

416
        note = models.Note(course_id=self.course_key, user=self.student)
Arthur Barrett committed
417 418 419 420 421 422 423 424 425 426 427 428 429 430
        try:
            note.clean(json.dumps(body))
            self.assertEqual(note.uri, body['uri'])
            self.assertEqual(note.text, body['text'])
            self.assertEqual(note.quote, body['quote'])
            self.assertEqual(note.range_start, body['ranges'][0]['start'])
            self.assertEqual(note.range_start_offset, body['ranges'][0]['startOffset'])
            self.assertEqual(note.range_end, body['ranges'][0]['end'])
            self.assertEqual(note.range_end_offset, body['ranges'][0]['endOffset'])
            self.assertEqual(note.tags, ','.join(body['tags']))
        except ValidationError:
            self.fail('a valid note should not raise an exception')

    def test_clean_invalid_note(self):
431
        note = models.Note(course_id=self.course_key, user=self.student)
Arthur Barrett committed
432 433 434 435 436 437 438 439 440 441 442 443
        for empty_type in (None, '', 0, []):
            with self.assertRaises(ValidationError):
                note.clean(None)

        with self.assertRaises(ValidationError):
            note.clean(json.dumps({
                'text': 'foo',
                'quote': 'bar',
                'ranges': [{} for i in range(10)]  # too many ranges
            }))

    def test_as_dict(self):
444
        note = models.Note(course_id=self.course_key, user=self.student)
Arthur Barrett committed
445 446 447 448
        d = note.as_dict()
        self.assertNotIsInstance(d, basestring)
        self.assertEqual(d['user_id'], self.student.id)
        self.assertTrue('course_id' not in d)