test_models.py 18 KB
Newer Older
1 2 3 4 5
"""
Unit tests for grades models.
"""
from base64 import b64encode
from collections import OrderedDict
6
from datetime import datetime
7 8 9
import ddt
from hashlib import sha1
import json
10
from mock import patch
11

Eric Fischer committed
12
from django.db.utils import IntegrityError
13
from django.test import TestCase
14 15
from django.utils.timezone import now
from freezegun import freeze_time
16
from opaque_keys.edx.locator import CourseLocator, BlockUsageLocator
17
from track.event_transaction_utils import get_event_transaction_id, get_event_transaction_type
18

19 20
from lms.djangoapps.grades.models import (
    BlockRecord,
21
    BlockRecordList,
22
    BLOCK_RECORD_LIST_VERSION,
23
    PersistentCourseGrade,
24 25 26
    PersistentSubsectionGrade,
    VisibleBlocks
)
27 28


29
class BlockRecordListTestCase(TestCase):
30
    """
31
    Verify the behavior of BlockRecordList, particularly around edge cases
32
    """
33 34 35 36 37 38 39
    def setUp(self):
        super(BlockRecordListTestCase, self).setUp()
        self.course_key = CourseLocator(
            org='some_org',
            course='some_course',
            run='some_run'
        )
40 41

    def test_empty_block_record_set(self):
42 43 44 45
        empty_json = u'{"blocks":[],"course_key":"%s","version":%s}' % (
            unicode(self.course_key),
            BLOCK_RECORD_LIST_VERSION,
        )
46 47

        brs = BlockRecordList((), self.course_key)
48 49
        self.assertFalse(brs)
        self.assertEqual(
50 51
            brs.json_value,
            empty_json
52 53
        )
        self.assertEqual(
54
            BlockRecordList.from_json(empty_json),
55 56 57 58
            brs
        )


59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79
class GradesModelTestCase(TestCase):
    """
    Base class for common setup of grades model tests.
    """
    def setUp(self):
        super(GradesModelTestCase, self).setUp()
        self.course_key = CourseLocator(
            org='some_org',
            course='some_course',
            run='some_run'
        )
        self.locator_a = BlockUsageLocator(
            course_key=self.course_key,
            block_type='problem',
            block_id='block_id_a'
        )
        self.locator_b = BlockUsageLocator(
            course_key=self.course_key,
            block_type='problem',
            block_id='block_id_b'
        )
80 81
        self.record_a = BlockRecord(locator=self.locator_a, weight=1, raw_possible=10, graded=False)
        self.record_b = BlockRecord(locator=self.locator_b, weight=1, raw_possible=10, graded=True)
82 83 84 85 86 87 88 89 90 91 92 93 94 95 96


@ddt.ddt
class BlockRecordTest(GradesModelTestCase):
    """
    Test the BlockRecord model.
    """
    def setUp(self):
        super(BlockRecordTest, self).setUp()

    def test_creation(self):
        """
        Tests creation of a BlockRecord.
        """
        weight = 1
97
        raw_possible = 10
98 99 100
        record = BlockRecord(
            self.locator_a,
            weight,
101 102
            raw_possible,
            graded=False,
103 104 105 106
        )
        self.assertEqual(record.locator, self.locator_a)

    @ddt.data(
107 108 109
        (0, 0, "0123456789abcdef", True),
        (1, 10, 'totally_a_real_block_key', False),
        ("BlockRecord is", "a dumb data store", "with no validation", None),
110 111
    )
    @ddt.unpack
112
    def test_serialization(self, weight, raw_possible, block_key, graded):
113
        """
114
        Tests serialization of a BlockRecord using the _asdict() method.
115
        """
116
        record = BlockRecord(block_key, weight, raw_possible, graded)
117 118 119
        expected = OrderedDict([
            ("locator", block_key),
            ("weight", weight),
120 121
            ("raw_possible", raw_possible),
            ("graded", graded),
122 123 124 125 126 127 128 129
        ])
        self.assertEqual(expected, record._asdict())


class VisibleBlocksTest(GradesModelTestCase):
    """
    Test the VisibleBlocks model.
    """
130 131 132 133
    def _create_block_record_list(self, blocks):
        """
        Creates and returns a BlockRecordList for the given blocks.
        """
134
        return VisibleBlocks.objects.create_from_blockrecords(BlockRecordList.from_list(blocks, self.course_key))
135

136 137 138 139
    def test_creation(self):
        """
        Happy path test to ensure basic create functionality works as expected.
        """
140
        vblocks = self._create_block_record_list([self.record_a])
141 142 143
        list_of_block_dicts = [self.record_a._asdict()]
        for block_dict in list_of_block_dicts:
            block_dict['locator'] = unicode(block_dict['locator'])  # BlockUsageLocator is not json-serializable
144
        expected_data = {
145 146 147 148 149 150
            'blocks': [{
                'locator': unicode(self.record_a.locator),
                'raw_possible': 10,
                'weight': 1,
                'graded': self.record_a.graded,
            }],
151
            'course_key': unicode(self.record_a.locator.course_key),
152
            'version': BLOCK_RECORD_LIST_VERSION,
153 154
        }
        expected_json = json.dumps(expected_data, separators=(',', ':'), sort_keys=True)
155
        expected_hash = b64encode(sha1(expected_json).digest())
156
        self.assertEqual(expected_data, json.loads(vblocks.blocks_json))
157 158 159
        self.assertEqual(expected_json, vblocks.blocks_json)
        self.assertEqual(expected_hash, vblocks.hashed)

160
    def test_ordering_matters(self):
161
        """
162 163
        When creating new vblocks, different ordering of blocks produces
        different records in the database.
164
        """
165 166 167 168 169 170 171
        stored_vblocks = self._create_block_record_list([self.record_a, self.record_b])
        repeat_vblocks = self._create_block_record_list([self.record_b, self.record_a])
        same_order_vblocks = self._create_block_record_list([self.record_a, self.record_b])
        new_vblocks = self._create_block_record_list([self.record_b])

        self.assertNotEqual(stored_vblocks.pk, repeat_vblocks.pk)
        self.assertNotEqual(stored_vblocks.hashed, repeat_vblocks.hashed)
172

173 174
        self.assertEqual(stored_vblocks.pk, same_order_vblocks.pk)
        self.assertEqual(stored_vblocks.hashed, same_order_vblocks.hashed)
175 176 177 178 179 180

        self.assertNotEqual(stored_vblocks.pk, new_vblocks.pk)
        self.assertNotEqual(stored_vblocks.hashed, new_vblocks.hashed)

    def test_blocks_property(self):
        """
181 182 183
        Ensures that, given an array of BlockRecord, creating visible_blocks
        and accessing visible_blocks.blocks yields a copy of the initial array.
        Also, trying to set the blocks property should raise an exception.
184
        """
185
        expected_blocks = BlockRecordList.from_list([self.record_a, self.record_b], self.course_key)
186 187
        visible_blocks = self._create_block_record_list(expected_blocks)
        self.assertEqual(expected_blocks, visible_blocks.blocks)
188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203
        with self.assertRaises(AttributeError):
            visible_blocks.blocks = expected_blocks


@ddt.ddt
class PersistentSubsectionGradeTest(GradesModelTestCase):
    """
    Test the PersistentSubsectionGrade model.
    """
    def setUp(self):
        super(PersistentSubsectionGradeTest, self).setUp()
        self.usage_key = BlockUsageLocator(
            course_key=self.course_key,
            block_type='subsection',
            block_id='subsection_12345',
        )
204
        self.block_records = BlockRecordList([self.record_a, self.record_b], self.course_key)
205 206 207 208
        self.params = {
            "user_id": 12345,
            "usage_key": self.usage_key,
            "course_version": "deadbeef",
209
            "subtree_edited_timestamp": "2016-08-01 18:53:24.354741",
210 211 212 213
            "earned_all": 6.0,
            "possible_all": 12.0,
            "earned_graded": 6.0,
            "possible_graded": 8.0,
214
            "visible_blocks": self.block_records,
215
            "attempted": True,
216 217 218 219 220 221
        }

    def test_create(self):
        """
        Tests model creation, and confirms error when trying to recreate model.
        """
222 223 224 225 226 227 228
        created_grade = PersistentSubsectionGrade.create_grade(**self.params)
        with self.assertNumQueries(1):
            read_grade = PersistentSubsectionGrade.read_grade(
                user_id=self.params["user_id"],
                usage_key=self.params["usage_key"],
            )
            self.assertEqual(created_grade, read_grade)
229
            self.assertEqual(read_grade.visible_blocks.blocks, self.block_records)
230
        with self.assertRaises(IntegrityError):
231
            PersistentSubsectionGrade.create_grade(**self.params)
232

233 234 235
    @ddt.data('course_version', 'subtree_edited_timestamp')
    def test_optional_fields(self, field):
        del self.params[field]
236
        PersistentSubsectionGrade.create_grade(**self.params)
237

238
    @ddt.data(
239
        ("user_id", IntegrityError),
240
        ("usage_key", KeyError),
241 242 243 244
        ("earned_all", IntegrityError),
        ("possible_all", IntegrityError),
        ("earned_graded", IntegrityError),
        ("possible_graded", IntegrityError),
245
        ("visible_blocks", KeyError),
246
        ("attempted", KeyError),
247 248 249 250 251 252 253
    )
    @ddt.unpack
    def test_non_optional_fields(self, field, error):
        del self.params[field]
        with self.assertRaises(error):
            PersistentSubsectionGrade.create_grade(**self.params)

254
    @ddt.data(True, False)
255 256
    def test_update_or_create_grade(self, already_created):
        created_grade = PersistentSubsectionGrade.create_grade(**self.params) if already_created else None
257

258 259
        self.params["earned_all"] = 7
        updated_grade = PersistentSubsectionGrade.update_or_create_grade(**self.params)
260
        self.assertEqual(updated_grade.earned_all, 7)
261
        if already_created:
262 263 264
            self.assertEqual(created_grade.id, updated_grade.id)
            self.assertEqual(created_grade.earned_all, 6)

265
    def test_update_or_create_attempted(self):
266 267 268
        grade = PersistentSubsectionGrade.update_or_create_grade(**self.params)
        self.assertIsInstance(grade.first_attempted, datetime)

269
    def test_unattempted(self):
270
        self.params['attempted'] = False
271 272
        self.params['earned_all'] = 0.0
        self.params['earned_graded'] = 0.0
273
        grade = PersistentSubsectionGrade.create_grade(**self.params)
274
        self.assertIsNone(grade.first_attempted)
275
        self.assertEqual(grade.earned_all, 0.0)
276
        self.assertEqual(grade.earned_graded, 0.0)
277 278 279 280 281 282 283 284 285

    def test_first_attempted_not_changed_on_update(self):
        PersistentSubsectionGrade.create_grade(**self.params)
        moment = now()
        grade = PersistentSubsectionGrade.update_or_create_grade(**self.params)
        self.assertLess(grade.first_attempted, moment)

    def test_unattempted_save_does_not_remove_attempt(self):
        PersistentSubsectionGrade.create_grade(**self.params)
286
        self.params['attempted'] = False
287 288 289 290
        grade = PersistentSubsectionGrade.update_or_create_grade(**self.params)
        self.assertIsInstance(grade.first_attempted, datetime)
        self.assertEqual(grade.earned_all, 6.0)

291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324
    def test_update_or_create_event(self):
        with patch('lms.djangoapps.grades.models.tracker') as tracker_mock:
            grade = PersistentSubsectionGrade.update_or_create_grade(**self.params)
        self._assert_tracker_emitted_event(tracker_mock, grade)

    def test_create_event(self):
        with patch('lms.djangoapps.grades.models.tracker') as tracker_mock:
            grade = PersistentSubsectionGrade.create_grade(**self.params)
        self._assert_tracker_emitted_event(tracker_mock, grade)

    def _assert_tracker_emitted_event(self, tracker_mock, grade):
        """
        Helper function to ensure that the mocked event tracker
        was called with the expected info based on the passed grade.
        """
        tracker_mock.emit.assert_called_with(
            u'edx.grades.subsection.grade_calculated',
            {
                'user_id': unicode(grade.user_id),
                'course_id': unicode(grade.course_id),
                'block_id': unicode(grade.usage_key),
                'course_version': unicode(grade.course_version),
                'weighted_total_earned': grade.earned_all,
                'weighted_total_possible': grade.possible_all,
                'weighted_graded_earned': grade.earned_graded,
                'weighted_graded_possible': grade.possible_graded,
                'first_attempted': unicode(grade.first_attempted),
                'subtree_edited_timestamp': unicode(grade.subtree_edited_timestamp),
                'event_transaction_id': unicode(get_event_transaction_id()),
                'event_transaction_type': unicode(get_event_transaction_type()),
                'visible_blocks_hash': unicode(grade.visible_blocks_id),
            }
        )

325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347

@ddt.ddt
class PersistentCourseGradesTest(GradesModelTestCase):
    """
    Tests the PersistentCourseGrade model.
    """
    def setUp(self):
        super(PersistentCourseGradesTest, self).setUp()
        self.params = {
            "user_id": 12345,
            "course_id": self.course_key,
            "course_version": "JoeMcEwing",
            "course_edited_timestamp": datetime(
                year=2016,
                month=8,
                day=1,
                hour=18,
                minute=53,
                second=24,
                microsecond=354741,
            ),
            "percent_grade": 77.7,
            "letter_grade": "Great job",
348
            "passed": True,
349 350 351
        }

    def test_update(self):
352
        created_grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
353 354 355 356 357 358 359
        self.params["percent_grade"] = 88.8
        self.params["letter_grade"] = "Better job"
        updated_grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        self.assertEqual(updated_grade.percent_grade, 88.8)
        self.assertEqual(updated_grade.letter_grade, "Better job")
        self.assertEqual(created_grade.id, updated_grade.id)

360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406
    def test_passed_timestamp(self):
        # When the user has not passed, passed_timestamp is None
        self.params.update({
            u'percent_grade': 25.0,
            u'letter_grade': u'',
            u'passed': False,
        })
        grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        self.assertIsNone(grade.passed_timestamp)

        # After the user earns a passing grade, the passed_timestamp is set
        self.params.update({
            u'percent_grade': 75.0,
            u'letter_grade': u'C',
            u'passed': True,
        })
        grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        passed_timestamp = grade.passed_timestamp
        self.assertEqual(grade.letter_grade, u'C')
        self.assertIsInstance(passed_timestamp, datetime)

        # After the user improves their score, the new grade is reflected, but
        # the passed_timestamp remains the same.
        self.params.update({
            u'percent_grade': 95.0,
            u'letter_grade': u'A',
            u'passed': True,
        })
        grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        self.assertEqual(grade.letter_grade, u'A')
        self.assertEqual(grade.passed_timestamp, passed_timestamp)

        # If the grade later reverts to a failing grade, they keep their passed_timestamp
        self.params.update({
            u'percent_grade': 20.0,
            u'letter_grade': u'',
            u'passed': False,
        })
        grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        self.assertEqual(grade.letter_grade, u'')
        self.assertEqual(grade.passed_timestamp, passed_timestamp)

    @freeze_time(now())
    def test_passed_timestamp_is_now(self):
        grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        self.assertEqual(now(), grade.passed_timestamp)

407 408 409 410
    def test_create_and_read_grade(self):
        created_grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        read_grade = PersistentCourseGrade.read_course_grade(self.params["user_id"], self.params["course_id"])
        for param in self.params:
411 412
            if param == u'passed':
                continue  # passed/passed_timestamp takes special handling, and is tested separately
413
            self.assertEqual(self.params[param], getattr(created_grade, param))
414
        self.assertIsInstance(created_grade.passed_timestamp, datetime)
415 416
        self.assertEqual(created_grade, read_grade)

417 418 419
    @ddt.data('course_version', 'course_edited_timestamp')
    def test_optional_fields(self, field):
        del self.params[field]
420
        grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
421
        self.assertFalse(getattr(grade, field))
422 423 424 425 426 427 428

    @ddt.data(
        ("percent_grade", "Not a float at all", ValueError),
        ("percent_grade", None, IntegrityError),
        ("letter_grade", None, IntegrityError),
        ("course_id", "Not a course key at all", AssertionError),
        ("user_id", None, IntegrityError),
429
        ("grading_policy_hash", None, IntegrityError),
430 431 432 433 434 435 436 437 438 439
    )
    @ddt.unpack
    def test_update_or_create_with_bad_params(self, param, val, error):
        self.params[param] = val
        with self.assertRaises(error):
            PersistentCourseGrade.update_or_create_course_grade(**self.params)

    def test_grade_does_not_exist(self):
        with self.assertRaises(PersistentCourseGrade.DoesNotExist):
            PersistentCourseGrade.read_course_grade(self.params["user_id"], self.params["course_id"])
440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464

    def test_update_or_create_event(self):
        with patch('lms.djangoapps.grades.models.tracker') as tracker_mock:
            grade = PersistentCourseGrade.update_or_create_course_grade(**self.params)
        self._assert_tracker_emitted_event(tracker_mock, grade)

    def _assert_tracker_emitted_event(self, tracker_mock, grade):
        """
        Helper function to ensure that the mocked event tracker
        was called with the expected info based on the passed grade.
        """
        tracker_mock.emit.assert_called_with(
            u'edx.grades.course.grade_calculated',
            {
                'user_id': unicode(grade.user_id),
                'course_id': unicode(grade.course_id),
                'course_version': unicode(grade.course_version),
                'percent_grade': grade.percent_grade,
                'letter_grade': unicode(grade.letter_grade),
                'course_edited_timestamp': unicode(grade.course_edited_timestamp),
                'event_transaction_id': unicode(get_event_transaction_id()),
                'event_transaction_type': unicode(get_event_transaction_type()),
                'grading_policy_hash': unicode(grade.grading_policy_hash),
            }
        )