Add aria-hidden to icons.

ecfca49c · cahrens · Andy Armstrong · 665020d0 · ecfca49c · ecfca49c
Commit ecfca49c authored Nov 16, 2015 by cahrens Committed by Andy Armstrong Dec 15, 2015
20 changed files
--- a/openassessment/templates/openassessmentblock/edit/oa_edit.html
+++ b/openassessment/templates/openassessmentblock/edit/oa_edit.html
@@ -24,7 +24,7 @@
                <p class="openassessment_alert_message">{% trans "A change that you made to this assessment's rubric has an impact on some examples laid out in the settings tab. For more information, go to the Settings section and fix areas highlighted in red." %}</p>
            </div>
            <a href="" rel="view" class="action openassessment_alert_close">
-                <i class="icon-remove-sign"></i>
+                <i class="icon fa fa-times-circle" aria-hidden="true"></i>
                <span class="label is--hidden">{% trans "close alert" %}</span>
            </a>
        </div>

--- a/openassessment/templates/openassessmentblock/grade/oa_grade_complete.html
+++ b/openassessment/templates/openassessmentblock/grade/oa_grade_complete.html
@@ -41,7 +41,7 @@
                        {% with criterion_num=forloop.counter %}
                        <li class="question question--{{ criterion_num }} ui-toggle-visibility">
                            <h4 class="question__title ui-toggle-visibility__control">
-                                <i class="icon fa fa-caret-right"></i>
+                                <i class="icon fa fa-caret-right" aria-hidden="true"></i>
                                <span class="question__title__copy">{{ criterion.label }}</span>

                                <span class="question__score">
@@ -75,7 +75,7 @@
                                                            {{ part.option.label }}

                                                            <span class="ui-hint hint--top" data-hint="{{ part.option.explanation }}">
-                                                              <i class="icon fa fa-info-circle"
+                                                              <i class="icon fa fa-info-circle" aria-hidden="true"
                                                                 title="{% blocktrans with name=part.option.label %}More information about {{ name }}{% endblocktrans %}"></i>
                                                            </span>

@@ -106,7 +106,7 @@
                                                {{ part.option.label }}

                                                <span class="ui-hint hint--top" data-hint="{{ part.option.explanation }}">
-                                                  <i class="icon fa fa-info-circle"
+                                                  <i class="icon fa fa-info-circle" aria-hidden="true"
                                                     title="{% blocktrans with name=part.option.label %}More information about {{ name }}{% endblocktrans %}"></i>
                                                </span>
                                            </span>
@@ -130,7 +130,7 @@
                                                {{ part.option.label }}

                                                <span class="ui-hint hint--top" data-hint="{{ part.option.explanation }}">
-                                                  <i class="icon fa fa-info-circle"
+                                                  <i class="icon fa fa-info-circle" aria-hidden="true"
                                                     title="{% blocktrans with name=part.option.label %}More information about {{ name }}{% endblocktrans %}"></i>
                                                </span>
                                            </span>
@@ -144,7 +144,7 @@
                                <li class="answer--feedback ui-toggle-visibility {% if criterion.options %}is--collapsed{% endif %}">
                                    {% if criterion.options %}
                                    <h5 class="answer--feedback__title ui-toggle-visibility__control">
-                                      <i class="icon fa fa-caret-right"></i>
+                                      <i class="icon fa fa-caret-right" aria-hidden="true"></i>
                                      {% if criterion.self_feedback %}
                                        <span class="answer--feedback__title__copy">{% trans "Additional Comments" %} ({{ criterion.peer_feedback|length|add:'1' }})</span>
                                      {% else %}
@@ -187,7 +187,7 @@
                            {% if peer_assessments or self_assessment.feedback %}
                            <li class="question question--feedback ui-toggle-visibility">
                                <h4 class="question__title ui-toggle-visibility__control">
-                                    <i class="icon fa fa-caret-right"></i>
+                                    <i class="icon fa fa-caret-right" aria-hidden="true"></i>
                                    <span class="question__title__copy">{% trans "Additional comments on your response" %}</span>
                                </h4>

@@ -235,7 +235,7 @@
                {% if peer_assessments %}
                    <form id="submission__feedback" class="submission__feedback ui-toggle-visibility step__content__section is--collapsed" method="post">
                        <h3 class="submission__feedback__title ui-toggle-visibility__control">
-                            <i class="icon fa fa-caret-right"></i>
+                            <i class="icon fa fa-caret-right" aria-hidden="true"></i>
                            <span class="submission__feedback__title__copy">{% trans "Provide Feedback on Peer Assessments" %}</span>
                        </h3>

@@ -244,7 +244,7 @@
                            <div class="submission__feedback__content {{ has_submitted_feedback|yesno:"is--submitted," }}">
                                <span class="transition__status is--hidden" aria-hidden="true">
                                    <span class="wrapper--anim">
-                                        <i class="icon fa fa-spinner fa-spin"></i>
+                                        <i class="icon fa fa-spinner fa-spin" aria-hidden="true"></i>
                                        <span class="copy">{% trans "Submitting Feedback" %}</span>
                                    </span>
                                </span>

--- a/openassessment/templates/openassessmentblock/oa_base.html
+++ b/openassessment/templates/openassessmentblock/oa_base.html
@@ -30,7 +30,7 @@
                            <span class="step__status">
                                <span class="step__status__label">{% trans "This step's status:" %}</span>
                                <span class="step__status__value">
-                                  <i class="icon fa fa-spinner fa-spin"></i>
+                                  <i class="icon fa fa-spinner fa-spin" aria-hidden="true"></i>
                                  <span class="copy">{% trans "Loading" %}</span>
                                </span>
                            </span>

--- a/openassessment/templates/openassessmentblock/oa_rubric.html
+++ b/openassessment/templates/openassessmentblock/oa_rubric.html
@@ -9,7 +9,7 @@
            id="assessment__rubric__question--{{ criterion.order_num }}"
        >
            <h4 class="question__title ui-toggle-visibility__control">
-                <i class="icon fa fa-caret-right"></i>
+                <i class="icon fa fa-caret-right" aria-hidden="true"></i>
                <span id="assessment__rubric__prompt--{{ criterion.order_num }}" class="ui-toggle-visibility__control__copy question__title__copy">{{ criterion.prompt }}</span>
                <span class="label--required sr">* ({% trans "Required" %})</span>
            </h4>

--- a/openassessment/templates/openassessmentblock/peer/oa_peer_cancelled.html
+++ b/openassessment/templates/openassessmentblock/peer/oa_peer_cancelled.html
@@ -11,7 +11,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-      <i class="icon fa fa-exclamation-triangle"></i>
+      <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
    <span class="copy">
        {% trans "Cancelled" %}
    </span>

--- a/openassessment/templates/openassessmentblock/peer/oa_peer_closed.html
+++ b/openassessment/templates/openassessmentblock/peer/oa_peer_closed.html
@@ -10,7 +10,7 @@
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
    <span class="copy">
-    <i class="icon fa fa-exclamation-triangle"></i>
+    <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
        {% with graded_string=graded|stringformat:"s" must_grade_string=must_grade|stringformat:"s" %}
        {% blocktrans with num_graded='<span class="step__status__value--completed">'|safe|add:graded_string|add:"</span>"|safe num_must_grade='<span class="step__status__value--required">'|safe|add:must_grade_string|add:"</span>"|safe %}
            Incomplete ({{ num_graded }} of {{ num_must_grade }})

--- a/openassessment/templates/openassessmentblock/peer/oa_peer_complete.html
+++ b/openassessment/templates/openassessmentblock/peer/oa_peer_complete.html
@@ -9,7 +9,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-check"></i>
+    <i class="icon fa fa-check" aria-hidden="true"></i>
    <span class="copy">
      <span class="step__status__value--completed">{{ graded }}</span> {% trans "Completed" %}
    </span>

--- a/openassessment/templates/openassessmentblock/peer/oa_peer_turbo_mode.html
+++ b/openassessment/templates/openassessmentblock/peer/oa_peer_turbo_mode.html
@@ -13,7 +13,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-check"></i>
+    <i class="icon fa fa-check" aria-hidden="true"></i>
    <span class="copy">
      {% with graded_string=graded|stringformat:"s" %}
      {% blocktrans with num_graded='<span class="step__status__value--completed">'|safe|add:graded_string|add:'</span>'|safe %}
@@ -65,7 +65,7 @@
                                        id="assessment__rubric__question--{{ criterion.order_num }}"
                                    >
                                        <h4 class="question__title ui-toggle-visibility__control">
-                                            <i class="icon fa fa-caret-right"></i>
+                                            <i class="icon fa fa-caret-right" aria-hidden="true"></i>
                                            <span class="ui-toggle-visibility__control__copy question__title__copy">{{ criterion.prompt }}</span>
                                            <span class="label--required sr">* ({% trans "Required" %})</span>
                                        </h4>

--- a/openassessment/templates/openassessmentblock/peer/oa_peer_turbo_mode_waiting.html
+++ b/openassessment/templates/openassessmentblock/peer/oa_peer_turbo_mode_waiting.html
@@ -9,7 +9,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-check"></i>
+    <i class="icon fa fa-check" aria-hidden="true"></i>
    <span class="copy">
      {% with graded_string=graded|stringformat:"s" %}
      {% blocktrans with num_graded='<span class="step__status__value--completed">'|safe|add:graded_string|add:'</span>'|safe %}

--- a/openassessment/templates/openassessmentblock/response/oa_response_cancelled.html
+++ b/openassessment/templates/openassessmentblock/response/oa_response_cancelled.html
@@ -10,7 +10,7 @@
    <span class="step__status">
      <span class="step__status__label">{% trans "This step's status" %}:</span>
      <span class="step__status__value">
-        <i class="icon fa fa-exclamation-triangle"></i>
+        <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
        <span class="copy">{% trans "Cancelled" %}</span>
      </span>
    </span>

--- a/openassessment/templates/openassessmentblock/response/oa_response_closed.html
+++ b/openassessment/templates/openassessmentblock/response/oa_response_closed.html
@@ -8,7 +8,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-exclamation-triangle"></i>
+    <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
    <span class="copy">{% trans "Incomplete" %}</span>
  </span>
 </span>

--- a/openassessment/templates/openassessmentblock/response/oa_response_graded.html
+++ b/openassessment/templates/openassessmentblock/response/oa_response_graded.html
@@ -9,7 +9,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-check"></i>
+    <i class="icon fa fa-check" aria-hidden="true"></i>
    <span class="copy">{% trans "Complete" %}</span>
  </span>
 </span>

--- a/openassessment/templates/openassessmentblock/response/oa_response_submitted.html
+++ b/openassessment/templates/openassessmentblock/response/oa_response_submitted.html
@@ -9,7 +9,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-check"></i>
+    <i class="icon fa fa-check" aria-hidden="true"></i>
    <span class="copy">{% trans "Complete" %}</span>
  </span>
 </span>

--- a/openassessment/templates/openassessmentblock/self/oa_self_cancelled.html
+++ b/openassessment/templates/openassessmentblock/self/oa_self_cancelled.html
@@ -11,7 +11,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-exclamation-triangle"></i>
+    <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
    <span class="copy">
        {% trans "Cancelled" %}
    </span>

--- a/openassessment/templates/openassessmentblock/self/oa_self_closed.html
+++ b/openassessment/templates/openassessmentblock/self/oa_self_closed.html
@@ -9,7 +9,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-exclamation-triangle"></i>
+    <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
    <span class="copy">{% trans "Incomplete" %}</span>
  </span>
 </span>

--- a/openassessment/templates/openassessmentblock/self/oa_self_complete.html
+++ b/openassessment/templates/openassessmentblock/self/oa_self_complete.html
@@ -9,7 +9,7 @@
 <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-check"></i>
+    <i class="icon fa fa-check" aria-hidden="true"></i>
    <span class="copy">{% trans "Complete" %}</span>
  </span>
 </span>

--- a/openassessment/templates/openassessmentblock/student_training/student_training.html
+++ b/openassessment/templates/openassessmentblock/student_training/student_training.html
@@ -86,7 +86,7 @@
                                    id="assessment__rubric__question--{{ criterion.order_num }}"
                                >
                                    <h4 class="question__title ui-toggle-visibility__control">
-                                        <i class="icon fa fa-caret-right"></i>
+                                        <i class="icon fa fa-caret-right" aria-hidden="true"></i>
                                        <span class="question__title__copy">{{ criterion.prompt }}</span>
                                        <span class="label--required sr">* ({% trans "Required" %})</span>
                                    </h4>

--- a/openassessment/templates/openassessmentblock/student_training/student_training_cancelled.html
+++ b/openassessment/templates/openassessmentblock/student_training/student_training_cancelled.html
@@ -10,7 +10,7 @@
  <span class="step__status">
    <span class="step__status__label">{% trans "This step's status" %}:</span>
    <span class="step__status__value">
-        <i class="icon fa fa-exclamation-triangle"></i>
+        <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
        <span class="copy">{% trans "Cancelled" %}</span>
    </span>
  </span>

--- a/openassessment/templates/openassessmentblock/student_training/student_training_closed.html
+++ b/openassessment/templates/openassessmentblock/student_training/student_training_closed.html
@@ -9,7 +9,7 @@
    <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-exclamation-triangle"></i>
+    <i class="icon fa fa-exclamation-triangle" aria-hidden="true"></i>
    <span class="copy">{% trans "Incomplete" %}</span>
  </span>
 </span>

--- a/openassessment/templates/openassessmentblock/student_training/student_training_complete.html
+++ b/openassessment/templates/openassessmentblock/student_training/student_training_complete.html
@@ -9,7 +9,7 @@
    <span class="step__status">
  <span class="step__status__label">{% trans "This step's status" %}:</span>
  <span class="step__status__value">
-    <i class="icon fa fa-check"></i>
+    <i class="icon fa fa-check" aria-hidden="true"></i>
    <span class="copy">{% trans "Complete" %}</span>
  </span>
 </span>