Ensure that all validation errors are marked.

openassessment/xblock/static/js/src/studio/oa_container_item.js

@@ -393,7 +393,7 @@ OpenAssessment.RubricCriterion.prototype = {
     validate: function() {
         var isValid = true;
         $.each(this.optionContainer.getAllItems(), function() {
-            isValid = (isValid && this.validate());
+            isValid = (this.validate() && isValid);
         });
         return isValid;
     },

openassessment/xblock/static/js/src/studio/oa_edit.js

@@ -232,7 +232,9 @@ OpenAssessment.StudioView.prototype = {
 
     **/
     validate: function() {
-        return this.settingsView.validate() && this.rubricView.validate();
+        var settingsValid = this.settingsView.validate();
+        var rubricValid = this.rubricView.validate();
+        return settingsValid && rubricValid;
     },
 
    /**

openassessment/xblock/static/js/src/studio/oa_edit_assessment.js

@@ -147,7 +147,9 @@ OpenAssessment.EditPeerAssessmentView.prototype = {
 
     **/
     validate: function() {
-        return this.startDatetimeControl.validate() && this.dueDatetimeControl.validate();
+        var startValid = this.startDatetimeControl.validate();
+        var dueValid = this.dueDatetimeControl.validate();
+        return startValid && dueValid;
     },
 
    /**
@@ -297,7 +299,9 @@ OpenAssessment.EditSelfAssessmentView.prototype = {
 
     **/
     validate: function() {
-        return this.startDatetimeControl.validate() && this.dueDatetimeControl.validate();
+        var startValid = this.startDatetimeControl.validate();
+        var dueValid = this.dueDatetimeControl.validate();
+        return startValid && dueValid;
     },
 
    /**

openassessment/xblock/static/js/src/studio/oa_edit_rubric.js

@@ -202,7 +202,7 @@ OpenAssessment.EditRubricView.prototype = {
         var isValid = true;
 
         $.each(this.getAllCriteria(), function() {
-            isValid = (isValid && this.validate());
+            isValid = (this.validate() && isValid);
         });
 
         return isValid;

openassessment/xblock/static/js/src/studio/oa_edit_settings.js

@@ -208,14 +208,14 @@ OpenAssessment.EditSettingsView.prototype = {
     **/
     validate: function() {
         // Validate the start and due datetime controls
-        var isValid = (
-            this.startDatetimeControl.validate() &&
-            this.dueDatetimeControl.validate()
-        );
+        var isValid = true;
+
+        isValid = (this.startDatetimeControl.validate() && isValid);
+        isValid = (this.dueDatetimeControl.validate() && isValid);
 
         // Validate each of the assessment views
         $.each(this.assessmentViews, function() {
-            isValid = (isValid && this.validate());
+            isValid = (this.validate() && isValid);
         });
 
         return isValid;