Fixup: do not show NaN in student training labels

openassessment/xblock/static/js/spec/studio/oa_edit_listeners.js

@@ -79,6 +79,29 @@ describe("OpenAssessment.StudentTrainingListener", function() {
         );
     });
 
+    it("updates the label of an option with invalid points", function() {
+        // If an option has invalid points, the points will be set to NaN
+        listener.optionUpdated({
+            criterionName: "criterion_with_two_options",
+            name: "option_1",
+            label: "This is a new label!",
+            points: NaN
+        });
+
+        // Invalid points should be labeled as such
+        assertExampleLabels(
+            listener.examplesOptionsLabels(),
+            {
+                criterion_with_two_options: {
+                    "": "Not Scored",
+                    option_1: "This is a new label!",
+                    option_2: "Good - 2 points"
+                }
+            }
+        );
+
+    });
+
     it("removes an option and displays an alert", function() {
         // Initial state, set by the fixture
         assertExampleLabels(

openassessment/xblock/static/js/src/studio/oa_container_item.js

@@ -39,19 +39,26 @@ OpenAssessment.ItemUtilities = {
         }
         var singularString = label + " - " + points + " point";
         var multipleString = label + " - " + points + " points";
+
         // If the option doesn't have a data points value, that indicates to us that it is not a user-specified option,
         // but represents the "Not Selected" option which all criterion drop-downs have.
-        if (typeof points === 'undefined') {
-            $(element).text(
-                gettext('Not Selected')
-            );
+        var finalLabel = "";
+        if (points === undefined) {
+            finalLabel = gettext('Not Selected');
+        }
+
+        // If the points are invalid, we'll be given NaN
+        // Don't show this to the user.
+        else if (isNaN(points)) {
+            finalLabel = label;
         }
+
         // Otherwise, set the text of the option element to be the properly conjugated, translated string.
         else {
-            $(element).text(
-                ngettext(singularString, multipleString, points)
-            );
+            finalLabel = ngettext(singularString, multipleString, points);
         }
+
+        $(element).text(finalLabel);
     }
 };
 

openassessment/xblock/static/js/src/studio/oa_edit_listeners.js

@@ -22,6 +22,7 @@ OpenAssessment.StudentTrainingListener.prototype = {
     optionUpdated: function(data) {
         var view = this;
         var sel = '.openassessment_training_example_criterion[data-criterion="' + data.criterionName + '"]';
+
         $(sel, this.element).each(
             function() {
                 var criterion = this;