Skip to content

  • Projects
  • Groups
  • Snippets
  • Help
  • This project
    • Loading...
  • Sign in / Register
E
edx-ora2
  • Overview
    • Overview
    • Details
    • Activity
    • Cycle Analytics
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
  • Issues 0
    • Issues 0
    • List
    • Board
    • Labels
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • edx
  • edx-ora2
  • Repository

Switch branch/tag
  • edx-ora2
  • openassessment
  • workflow
  • api.py
Find file
BlameHistoryPermalink
  • Eric Fischer's avatar
    Clean up update_from_assessments() codepath · e601a79d
    Previously, api.update_from_assessments() would call model.
    update_from_assessments(), then api._serialized_with_details(reqs), which
    would duplicate the update work we *just* did as part of getting the
    status. Now, update() and get_details() are totally seperate operations, and
    _serialized_with_details() is a read-only method that does not need to have
    requirements passed in.
    
    I've also standardized student_training and peer, the two assessment types that
    do *not* auto-complete on None requirements, to return False if None, and error
    out if passed {}. This is to allow staff_assess to pass None to indicate
    "Update thyself, if you don't depend on requirements" to the other step types.
    
    Also adding test_requirements_changed(), to confirm that workflows are updated
    when requirements change, even though thoe requirements are no longer explicitly
    passed to the getter.
    Eric Fischer committed Dec 15, 2015
    e601a79d
api.py 18 KB
Edit