imrov

notesapi/v1/models.py

@@ -39,7 +39,7 @@ class Note(models.Model):
             raise ValidationError('Note must have a course_id and usage_id and user_id.')
 
         ranges = note.get('ranges')
-        if ranges is None:
+        if not ranges:
             raise ValidationError('Note must contain at least one range.')
 
         self.ranges = json.dumps(ranges)

notesapi/v1/tests/test_views.py

@@ -176,8 +176,7 @@ class AnnotationViewTests(BaseAnnotationViewTests):
         """
         Ensure we can get an existing annotation.
         """
-        note = self.payload
-        note_id = self._create_annotation(**note)['id']
+        note_id = self._create_annotation(**self.payload)['id']
 
         url = reverse('api:v1:annotations_detail', kwargs={'annotation_id': note_id})
         response = self.client.get(url, self.headers)