Merge pull request #20 from edx/ned/also-check-delattr

Also check delattr for literal-used-as-attribute

edx_lint/pylint/getattr_check.py

@@ -40,7 +40,7 @@ class GetSetAttrLiteralChecker(BaseChecker):
             if len(node.args) != 2:
                 # We only attend to 2-argument getattr()
                 return
-        elif node.func.name == "setattr":
+        elif node.func.name in ["setattr", "delattr"]:
             pass
         else:
             # Not a function we care about.

test/input/func_getattr_literals.py

@@ -7,3 +7,5 @@ def do_things(name):
     world = getattr(name, "hello", 17)
     setattr(name, "hello", hello)
     setattr(name, "h" + "ello", world)
+    delattr(name, "something")
+    delattr(name, "FOO".lower())

test/messages/func_getattr_literals.txt

 C:  6:do_things: getattr using a literal attribute name
 C:  8:do_things: setattr using a literal attribute name
+C: 10:do_things: delattr using a literal attribute name